[v2] migration: assert that the same migration handler is not being added twice

[PATCH v2] migration: assert that the same migration handler is not being added twice

Ani Sinha posted 1 patch 3 weeks, 6 days ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260311070114.164434-1-anisinha@redhat.com

Maintainers: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>

migration/migration.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH v2] migration: assert that the same migration handler is not being added twice

Posted by Ani Sinha 3 weeks, 6 days ago

Currently the code that adds a migration blocker does not check if the same
blocker already exists. Assert that the migration handler being added has
not been added already.

CC: Markus Armbruster <armbru@redhat.com>
CC: Peter Xu <peterx@redhat.com>
CC: Prasad Pandit <pjp@fedoraproject.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
 migration/migration.c | 2 ++
 1 file changed, 2 insertions(+)

changelog:
v2: fix indentation

diff --git a/migration/migration.c b/migration/migration.c
index f949708629..4459d85ea5 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1694,6 +1694,8 @@ static int add_blockers(Error **reasonp, unsigned modes, Error **errp)
 {
     for (MigMode mode = 0; mode < MIG_MODE__MAX; mode++) {
         if (modes & BIT(mode)) {
+            assert(g_slist_index(migration_blockers[mode],
+                                 *reasonp) == -1);
             migration_blockers[mode] = g_slist_prepend(migration_blockers[mode],
                                                        *reasonp);
         }
-- 
2.52.0