virtio-snd: snapshot prep cleanups

[PATCH 0/3] virtio-snd: snapshot prep cleanups

Roman Kiryanov posted 3 patches 4 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260310235632.3987668-1-rkir@google.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Manos Pitsidianakis <manos.pitsidianakis@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>

hw/audio/virtio-snd.c         | 21 +++++++++------------
include/hw/audio/virtio-snd.h | 17 +++++++++++++----
2 files changed, 22 insertions(+), 16 deletions(-)

Expand all Fold all

[PATCH 0/3] virtio-snd: snapshot prep cleanups

Posted by Roman Kiryanov 4 weeks ago

I am currently working on adding snapshot support for the virtio-snd
device. While implementing the VMStateDescription, I noticed that the
device currently retains more internal state than is strictly necessary,
including unused fields and full transport-specific layouts.

This patch series cleans up the internal PCM state to reduce the overall
allocation footprint and simplify the upcoming snapshotting and migration
handling code. 

Roman Kiryanov (3):
  virtio-snd: remove the unused field
  virtio-snd: remove virtio_snd_pcm_set_params from VirtIOSoundPCMStream
  virtio-snd: introduce VirtIOPcmParams

 hw/audio/virtio-snd.c         | 21 +++++++++------------
 include/hw/audio/virtio-snd.h | 17 +++++++++++++----
 2 files changed, 22 insertions(+), 16 deletions(-)

-- 
2.53.0.473.g4a7958ca14-goog

Re: [PATCH 0/3] virtio-snd: snapshot prep cleanups

Posted by Marc-André Lureau 1 week, 6 days ago

Hi

On Wed, Mar 11, 2026 at 3:57 AM Roman Kiryanov <rkir@google.com> wrote:
>
> I am currently working on adding snapshot support for the virtio-snd
> device. While implementing the VMStateDescription, I noticed that the
> device currently retains more internal state than is strictly necessary,
> including unused fields and full transport-specific layouts.
>
> This patch series cleans up the internal PCM state to reduce the overall
> allocation footprint and simplify the upcoming snapshotting and migration
> handling code.
>
> Roman Kiryanov (3):
>   virtio-snd: remove the unused field
>   virtio-snd: remove virtio_snd_pcm_set_params from VirtIOSoundPCMStream
>   virtio-snd: introduce VirtIOPcmParams
>
>  hw/audio/virtio-snd.c         | 21 +++++++++------------
>  include/hw/audio/virtio-snd.h | 17 +++++++++++++----
>  2 files changed, 22 insertions(+), 16 deletions(-)

For the series:
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

-- 
Marc-André Lureau

Re: [PATCH 0/3] virtio-snd: snapshot prep cleanups

Posted by Roman Kiryanov 2 weeks ago

On Tue, Mar 10, 2026 at 4:56 PM Roman Kiryanov <rkir@google.com> wrote:
> I am currently working on adding snapshot support for the virtio-snd device.
>
> This patch series cleans up the internal PCM state ...

Hi everyone, just a quick ping on this cleanup series.

Let me know if anyone has had a chance to look over these patch series
or if there are any concerns.

Thanks, Roman