1. Patchew
  2. QEMU
  3. [PATCH v4 00/16] gdbstub: Always infer base register index from GDB XML
  4. View patch

[PATCH v4 02/16] tests/tcg: Disable prot-none test on GitLab

Philippe Mathieu-Daudé posted 16 patches 4 weeks ago
Maintainers: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, Laurent Vivier <laurent@vivier.eu>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>, Song Gao <gaosong@loongson.cn>, Bibo Mao <maobibo@loongson.cn>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Thomas Huth <thuth@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Brian Cain <brian.cain@oss.qualcomm.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>
[PATCH v4 02/16] tests/tcg: Disable prot-none test on GitLab
Posted by Philippe Mathieu-Daudé 4 weeks ago 
When adding gdb-multiarch on our container images, we
see the prot-none tests to pass on GitHub but fail on
GitLab. Disable and track:
https://gitlab.com/qemu-project/qemu/-/issues/3329

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/tcg/multiarch/Makefile.target | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefile.target
index 73c2a78215c..70e2ac38f5a 100644
--- a/tests/tcg/multiarch/Makefile.target
+++ b/tests/tcg/multiarch/Makefile.target
@@ -117,12 +117,17 @@ run-gdbstub-registers: sha512
 		--bin $< --test $(MULTIARCH_SRC)/gdbstub/registers.py, \
 	checking register enumeration)
 
+# The prot-none test was skipped on gitlab due to missing gdb-multiarch,
+# however it seems to have bitrotten. Disable, it is tracked as
+# https://gitlab.com/qemu-project/qemu/-/issues/3329
+ifneq ($(GITLAB_CI),)
 run-gdbstub-prot-none: prot-none
 	$(call run-test, $@, env PROT_NONE_PY=1 $(GDB_SCRIPT) \
 		--gdb $(GDB) \
 		--qemu $(QEMU) --qargs "$(QEMU_OPTS)" \
 		--bin $< --test $(MULTIARCH_SRC)/gdbstub/prot-none.py, \
 	accessing PROT_NONE memory)
+endif
 
 run-gdbstub-catch-syscalls: catch-syscalls
 	$(call run-test, $@, $(GDB_SCRIPT) \
-- 
2.53.0
Re: [PATCH v4 02/16] tests/tcg: Disable prot-none test on GitLab
Posted by Philippe Mathieu-Daudé 4 weeks ago 
On 11/3/26 00:20, Philippe Mathieu-Daudé wrote:
> When adding gdb-multiarch on our container images, we
> see the prot-none tests to pass on GitHub but fail on
> GitLab. Disable and track:
> https://gitlab.com/qemu-project/qemu/-/issues/3329
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tests/tcg/multiarch/Makefile.target | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefile.target
> index 73c2a78215c..70e2ac38f5a 100644
> --- a/tests/tcg/multiarch/Makefile.target
> +++ b/tests/tcg/multiarch/Makefile.target
> @@ -117,12 +117,17 @@ run-gdbstub-registers: sha512
>   		--bin $< --test $(MULTIARCH_SRC)/gdbstub/registers.py, \
>   	checking register enumeration)
>   
> +# The prot-none test was skipped on gitlab due to missing gdb-multiarch,
> +# however it seems to have bitrotten. Disable, it is tracked as
> +# https://gitlab.com/qemu-project/qemu/-/issues/3329
> +ifneq ($(GITLAB_CI),)
>   run-gdbstub-prot-none: prot-none
>   	$(call run-test, $@, env PROT_NONE_PY=1 $(GDB_SCRIPT) \
>   		--gdb $(GDB) \
>   		--qemu $(QEMU) --qargs "$(QEMU_OPTS)" \
>   		--bin $< --test $(MULTIARCH_SRC)/gdbstub/prot-none.py, \
>   	accessing PROT_NONE memory)

Makefile is harder than meson, I had forgotten about it =)

To be squashed:

-- >8 --
diff --git a/tests/tcg/multiarch/Makefile.target 
b/tests/tcg/multiarch/Makefile.target
index 23377f7a4e3..b05bde23df0 100644
--- a/tests/tcg/multiarch/Makefile.target
+++ b/tests/tcg/multiarch/Makefile.target
@@ -120,8 +120,10 @@ run-gdbstub-registers: sha512
  # The prot-none test was skipped on gitlab due to missing gdb-multiarch,
  # however it seems to have bitrotten. Disable, it is tracked as
  # https://gitlab.com/qemu-project/qemu/-/issues/3329
-ifneq ($(GITLAB_CI),)
  run-gdbstub-prot-none: prot-none
+ifeq ($(GITLAB_CI),)
+       $(call skip-test, $<, "Broken on GitLab")
+else
         $(call run-test, $@, env PROT_NONE_PY=1 $(GDB_SCRIPT) \
                 --gdb $(GDB) \
                 --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \
---

> +endif
>   
>   run-gdbstub-catch-syscalls: catch-syscalls
>   	$(call run-test, $@, $(GDB_SCRIPT) \
Re: [PATCH v4 02/16] tests/tcg: Disable prot-none test on GitLab
Posted by Philippe Mathieu-Daudé 4 weeks ago 
On 11/3/26 00:37, Philippe Mathieu-Daudé wrote:
> On 11/3/26 00:20, Philippe Mathieu-Daudé wrote:
>> When adding gdb-multiarch on our container images, we
>> see the prot-none tests to pass on GitHub but fail on
>> GitLab. Disable and track:
>> https://gitlab.com/qemu-project/qemu/-/issues/3329
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   tests/tcg/multiarch/Makefile.target | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/ 
>> multiarch/Makefile.target
>> index 73c2a78215c..70e2ac38f5a 100644
>> --- a/tests/tcg/multiarch/Makefile.target
>> +++ b/tests/tcg/multiarch/Makefile.target
>> @@ -117,12 +117,17 @@ run-gdbstub-registers: sha512
>>           --bin $< --test $(MULTIARCH_SRC)/gdbstub/registers.py, \
>>       checking register enumeration)
>> +# The prot-none test was skipped on gitlab due to missing gdb-multiarch,
>> +# however it seems to have bitrotten. Disable, it is tracked as
>> +# https://gitlab.com/qemu-project/qemu/-/issues/3329
>> +ifneq ($(GITLAB_CI),)
>>   run-gdbstub-prot-none: prot-none
>>       $(call run-test, $@, env PROT_NONE_PY=1 $(GDB_SCRIPT) \
>>           --gdb $(GDB) \
>>           --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \
>>           --bin $< --test $(MULTIARCH_SRC)/gdbstub/prot-none.py, \
>>       accessing PROT_NONE memory)
> 
> Makefile is harder than meson, I had forgotten about it =)
> 
> To be squashed:
> 
> -- >8 --
> diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/ 
> Makefile.target
> index 23377f7a4e3..b05bde23df0 100644
> --- a/tests/tcg/multiarch/Makefile.target
> +++ b/tests/tcg/multiarch/Makefile.target
> @@ -120,8 +120,10 @@ run-gdbstub-registers: sha512
>   # The prot-none test was skipped on gitlab due to missing gdb-multiarch,
>   # however it seems to have bitrotten. Disable, it is tracked as
>   # https://gitlab.com/qemu-project/qemu/-/issues/3329
> -ifneq ($(GITLAB_CI),)
>   run-gdbstub-prot-none: prot-none
> +ifeq ($(GITLAB_CI),)
> -ifneq ($(GITLAB_CI),)

This correctly log:

   SKIPPED prot-none on arm because Broken on GitLab

https://gitlab.com/philmd/qemu/-/jobs/13441410520#L3358

> +       $(call skip-test, $<, "Broken on GitLab")
> +else
>          $(call run-test, $@, env PROT_NONE_PY=1 $(GDB_SCRIPT) \
>                  --gdb $(GDB) \
>                  --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \
> ---
> 
>> +endif
>>   run-gdbstub-catch-syscalls: catch-syscalls
>>       $(call run-test, $@, $(GDB_SCRIPT) \
>
Re: [PATCH v4 02/16] tests/tcg: Disable prot-none test on GitLab
Posted by Pierrick Bouvier 4 weeks ago 
On 3/10/26 4:20 PM, Philippe Mathieu-Daudé wrote:
> When adding gdb-multiarch on our container images, we
> see the prot-none tests to pass on GitHub but fail on
> GitLab. Disable and track:
> https://gitlab.com/qemu-project/qemu/-/issues/3329
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tests/tcg/multiarch/Makefile.target | 5 +++++
>   1 file changed, 5 insertions(+)
> 

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.