[PATCH 0/8] migration-test: Plumbing

Fabiano Rosas posted 8 patches 1 month ago
Only 0 patches received!
There is a newer version of this series
io/channel-tls.c                          |  4 ++-
migration/migration.c                     |  5 +++
migration/multifd.c                       | 27 +++++++--------
tests/qtest/migration/colo-tests.c        |  8 ++++-
tests/qtest/migration/compression-tests.c | 18 ++++++----
tests/qtest/migration/cpr-tests.c         | 25 +++++++++-----
tests/qtest/migration/file-tests.c        | 41 ++++++++++++++++-------
tests/qtest/migration/framework.c         | 31 ++++++++++++-----
tests/qtest/migration/framework.h         |  7 ++++
tests/qtest/migration/migration-util.c    | 19 ++++++++---
tests/qtest/migration/migration-util.h    |  2 +-
tests/qtest/migration/misc-tests.c        |  8 ++---
tests/qtest/migration/precopy-tests.c     | 21 +++++++-----
tests/qtest/migration/tls-tests.c         | 30 +++++++++++------
14 files changed, 165 insertions(+), 81 deletions(-)
[PATCH 0/8] migration-test: Plumbing
Posted by Fabiano Rosas 1 month ago
Fix leaks. A couple of normal ones and a few that happen due to a test
expecting failure in the destination side, but exit-on-error=true so
the coroutine just exits the entire process while a few resources are
still allocated, but outside of the scope of the migration code.

I brought a couple of cleanup patches from another in-flight series to
be able to force-set exit-on-error=false for the tests that are
causing leaks, that way we don't need to complicate the migration
cleanup code trying to reach into other subsystems to free memory when
QEMU is already exiting.

CI run: https://gitlab.com/farosas/qemu/-/pipelines/2375586934

--enable-asan --enable-ubsan build is clean for x86_64 migration-test --full

Fabiano Rosas (8):
  tests/qtest/migration: Fix leak of migration tests data
  tests/qtest/migration: Change validate_uuid test to not trigger
    exit(1)
  tests/qtest/migration: Fix misuse of listen_uri
  tests/qtest/migration: Stop invoking migrate_incoming from hooks
  tests/qtest/migration: Force exit-on-error=false when appropriate
  io: Fix TLS bye task leak
  tests/qtest/migration: Fix leak in CPR exec test
  migration/multifd: Fix leaks of TLS error objects

 io/channel-tls.c                          |  4 ++-
 migration/migration.c                     |  5 +++
 migration/multifd.c                       | 27 +++++++--------
 tests/qtest/migration/colo-tests.c        |  8 ++++-
 tests/qtest/migration/compression-tests.c | 18 ++++++----
 tests/qtest/migration/cpr-tests.c         | 25 +++++++++-----
 tests/qtest/migration/file-tests.c        | 41 ++++++++++++++++-------
 tests/qtest/migration/framework.c         | 31 ++++++++++++-----
 tests/qtest/migration/framework.h         |  7 ++++
 tests/qtest/migration/migration-util.c    | 19 ++++++++---
 tests/qtest/migration/migration-util.h    |  2 +-
 tests/qtest/migration/misc-tests.c        |  8 ++---
 tests/qtest/migration/precopy-tests.c     | 21 +++++++-----
 tests/qtest/migration/tls-tests.c         | 30 +++++++++++------
 14 files changed, 165 insertions(+), 81 deletions(-)

-- 
2.51.0
Re: [PATCH 0/8] migration-test: Plumbing
Posted by Fabiano Rosas 1 month ago
Fabiano Rosas <farosas@suse.de> writes:

> Fix leaks. A couple of normal ones and a few that happen due to a test
> expecting failure in the destination side, but exit-on-error=true so
> the coroutine just exits the entire process while a few resources are
> still allocated, but outside of the scope of the migration code.
>
> I brought a couple of cleanup patches from another in-flight series to
> be able to force-set exit-on-error=false for the tests that are
> causing leaks, that way we don't need to complicate the migration
> cleanup code trying to reach into other subsystems to free memory when
> QEMU is already exiting.
>
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/2375586934
>
> --enable-asan --enable-ubsan build is clean for x86_64 migration-test --full
>
> Fabiano Rosas (8):
>   tests/qtest/migration: Fix leak of migration tests data
>   tests/qtest/migration: Change validate_uuid test to not trigger
>     exit(1)
>   tests/qtest/migration: Fix misuse of listen_uri
>   tests/qtest/migration: Stop invoking migrate_incoming from hooks
>   tests/qtest/migration: Force exit-on-error=false when appropriate
>   io: Fix TLS bye task leak
>   tests/qtest/migration: Fix leak in CPR exec test
>   migration/multifd: Fix leaks of TLS error objects
>
>  io/channel-tls.c                          |  4 ++-
>  migration/migration.c                     |  5 +++
>  migration/multifd.c                       | 27 +++++++--------
>  tests/qtest/migration/colo-tests.c        |  8 ++++-
>  tests/qtest/migration/compression-tests.c | 18 ++++++----
>  tests/qtest/migration/cpr-tests.c         | 25 +++++++++-----
>  tests/qtest/migration/file-tests.c        | 41 ++++++++++++++++-------
>  tests/qtest/migration/framework.c         | 31 ++++++++++++-----
>  tests/qtest/migration/framework.h         |  7 ++++
>  tests/qtest/migration/migration-util.c    | 19 ++++++++---
>  tests/qtest/migration/migration-util.h    |  2 +-
>  tests/qtest/migration/misc-tests.c        |  8 ++---
>  tests/qtest/migration/precopy-tests.c     | 21 +++++++-----
>  tests/qtest/migration/tls-tests.c         | 30 +++++++++++------
>  14 files changed, 165 insertions(+), 81 deletions(-)

Sorry if this breaks the thread, but I left the cover letter behind by
mistake.

Rest of the series is:

[PATCH 1/8] tests/qtest/migration: Fix leak of migration tests data
20260310135540.8679-1-farosas@suse.de
https://lore.kernel.org/r/20260310135540.8679-1-farosas@suse.de