[v2] hw/char: clear dangling GLib event source tag

[PATCH v2] hw/char: clear dangling GLib event source tag

Matthew Penney posted 1 patch 3 weeks ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260305213308.96441-1-matt@matthewpenney.net

Maintainers: Laurent Vivier <lvivier@redhat.com>, Amit Shah <amit@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

hw/char/virtio-console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] hw/char: clear dangling GLib event source tag

Posted by Matthew Penney 3 weeks ago

Clear dangling GLib event source tag when virtio-console is
unrealized. This prevents a stale tag from being used, and
maintains consistency with the rest of virtio-console.

v2:
Use g_clear_handle_id() per advice from Marc-André Lureau

Signed-off-by: Matthew Penney <matt@matthewpenney.net>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/char/virtio-console.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c
index 25db0f019b..efe7cd6772 100644
--- a/hw/char/virtio-console.c
+++ b/hw/char/virtio-console.c
@@ -257,7 +257,7 @@ static void virtconsole_unrealize(DeviceState *dev)
     VirtConsole *vcon = VIRTIO_CONSOLE(dev);
 
     if (vcon->watch) {
-        g_source_remove(vcon->watch);
+        g_clear_handle_id(&vcon->watch, g_source_remove);
     }
 }
 
-- 
2.53.0

Re: [PATCH v2] hw/char: clear dangling GLib event source tag

Posted by Philippe Mathieu-Daudé 2 days, 11 hours ago

On 5/3/26 22:33, Matthew Penney wrote:
> Clear dangling GLib event source tag when virtio-console is
> unrealized. This prevents a stale tag from being used, and
> maintains consistency with the rest of virtio-console.
> 
> v2:
> Use g_clear_handle_id() per advice from Marc-André Lureau
> 
> Signed-off-by: Matthew Penney <matt@matthewpenney.net>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   hw/char/virtio-console.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Merged as commit 34aad589019c8687fb3b19ba79d64d97071a7205, thanks.

Re: [PATCH v2] hw/char: clear dangling GLib event source tag

Posted by Matthew Penney 6 days, 16 hours ago

Hi,

Just a gentle ping regarding the v2 patch I sent a couple of weeks ago.
Patchew: https://patchew.org/QEMU/20260305213308.96441-1-matt@matthewpenney.net/

Thanks for your time.

Best regards,
Matthew Penney



Sent with Proton Mail secure email.

On Thursday, 5 March 2026 at 21:33, Matthew Penney <matt@matthewpenney.net> wrote:

> Clear dangling GLib event source tag when virtio-console is
> unrealized. This prevents a stale tag from being used, and
> maintains consistency with the rest of virtio-console.
> 
> v2:
> Use g_clear_handle_id() per advice from Marc-André Lureau
> 
> Signed-off-by: Matthew Penney <matt@matthewpenney.net>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/char/virtio-console.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c
> index 25db0f019b..efe7cd6772 100644
> --- a/hw/char/virtio-console.c
> +++ b/hw/char/virtio-console.c
> @@ -257,7 +257,7 @@ static void virtconsole_unrealize(DeviceState *dev)
>      VirtConsole *vcon = VIRTIO_CONSOLE(dev);
>  
>      if (vcon->watch) {
> -        g_source_remove(vcon->watch);
> +        g_clear_handle_id(&vcon->watch, g_source_remove);
>      }
>  }
>  
> -- 
> 2.53.0
> 
>