1. Patchew
  2. QEMU
  3. View series

[PATCH v3 00/18] migration: more bool+errp APIs

Vladimir Sementsov-Ogievskiy posted 18 patches 3 weeks, 1 day ago
Failed in applying to current master (apply log)
Maintainers: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>, Dmitry Osipenko <dmitry.osipenko@collabora.com>, "Michael S. Tsirkin" <mst@redhat.com>, Dmitry Fleytman <dmitry.fleytman@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Nicholas Piggin <npiggin@gmail.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Gautam Menghani <gautam@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Stefan Weil <sw@weilnetz.de>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Farhan Ali <alifm@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Thomas Huth <thuth@redhat.com>, Mark Kanda <mark.kanda@oracle.com>, Ben Chaney <bchaney@akamai.com>, Peter Maydell <peter.maydell@linaro.org>, Chinmay Rath <rathc@linux.ibm.com>
docs/devel/migration/main.rst |   2 +-
hw/block/fdc.c                |   2 +-
hw/display/qxl.c              |   4 +-
hw/display/vga.c              |   2 +-
hw/display/virtio-gpu.c       |   2 +-
hw/display/vmware_vga.c       |   2 +-
hw/i386/vmmouse.c             |   2 +-
hw/ide/ahci.c                 |   2 +-
hw/intc/openpic.c             |   2 +-
hw/intc/spapr_xive.c          |   2 +-
hw/intc/xics.c                |   2 +-
hw/intc/xive.c                |   2 +-
hw/nvram/eeprom93xx.c         |   2 +-
hw/pci/pci.c                  |   2 +-
hw/pci/pcie_aer.c             |   2 +-
hw/ppc/spapr_iommu.c          |   2 +-
hw/ppc/spapr_pci.c            |   7 +-
hw/ppc/spapr_vio.c            |   4 +-
hw/s390x/css.c                |  15 +-
hw/usb/hcd-uhci.c             |   2 +-
include/migration/cpr.h       |   2 +-
include/migration/vmstate.h   |  73 ++--
migration/cpr.c               |  22 +-
migration/savevm.c            | 108 +++---
migration/trace-events        |  30 +-
migration/vmstate-types.c     | 642 +++++++++++++++++-----------------
migration/vmstate.c           | 354 +++++++++++--------
target/arm/machine.c          |   4 +-
target/ppc/machine.c          |   6 +-
29 files changed, 691 insertions(+), 612 deletions(-)
[PATCH v3 00/18] migration: more bool+errp APIs
Posted by Vladimir Sementsov-Ogievskiy 3 weeks, 1 day ago 
v3:
01,02: add r-bs by Fabiano and Peter
03: improve comment, add r-b by Peter
04: add r-bs by Fabiano and Peter
05: new, replacement for dropped "[PATCH v2 05/16] migration: vmstate_save/load_state(): stop tracing errors"
06: rebase on kept trace-points, keep r-b by Peter
07-09: add r-b by Peter
10: rebase on kept trace-points, keep r-b by Peter
11-12: add r-b by Peter
13: rebase ion kept traces and logic around trace_vmstate_load_field_error() already refactored, fix indent, drop r-b
14: add r-b by Peter
15: add r-b by Peter, use "else { if () {} }"
16-17: new
18: rebased on dropped err_hint, drop r-b

Vladimir Sementsov-Ogievskiy (18):
  migration: vmstate_save_state_v: fix double error_setg
  migration: make vmstate_save_state_v() static
  migration: make .post_save() a void function
  migration: vmstate_load_state(): add some newlines
  migration: vmstate_save/load_state(): refactor tracing errors
  migration: factor out vmstate_pre_save() from vmstate_save_state()
  migration: factor out vmstate_save_field() from vmstate_save_state()
  migration: factor out vmstate_pre_load() from vmstate_load_state()
  migration: factor out vmstate_load_field() from vmstate_load_state()
  migration: factor out vmstate_post_load() from vmstate_load_state()
  migration: convert vmstate_subsection_save/load functions to bool
  migration: VMStateInfo: introduce new handlers with errp
  migration: introduce vmstate_load_vmsd() and vmstate_save_vmsd()
  migration/cpr: move to new migration APIs
  migration/savevm: move to new migration APIs
  hw/s390x/css: drop use of .err_hint for vmstate
  migration: drop VMStateField.err_hint
  migration/vmstate-types: move to new migration APIs

 docs/devel/migration/main.rst |   2 +-
 hw/block/fdc.c                |   2 +-
 hw/display/qxl.c              |   4 +-
 hw/display/vga.c              |   2 +-
 hw/display/virtio-gpu.c       |   2 +-
 hw/display/vmware_vga.c       |   2 +-
 hw/i386/vmmouse.c             |   2 +-
 hw/ide/ahci.c                 |   2 +-
 hw/intc/openpic.c             |   2 +-
 hw/intc/spapr_xive.c          |   2 +-
 hw/intc/xics.c                |   2 +-
 hw/intc/xive.c                |   2 +-
 hw/nvram/eeprom93xx.c         |   2 +-
 hw/pci/pci.c                  |   2 +-
 hw/pci/pcie_aer.c             |   2 +-
 hw/ppc/spapr_iommu.c          |   2 +-
 hw/ppc/spapr_pci.c            |   7 +-
 hw/ppc/spapr_vio.c            |   4 +-
 hw/s390x/css.c                |  15 +-
 hw/usb/hcd-uhci.c             |   2 +-
 include/migration/cpr.h       |   2 +-
 include/migration/vmstate.h   |  73 ++--
 migration/cpr.c               |  22 +-
 migration/savevm.c            | 108 +++---
 migration/trace-events        |  30 +-
 migration/vmstate-types.c     | 642 +++++++++++++++++-----------------
 migration/vmstate.c           | 354 +++++++++++--------
 target/arm/machine.c          |   4 +-
 target/ppc/machine.c          |   6 +-
 29 files changed, 691 insertions(+), 612 deletions(-)

-- 
2.52.0
Re: [PATCH v3 00/18] migration: more bool+errp APIs
Posted by Fabiano Rosas 2 weeks, 6 days ago 
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> v3:
> 01,02: add r-bs by Fabiano and Peter
> 03: improve comment, add r-b by Peter
> 04: add r-bs by Fabiano and Peter
> 05: new, replacement for dropped "[PATCH v2 05/16] migration: vmstate_save/load_state(): stop tracing errors"
> 06: rebase on kept trace-points, keep r-b by Peter
> 07-09: add r-b by Peter
> 10: rebase on kept trace-points, keep r-b by Peter
> 11-12: add r-b by Peter
> 13: rebase ion kept traces and logic around trace_vmstate_load_field_error() already refactored, fix indent, drop r-b
> 14: add r-b by Peter
> 15: add r-b by Peter, use "else { if () {} }"
> 16-17: new
> 18: rebased on dropped err_hint, drop r-b
>
> Vladimir Sementsov-Ogievskiy (18):
>   migration: vmstate_save_state_v: fix double error_setg
>   migration: make vmstate_save_state_v() static
>   migration: make .post_save() a void function
>   migration: vmstate_load_state(): add some newlines
>   migration: vmstate_save/load_state(): refactor tracing errors
>   migration: factor out vmstate_pre_save() from vmstate_save_state()
>   migration: factor out vmstate_save_field() from vmstate_save_state()
>   migration: factor out vmstate_pre_load() from vmstate_load_state()
>   migration: factor out vmstate_load_field() from vmstate_load_state()
>   migration: factor out vmstate_post_load() from vmstate_load_state()
>   migration: convert vmstate_subsection_save/load functions to bool
>   migration: VMStateInfo: introduce new handlers with errp
>   migration: introduce vmstate_load_vmsd() and vmstate_save_vmsd()
>   migration/cpr: move to new migration APIs
>   migration/savevm: move to new migration APIs
>   hw/s390x/css: drop use of .err_hint for vmstate
>   migration: drop VMStateField.err_hint
>   migration/vmstate-types: move to new migration APIs
>
>  docs/devel/migration/main.rst |   2 +-
>  hw/block/fdc.c                |   2 +-
>  hw/display/qxl.c              |   4 +-
>  hw/display/vga.c              |   2 +-
>  hw/display/virtio-gpu.c       |   2 +-
>  hw/display/vmware_vga.c       |   2 +-
>  hw/i386/vmmouse.c             |   2 +-
>  hw/ide/ahci.c                 |   2 +-
>  hw/intc/openpic.c             |   2 +-
>  hw/intc/spapr_xive.c          |   2 +-
>  hw/intc/xics.c                |   2 +-
>  hw/intc/xive.c                |   2 +-
>  hw/nvram/eeprom93xx.c         |   2 +-
>  hw/pci/pci.c                  |   2 +-
>  hw/pci/pcie_aer.c             |   2 +-
>  hw/ppc/spapr_iommu.c          |   2 +-
>  hw/ppc/spapr_pci.c            |   7 +-
>  hw/ppc/spapr_vio.c            |   4 +-
>  hw/s390x/css.c                |  15 +-
>  hw/usb/hcd-uhci.c             |   2 +-
>  include/migration/cpr.h       |   2 +-
>  include/migration/vmstate.h   |  73 ++--
>  migration/cpr.c               |  22 +-
>  migration/savevm.c            | 108 +++---
>  migration/trace-events        |  30 +-
>  migration/vmstate-types.c     | 642 +++++++++++++++++-----------------
>  migration/vmstate.c           | 354 +++++++++++--------
>  target/arm/machine.c          |   4 +-
>  target/ppc/machine.c          |   6 +-
>  29 files changed, 691 insertions(+), 612 deletions(-)

Queued, thanks!
Re: [PATCH v3 00/18] migration: more bool+errp APIs
Posted by Vladimir Sementsov-Ogievskiy 2 days, 18 hours ago 
On 06.03.26 23:53, Fabiano Rosas wrote:
> Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> 
>> v3:
>> 01,02: add r-bs by Fabiano and Peter
>> 03: improve comment, add r-b by Peter
>> 04: add r-bs by Fabiano and Peter
>> 05: new, replacement for dropped "[PATCH v2 05/16] migration: vmstate_save/load_state(): stop tracing errors"
>> 06: rebase on kept trace-points, keep r-b by Peter
>> 07-09: add r-b by Peter
>> 10: rebase on kept trace-points, keep r-b by Peter
>> 11-12: add r-b by Peter
>> 13: rebase ion kept traces and logic around trace_vmstate_load_field_error() already refactored, fix indent, drop r-b
>> 14: add r-b by Peter
>> 15: add r-b by Peter, use "else { if () {} }"
>> 16-17: new
>> 18: rebased on dropped err_hint, drop r-b
>>
>> Vladimir Sementsov-Ogievskiy (18):
>>    migration: vmstate_save_state_v: fix double error_setg
>>    migration: make vmstate_save_state_v() static
>>    migration: make .post_save() a void function
>>    migration: vmstate_load_state(): add some newlines
>>    migration: vmstate_save/load_state(): refactor tracing errors
>>    migration: factor out vmstate_pre_save() from vmstate_save_state()
>>    migration: factor out vmstate_save_field() from vmstate_save_state()
>>    migration: factor out vmstate_pre_load() from vmstate_load_state()
>>    migration: factor out vmstate_load_field() from vmstate_load_state()
>>    migration: factor out vmstate_post_load() from vmstate_load_state()
>>    migration: convert vmstate_subsection_save/load functions to bool
>>    migration: VMStateInfo: introduce new handlers with errp
>>    migration: introduce vmstate_load_vmsd() and vmstate_save_vmsd()
>>    migration/cpr: move to new migration APIs
>>    migration/savevm: move to new migration APIs
>>    hw/s390x/css: drop use of .err_hint for vmstate
>>    migration: drop VMStateField.err_hint
>>    migration/vmstate-types: move to new migration APIs
>>
>>   docs/devel/migration/main.rst |   2 +-
>>   hw/block/fdc.c                |   2 +-
>>   hw/display/qxl.c              |   4 +-
>>   hw/display/vga.c              |   2 +-
>>   hw/display/virtio-gpu.c       |   2 +-
>>   hw/display/vmware_vga.c       |   2 +-
>>   hw/i386/vmmouse.c             |   2 +-
>>   hw/ide/ahci.c                 |   2 +-
>>   hw/intc/openpic.c             |   2 +-
>>   hw/intc/spapr_xive.c          |   2 +-
>>   hw/intc/xics.c                |   2 +-
>>   hw/intc/xive.c                |   2 +-
>>   hw/nvram/eeprom93xx.c         |   2 +-
>>   hw/pci/pci.c                  |   2 +-
>>   hw/pci/pcie_aer.c             |   2 +-
>>   hw/ppc/spapr_iommu.c          |   2 +-
>>   hw/ppc/spapr_pci.c            |   7 +-
>>   hw/ppc/spapr_vio.c            |   4 +-
>>   hw/s390x/css.c                |  15 +-
>>   hw/usb/hcd-uhci.c             |   2 +-
>>   include/migration/cpr.h       |   2 +-
>>   include/migration/vmstate.h   |  73 ++--
>>   migration/cpr.c               |  22 +-
>>   migration/savevm.c            | 108 +++---
>>   migration/trace-events        |  30 +-
>>   migration/vmstate-types.c     | 642 +++++++++++++++++-----------------
>>   migration/vmstate.c           | 354 +++++++++++--------
>>   target/arm/machine.c          |   4 +-
>>   target/ppc/machine.c          |   6 +-
>>   29 files changed, 691 insertions(+), 612 deletions(-)
> 
> Queued, thanks!


Hi! Aren't these patches lost?

-- 
Best regards,
Vladimir
Re: [PATCH v3 00/18] migration: more bool+errp APIs
Posted by Fabiano Rosas 2 days, 13 hours ago 
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> On 06.03.26 23:53, Fabiano Rosas wrote:
>> Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
>> 
>>> v3:
>>> 01,02: add r-bs by Fabiano and Peter
>>> 03: improve comment, add r-b by Peter
>>> 04: add r-bs by Fabiano and Peter
>>> 05: new, replacement for dropped "[PATCH v2 05/16] migration: vmstate_save/load_state(): stop tracing errors"
>>> 06: rebase on kept trace-points, keep r-b by Peter
>>> 07-09: add r-b by Peter
>>> 10: rebase on kept trace-points, keep r-b by Peter
>>> 11-12: add r-b by Peter
>>> 13: rebase ion kept traces and logic around trace_vmstate_load_field_error() already refactored, fix indent, drop r-b
>>> 14: add r-b by Peter
>>> 15: add r-b by Peter, use "else { if () {} }"
>>> 16-17: new
>>> 18: rebased on dropped err_hint, drop r-b
>>>
>>> Vladimir Sementsov-Ogievskiy (18):
>>>    migration: vmstate_save_state_v: fix double error_setg
>>>    migration: make vmstate_save_state_v() static
>>>    migration: make .post_save() a void function
>>>    migration: vmstate_load_state(): add some newlines
>>>    migration: vmstate_save/load_state(): refactor tracing errors
>>>    migration: factor out vmstate_pre_save() from vmstate_save_state()
>>>    migration: factor out vmstate_save_field() from vmstate_save_state()
>>>    migration: factor out vmstate_pre_load() from vmstate_load_state()
>>>    migration: factor out vmstate_load_field() from vmstate_load_state()
>>>    migration: factor out vmstate_post_load() from vmstate_load_state()
>>>    migration: convert vmstate_subsection_save/load functions to bool
>>>    migration: VMStateInfo: introduce new handlers with errp
>>>    migration: introduce vmstate_load_vmsd() and vmstate_save_vmsd()
>>>    migration/cpr: move to new migration APIs
>>>    migration/savevm: move to new migration APIs
>>>    hw/s390x/css: drop use of .err_hint for vmstate
>>>    migration: drop VMStateField.err_hint
>>>    migration/vmstate-types: move to new migration APIs
>>>
>>>   docs/devel/migration/main.rst |   2 +-
>>>   hw/block/fdc.c                |   2 +-
>>>   hw/display/qxl.c              |   4 +-
>>>   hw/display/vga.c              |   2 +-
>>>   hw/display/virtio-gpu.c       |   2 +-
>>>   hw/display/vmware_vga.c       |   2 +-
>>>   hw/i386/vmmouse.c             |   2 +-
>>>   hw/ide/ahci.c                 |   2 +-
>>>   hw/intc/openpic.c             |   2 +-
>>>   hw/intc/spapr_xive.c          |   2 +-
>>>   hw/intc/xics.c                |   2 +-
>>>   hw/intc/xive.c                |   2 +-
>>>   hw/nvram/eeprom93xx.c         |   2 +-
>>>   hw/pci/pci.c                  |   2 +-
>>>   hw/pci/pcie_aer.c             |   2 +-
>>>   hw/ppc/spapr_iommu.c          |   2 +-
>>>   hw/ppc/spapr_pci.c            |   7 +-
>>>   hw/ppc/spapr_vio.c            |   4 +-
>>>   hw/s390x/css.c                |  15 +-
>>>   hw/usb/hcd-uhci.c             |   2 +-
>>>   include/migration/cpr.h       |   2 +-
>>>   include/migration/vmstate.h   |  73 ++--
>>>   migration/cpr.c               |  22 +-
>>>   migration/savevm.c            | 108 +++---
>>>   migration/trace-events        |  30 +-
>>>   migration/vmstate-types.c     | 642 +++++++++++++++++-----------------
>>>   migration/vmstate.c           | 354 +++++++++++--------
>>>   target/arm/machine.c          |   4 +-
>>>   target/ppc/machine.c          |   6 +-
>>>   29 files changed, 691 insertions(+), 612 deletions(-)
>> 
>> Queued, thanks!
>
>
> Hi! Aren't these patches lost?

Hi, no, they are in my staging branch, I'll post when the devel window
reopens. Unfortunately the rust build issue took up the amount of time I
had slotted for this and I had to put it on hold to work on other
things.

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.