1. Patchew
  2. QEMU
  3. View series

[PATCH v2] bsd-user: Switch to SPDX-License-Expression

Warner Losh posted 1 patch 1 month, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260304-bsd-user-copyright-v2-1-173525ffa614@bsdimp.com
Maintainers: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>
There is a newer version of this series
bsd-user/aarch64/signal.c               | 15 ++-------------
bsd-user/aarch64/target_arch.h          | 16 ++--------------
bsd-user/aarch64/target_arch_cpu.c      | 15 ++-------------
bsd-user/aarch64/target_arch_cpu.h      | 18 +++---------------
bsd-user/aarch64/target_arch_elf.h      | 14 +-------------
bsd-user/aarch64/target_arch_reg.h      | 19 +++----------------
bsd-user/aarch64/target_arch_signal.h   | 16 ++--------------
bsd-user/aarch64/target_arch_sigtramp.h | 16 ++--------------
bsd-user/aarch64/target_arch_sysarch.h  | 16 ++--------------
bsd-user/aarch64/target_arch_thread.h   | 16 ++--------------
bsd-user/aarch64/target_arch_vmparam.h  | 16 ++--------------
bsd-user/aarch64/target_syscall.h       | 16 ++--------------
bsd-user/arm/signal.c                   | 18 +++---------------
bsd-user/arm/target_arch.h              | 16 ++--------------
bsd-user/arm/target_arch_cpu.c          | 18 +++---------------
bsd-user/arm/target_arch_cpu.h          | 18 +++---------------
bsd-user/arm/target_arch_elf.h          | 18 +++---------------
bsd-user/arm/target_arch_reg.h          | 18 +++---------------
bsd-user/arm/target_arch_signal.h       | 18 +++---------------
bsd-user/arm/target_arch_sigtramp.h     | 18 +++---------------
bsd-user/arm/target_arch_sysarch.h      | 18 +++---------------
bsd-user/arm/target_arch_thread.h       | 18 +++---------------
bsd-user/arm/target_arch_vmparam.h      | 18 +++---------------
bsd-user/arm/target_syscall.h           | 18 +++---------------
bsd-user/bsd-file.h                     | 18 +++---------------
bsd-user/bsd-mem.c                      | 17 +++--------------
bsd-user/bsd-mem.h                      | 17 +++--------------
bsd-user/bsd-proc.c                     | 17 +++--------------
bsd-user/bsd-proc.h                     | 17 +++--------------
bsd-user/elfload.c                      | 17 +++--------------
bsd-user/freebsd/os-misc.h              | 18 +++---------------
bsd-user/freebsd/os-proc.c              | 17 +++--------------
bsd-user/freebsd/os-proc.h              | 18 +++---------------
bsd-user/freebsd/os-stat.c              | 17 +++--------------
bsd-user/freebsd/os-stat.h              | 18 +++---------------
bsd-user/freebsd/os-strace.h            | 19 +++----------------
bsd-user/freebsd/target_os_elf.h        | 18 +++---------------
bsd-user/freebsd/target_os_siginfo.h    | 18 +++---------------
bsd-user/freebsd/target_os_stack.h      | 18 +++---------------
bsd-user/freebsd/target_os_thread.h     | 18 +++---------------
bsd-user/freebsd/target_os_user.h       | 18 +++---------------
bsd-user/freebsd/target_os_vmparam.h    | 18 +++---------------
bsd-user/i386/signal.c                  | 17 +++--------------
bsd-user/i386/target_arch.h             | 16 ++--------------
bsd-user/i386/target_arch_cpu.c         | 17 +++--------------
bsd-user/i386/target_arch_cpu.h         | 17 +++--------------
bsd-user/i386/target_arch_elf.h         | 18 +++---------------
bsd-user/i386/target_arch_reg.h         | 19 +++----------------
bsd-user/i386/target_arch_signal.h      | 16 +++-------------
bsd-user/i386/target_arch_sigtramp.h    | 16 ++--------------
bsd-user/i386/target_arch_sysarch.h     | 18 +++---------------
bsd-user/i386/target_arch_thread.h      | 18 +++---------------
bsd-user/i386/target_arch_vmparam.h     | 18 +++---------------
bsd-user/i386/target_syscall.h          | 16 +++-------------
bsd-user/qemu-bsd.h                     | 18 +++---------------
bsd-user/qemu.h                         | 15 +++------------
bsd-user/strace.c                       | 16 +++-------------
bsd-user/syscall_defs.h                 | 18 +++---------------
bsd-user/x86_64/signal.c                | 16 +++-------------
bsd-user/x86_64/target_arch.h           | 16 ++--------------
bsd-user/x86_64/target_arch_cpu.c       | 17 +++--------------
bsd-user/x86_64/target_arch_cpu.h       | 17 +++--------------
bsd-user/x86_64/target_arch_elf.h       | 18 +++---------------
bsd-user/x86_64/target_arch_reg.h       | 19 +++----------------
bsd-user/x86_64/target_arch_signal.h    | 17 +++--------------
bsd-user/x86_64/target_arch_sigtramp.h  | 17 ++---------------
bsd-user/x86_64/target_arch_sysarch.h   | 17 +++--------------
bsd-user/x86_64/target_arch_thread.h    | 18 +++---------------
bsd-user/x86_64/target_arch_vmparam.h   | 18 +++---------------
bsd-user/x86_64/target_syscall.h        | 16 +++-------------
70 files changed, 194 insertions(+), 1010 deletions(-)
Re: [PATCH v2] bsd-user: Switch to SPDX-License-Expression
Posted by Daniel P. Berrangé 1 month ago 
On Wed, Mar 04, 2026 at 09:05:33AM -0700, Warner Losh wrote:
> Two minor changes to the copyright and license marking for these files:
> (1) Stacey D Son is used instead of variations of his name.
> (2) The GPL boilerplate is replaced by SPDX markings. No change to the
> terms of the license are intended, and this matches current QEMU practice.
> 
> There's no changes to the license or additional claims to any IP that
> others may hold in these files. All the S-o-bs in this commit have given
> me permission to do this to the extent they may hold rights. git blame
> over multiple repos and branches suggests that only minimal other
> material is present (much of it likely not subject to copyright
> protection). The project's long and complex history as well as tooling
> limitations make it hard to be 100% sure. Any omissions are
> unintentional and I will correct them as they come to light.
> 
> Signed-off-by: Stacey Son <sson@FreeBSD.org>
> Signed-off-by: Sean Bruno <sbruno@FreeBSD.org>
> Signed-off-by: Mikaël Urankar <mikael.urankar@gmail.com>
> Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
> Signed-off-by: Guy Yur <guyyur@gmail.com>
> Signed-off-by: Alexander Kabaev <kan@FreeBSD.org>
> Signed-off-by: Michal Meloun <mmel@FreeBSD.org>
> Signed-off-by: Ed Schouten <ed@nuxi.nl>
> Signed-off-by: Warner Losh <imp@bsdimp.com>

Thanks, I used that set of emails to filter out commits 

Out of the remaining commits/files with other authors, most were a
case of  trivial function renames, code deletion, or trivial syntax
fixes to deal with external cleanups which can be exluded.

The only files where I saw any non-trivial code from other contributors
are
 
bsd-user/bsd-mem.h: 8
bsd-user/elfload.c: 36
bsd-user/freebsd/os-misc.h: 1
bsd-user/freebsd/os-proc.c: 3
bsd-user/freebsd/os-proc.h: 3
bsd-user/qemu.h: 58
bsd-user/strace.c: 7

There are way too many historic authors for elfload.c, qemu.h and
strace.c to make it worth chasing those down, so I'd suggest just
dropping those three files from the commit.

For bsd-mem.h, and freebsd/os* Karim Taha <kariem.taha2.7@gmail.com>
is the only notable omission I saw. Up to you whether to check with
them or just drop those files from the cleanup.


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|
Re: [PATCH v2] bsd-user: Switch to SPDX-License-Expression
Posted by Warner Losh 1 month ago 
On Fri, Mar 6, 2026 at 7:12 AM Daniel P. Berrangé <berrange@redhat.com>
wrote:

> On Wed, Mar 04, 2026 at 09:05:33AM -0700, Warner Losh wrote:
> > Two minor changes to the copyright and license marking for these files:
> > (1) Stacey D Son is used instead of variations of his name.
> > (2) The GPL boilerplate is replaced by SPDX markings. No change to the
> > terms of the license are intended, and this matches current QEMU
> practice.
> >
> > There's no changes to the license or additional claims to any IP that
> > others may hold in these files. All the S-o-bs in this commit have given
> > me permission to do this to the extent they may hold rights. git blame
> > over multiple repos and branches suggests that only minimal other
> > material is present (much of it likely not subject to copyright
> > protection). The project's long and complex history as well as tooling
> > limitations make it hard to be 100% sure. Any omissions are
> > unintentional and I will correct them as they come to light.
> >
> > Signed-off-by: Stacey Son <sson@FreeBSD.org>
> > Signed-off-by: Sean Bruno <sbruno@FreeBSD.org>
> > Signed-off-by: Mikaël Urankar <mikael.urankar@gmail.com>
> > Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
> > Signed-off-by: Guy Yur <guyyur@gmail.com>
> > Signed-off-by: Alexander Kabaev <kan@FreeBSD.org>
> > Signed-off-by: Michal Meloun <mmel@FreeBSD.org>
> > Signed-off-by: Ed Schouten <ed@nuxi.nl>
> > Signed-off-by: Warner Losh <imp@bsdimp.com>
>
> Thanks, I used that set of emails to filter out commits
>
> Out of the remaining commits/files with other authors, most were a
> case of  trivial function renames, code deletion, or trivial syntax
> fixes to deal with external cleanups which can be exluded.
>
> The only files where I saw any non-trivial code from other contributors
> are
>
> bsd-user/bsd-mem.h: 8
> bsd-user/elfload.c: 36
> bsd-user/freebsd/os-misc.h: 1
> bsd-user/freebsd/os-proc.c: 3
> bsd-user/freebsd/os-proc.h: 3
> bsd-user/qemu.h: 58
> bsd-user/strace.c: 7
>
> There are way too many historic authors for elfload.c, qemu.h and
> strace.c to make it worth chasing those down, so I'd suggest just
> dropping those three files from the commit.
>

I'll drop those. The qemu.h issue is more Blue Swirl shows in git blame,
and those files are more from linux-user, which git blame is useless to
chase down.


> For bsd-mem.h, and freebsd/os* Karim Taha <kariem.taha2.7@gmail.com>
> is the only notable omission I saw. Up to you whether to check with
> them or just drop those files from the cleanup.
>

Karim's case is interesting. He was a GSoC student that took the work
from bsd-user blitz branch. In the blitz branch, the blame shows style
changes and a few other tweaks from the upstreaming. He also contributed
some things that aren't in these files. He shows up as more than that in
in qemu's upstream repo because of the code copying. That's why I
hadn't contacted him.

I'll chase those down and also see if I can make contact with him. I had
trouble reaching him after he entered the military after GSoC finished, but
haven't tried in years.

Warner
Re: [PATCH v2] bsd-user: Switch to SPDX-License-Expression
Posted by Warner Losh 1 month ago 
On Fri, Mar 6, 2026 at 9:28 AM Warner Losh <imp@bsdimp.com> wrote:

>
>
> On Fri, Mar 6, 2026 at 7:12 AM Daniel P. Berrangé <berrange@redhat.com>
> wrote:
>
>> On Wed, Mar 04, 2026 at 09:05:33AM -0700, Warner Losh wrote:
>> > Two minor changes to the copyright and license marking for these files:
>> > (1) Stacey D Son is used instead of variations of his name.
>> > (2) The GPL boilerplate is replaced by SPDX markings. No change to the
>> > terms of the license are intended, and this matches current QEMU
>> practice.
>> >
>> > There's no changes to the license or additional claims to any IP that
>> > others may hold in these files. All the S-o-bs in this commit have given
>> > me permission to do this to the extent they may hold rights. git blame
>> > over multiple repos and branches suggests that only minimal other
>> > material is present (much of it likely not subject to copyright
>> > protection). The project's long and complex history as well as tooling
>> > limitations make it hard to be 100% sure. Any omissions are
>> > unintentional and I will correct them as they come to light.
>> >
>> > Signed-off-by: Stacey Son <sson@FreeBSD.org>
>> > Signed-off-by: Sean Bruno <sbruno@FreeBSD.org>
>> > Signed-off-by: Mikaël Urankar <mikael.urankar@gmail.com>
>> > Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
>> > Signed-off-by: Guy Yur <guyyur@gmail.com>
>> > Signed-off-by: Alexander Kabaev <kan@FreeBSD.org>
>> > Signed-off-by: Michal Meloun <mmel@FreeBSD.org>
>> > Signed-off-by: Ed Schouten <ed@nuxi.nl>
>> > Signed-off-by: Warner Losh <imp@bsdimp.com>
>>
>> Thanks, I used that set of emails to filter out commits
>>
>> Out of the remaining commits/files with other authors, most were a
>> case of  trivial function renames, code deletion, or trivial syntax
>> fixes to deal with external cleanups which can be exluded.
>>
>> The only files where I saw any non-trivial code from other contributors
>> are
>>
>> bsd-user/bsd-mem.h: 8
>> bsd-user/elfload.c: 36
>> bsd-user/freebsd/os-misc.h: 1
>> bsd-user/freebsd/os-proc.c: 3
>> bsd-user/freebsd/os-proc.h: 3
>> bsd-user/qemu.h: 58
>> bsd-user/strace.c: 7
>>
>> There are way too many historic authors for elfload.c, qemu.h and
>> strace.c to make it worth chasing those down, so I'd suggest just
>> dropping those three files from the commit.
>>
>
> I'll drop those. The qemu.h issue is more Blue Swirl shows in git blame,
> and those files are more from linux-user, which git blame is useless to
> chase down.
>
>
>> For bsd-mem.h, and freebsd/os* Karim Taha <kariem.taha2.7@gmail.com>
>> is the only notable omission I saw. Up to you whether to check with
>> them or just drop those files from the cleanup.
>>
>
> Karim's case is interesting. He was a GSoC student that took the work
> from bsd-user blitz branch. In the blitz branch, the blame shows style
> changes and a few other tweaks from the upstreaming. He also contributed
> some things that aren't in these files. He shows up as more than that in
> in qemu's upstream repo because of the code copying. That's why I
> hadn't contacted him.
>
> I'll chase those down and also see if I can make contact with him. I had
> trouble reaching him after he entered the military after GSoC finished, but
> haven't tried in years.
>

Ah! He's back online and has given me permission. I'll update with what we
discussed.

Warner

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.