1. Patchew
  2. QEMU
  3. View series

[PULL 00/27] Misc patches queue

Daniel P. Berrangé posted 27 patches 1 month, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260303150604.2402872-1-berrange@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Christian Schoenebeck <qemu_oss@crudebyte.com>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Daniel P. Berrangé" <berrange@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Markus Armbruster <armbru@redhat.com>, "Dr. David Alan Gilbert" <dave@treblig.org>, Manos Pitsidianakis <manos.pitsidianakis@linaro.org>, Stefan Weil <sw@weilnetz.de>
There is a newer version of this series
audio/jackaudio.c                    |  28 +++++--
docs/about/deprecated.rst            |   7 ++
docs/system/cpu-models-x86.rst.inc   |  16 ++--
include/io/task.h                    |  29 +++++--
include/monitor/monitor.h            |   3 -
include/qemu/compiler.h              |   8 ++
include/qemu/log-for-trace.h         |  17 +++-
include/qemu/log.h                   |  39 ++++++++++
include/qemu/thread.h                |   3 +-
include/ui/console.h                 |   2 +-
include/ui/qemu-spice-module.h       |   3 +-
io/channel-tls.c                     |  60 +++++++++-----
io/channel-websock.c                 |  46 ++++++++---
io/task.c                            |   8 +-
meson.build                          |  21 +++++
monitor/monitor.c                    |  51 +++---------
qemu-options.hx                      | 112 +++++++++++++--------------
rust/util/src/log.rs                 |   6 ++
scripts/checkpatch.pl                |  11 +--
stubs/error-printf.c                 |  23 ------
stubs/meson.build                    |   1 -
stubs/monitor-core.c                 |  19 ++++-
system/vl.c                          |  12 +--
tests/functional/generic/test_vnc.py |   4 +-
tests/unit/test-io-task.c            |  26 +++++++
tests/unit/test-util-sockets.c       |   1 +
ui/spice-core.c                      |  25 ++++--
ui/spice-module.c                    |   7 +-
ui/ui-qmp-cmds.c                     |  19 ++---
ui/vnc-stubs.c                       |   6 +-
ui/vnc.c                             |  16 ++--
util/error-report.c                  |  92 +++++++++++++++++-----
util/log.c                           |  50 +++++++-----
util/oslib-posix.c                   |   2 +-
util/qemu-thread-posix.c             |  89 +++++++++++++++------
util/qemu-thread-win32.c             |  87 ++++++++++++++-------
36 files changed, 628 insertions(+), 321 deletions(-)
delete mode 100644 stubs/error-printf.c
[PULL 00/27] Misc patches queue
Posted by Daniel P. Berrangé 1 month, 1 week ago 
The following changes since commit 3fb456e9a0e9eef6a71d9b49bfff596a0f0046e9:

  Merge tag 'pull-request-2026-03-02' of https://gitlab.com/thuth/qemu into staging (2026-03-02 14:01:46 +0000)

are available in the Git repository at:

  https://gitlab.com/berrange/qemu tags/next-pr-pull-request

for you to fetch changes up to 192f59773a6a8fd1e0d3c1d9c9c3f5f59a62c087:

  util/oslib-posix: increase memprealloc thread count to 32 (2026-03-03 15:01:21 +0000)

----------------------------------------------------------------
* Increase pre-alloc max thread count to 32
* Fix checkpatch warning for new/removed files with --terse
* Detect more GPL boilerplate in checkpatch
* Fix lean of data in TLS/websock GSource cancellation
* Tweak CPU docs for DiamondRapids
* Unconditionally enable thread naming
* Fix race setting thread naming on Win32
* Add API docs for logging APIs
* Fix interleaved error/trace output
* Fix missing error prefixes with warn_report
* Add detailed error reporting for VNC passworrd changes
* Refactoring of error_vprintf & related funcs

----------------------------------------------------------------

Daniel P. Berrangé (25):
  scripts: detect another GPL license boilerplate variant
  io: separate freeing of tasks from marking them as complete
  io: fix cleanup for TLS I/O source data on cancellation
  io: fix cleanup for websock I/O source data on cancellation
  docs: simplify DiamondRapids CPU docs
  qemu-options: remove extraneous [] around arg values
  include: define constant for early constructor priority
  monitor: initialize global data from a constructor
  system: unconditionally enable thread naming
  util: fix race setting thread name on Win32
  util: expose qemu_thread_set_name
  audio: make jackaudio use qemu_thread_set_name
  util: set the name for the 'main' thread on Windows
  util: add API to fetch the current thread name
  util: introduce some API docs for logging APIs
  util: avoid repeated prefix on incremental qemu_log calls
  util/log: add missing error reporting in qemu_log_trylock_with_err
  ui: add proper error reporting for password changes
  ui: remove redundant use of error_printf_unless_qmp()
  monitor: remove redundant error_[v]printf_unless_qmp
  monitor: refactor error_vprintf()
  monitor: move error_vprintf back to error-report.c
  util: fix interleaving of error & trace output
  util: don't skip error prefixes when QMP is active
  util: fix interleaving of error prefixes

Jon Kohler (1):
  util/oslib-posix: increase memprealloc thread count to 32

Markus Armbruster (1):
  scripts/checkpatch: Fix MAINTAINERS update warning with --terse

 audio/jackaudio.c                    |  28 +++++--
 docs/about/deprecated.rst            |   7 ++
 docs/system/cpu-models-x86.rst.inc   |  16 ++--
 include/io/task.h                    |  29 +++++--
 include/monitor/monitor.h            |   3 -
 include/qemu/compiler.h              |   8 ++
 include/qemu/log-for-trace.h         |  17 +++-
 include/qemu/log.h                   |  39 ++++++++++
 include/qemu/thread.h                |   3 +-
 include/ui/console.h                 |   2 +-
 include/ui/qemu-spice-module.h       |   3 +-
 io/channel-tls.c                     |  60 +++++++++-----
 io/channel-websock.c                 |  46 ++++++++---
 io/task.c                            |   8 +-
 meson.build                          |  21 +++++
 monitor/monitor.c                    |  51 +++---------
 qemu-options.hx                      | 112 +++++++++++++--------------
 rust/util/src/log.rs                 |   6 ++
 scripts/checkpatch.pl                |  11 +--
 stubs/error-printf.c                 |  23 ------
 stubs/meson.build                    |   1 -
 stubs/monitor-core.c                 |  19 ++++-
 system/vl.c                          |  12 +--
 tests/functional/generic/test_vnc.py |   4 +-
 tests/unit/test-io-task.c            |  26 +++++++
 tests/unit/test-util-sockets.c       |   1 +
 ui/spice-core.c                      |  25 ++++--
 ui/spice-module.c                    |   7 +-
 ui/ui-qmp-cmds.c                     |  19 ++---
 ui/vnc-stubs.c                       |   6 +-
 ui/vnc.c                             |  16 ++--
 util/error-report.c                  |  92 +++++++++++++++++-----
 util/log.c                           |  50 +++++++-----
 util/oslib-posix.c                   |   2 +-
 util/qemu-thread-posix.c             |  89 +++++++++++++++------
 util/qemu-thread-win32.c             |  87 ++++++++++++++-------
 36 files changed, 628 insertions(+), 321 deletions(-)
 delete mode 100644 stubs/error-printf.c

-- 
2.53.0
Re: [PULL 00/27] Misc patches queue
Posted by Peter Maydell 1 month, 1 week ago 
On Tue, 3 Mar 2026 at 15:07, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> The following changes since commit 3fb456e9a0e9eef6a71d9b49bfff596a0f0046e9:
>
>   Merge tag 'pull-request-2026-03-02' of https://gitlab.com/thuth/qemu into staging (2026-03-02 14:01:46 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/berrange/qemu tags/next-pr-pull-request
>
> for you to fetch changes up to 192f59773a6a8fd1e0d3c1d9c9c3f5f59a62c087:
>
>   util/oslib-posix: increase memprealloc thread count to 32 (2026-03-03 15:01:21 +0000)
>
> ----------------------------------------------------------------
> * Increase pre-alloc max thread count to 32
> * Fix checkpatch warning for new/removed files with --terse
> * Detect more GPL boilerplate in checkpatch
> * Fix lean of data in TLS/websock GSource cancellation
> * Tweak CPU docs for DiamondRapids
> * Unconditionally enable thread naming
> * Fix race setting thread naming on Win32
> * Add API docs for logging APIs
> * Fix interleaved error/trace output
> * Fix missing error prefixes with warn_report
> * Add detailed error reporting for VNC passworrd changes
> * Refactoring of error_vprintf & related funcs
>
> ----------------------------------------------------------------

Something in this consistently causes the s390x runner
to fail the test-migration test:

https://gitlab.com/qemu-project/qemu/-/jobs/13367184083
https://gitlab.com/qemu-project/qemu/-/jobs/13366572115
https://gitlab.com/qemu-project/qemu/-/jobs/13339069533
https://gitlab.com/qemu-project/qemu/-/jobs/13336989367

This was a CI run together with the loongarch pullreq, but
that has just passed this job when run in CI on its own:
 https://gitlab.com/qemu-project/qemu/-/jobs/13367800326
so it seems like this pullreq is the one causing the s390x
failures.

thanks
-- PMM
Re: [PULL 00/27] Misc patches queue
Posted by Daniel P. Berrangé 1 month, 1 week ago 
On Thu, Mar 05, 2026 at 02:47:12PM +0000, Peter Maydell wrote:
> On Tue, 3 Mar 2026 at 15:07, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > The following changes since commit 3fb456e9a0e9eef6a71d9b49bfff596a0f0046e9:
> >
> >   Merge tag 'pull-request-2026-03-02' of https://gitlab.com/thuth/qemu into staging (2026-03-02 14:01:46 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/berrange/qemu tags/next-pr-pull-request
> >
> > for you to fetch changes up to 192f59773a6a8fd1e0d3c1d9c9c3f5f59a62c087:
> >
> >   util/oslib-posix: increase memprealloc thread count to 32 (2026-03-03 15:01:21 +0000)
> >
> > ----------------------------------------------------------------
> > * Increase pre-alloc max thread count to 32
> > * Fix checkpatch warning for new/removed files with --terse
> > * Detect more GPL boilerplate in checkpatch
> > * Fix lean of data in TLS/websock GSource cancellation
> > * Tweak CPU docs for DiamondRapids
> > * Unconditionally enable thread naming
> > * Fix race setting thread naming on Win32
> > * Add API docs for logging APIs
> > * Fix interleaved error/trace output
> > * Fix missing error prefixes with warn_report
> > * Add detailed error reporting for VNC passworrd changes
> > * Refactoring of error_vprintf & related funcs
> >
> > ----------------------------------------------------------------
> 
> Something in this consistently causes the s390x runner
> to fail the test-migration test:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/13367184083
> https://gitlab.com/qemu-project/qemu/-/jobs/13366572115
> https://gitlab.com/qemu-project/qemu/-/jobs/13339069533
> https://gitlab.com/qemu-project/qemu/-/jobs/13336989367
> 
> This was a CI run together with the loongarch pullreq, but
> that has just passed this job when run in CI on its own:
>  https://gitlab.com/qemu-project/qemu/-/jobs/13367800326
> so it seems like this pullreq is the one causing the s390x
> failures.

Yep, the migration-test seems to be failing in a TLS related test
case, which certainly points the finger at the early TLS patch
in this series.


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|
Re: [PULL 00/27] Misc patches queue
Posted by Daniel P. Berrangé 1 month, 1 week ago 
On Thu, Mar 05, 2026 at 03:15:39PM +0000, Daniel P. Berrangé wrote:
> On Thu, Mar 05, 2026 at 02:47:12PM +0000, Peter Maydell wrote:
> > On Tue, 3 Mar 2026 at 15:07, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > >
> > > The following changes since commit 3fb456e9a0e9eef6a71d9b49bfff596a0f0046e9:
> > >
> > >   Merge tag 'pull-request-2026-03-02' of https://gitlab.com/thuth/qemu into staging (2026-03-02 14:01:46 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.com/berrange/qemu tags/next-pr-pull-request
> > >
> > > for you to fetch changes up to 192f59773a6a8fd1e0d3c1d9c9c3f5f59a62c087:
> > >
> > >   util/oslib-posix: increase memprealloc thread count to 32 (2026-03-03 15:01:21 +0000)
> > >
> > > ----------------------------------------------------------------
> > > * Increase pre-alloc max thread count to 32
> > > * Fix checkpatch warning for new/removed files with --terse
> > > * Detect more GPL boilerplate in checkpatch
> > > * Fix lean of data in TLS/websock GSource cancellation
> > > * Tweak CPU docs for DiamondRapids
> > > * Unconditionally enable thread naming
> > > * Fix race setting thread naming on Win32
> > > * Add API docs for logging APIs
> > > * Fix interleaved error/trace output
> > > * Fix missing error prefixes with warn_report
> > > * Add detailed error reporting for VNC passworrd changes
> > > * Refactoring of error_vprintf & related funcs
> > >
> > > ----------------------------------------------------------------
> > 
> > Something in this consistently causes the s390x runner
> > to fail the test-migration test:
> > 
> > https://gitlab.com/qemu-project/qemu/-/jobs/13367184083
> > https://gitlab.com/qemu-project/qemu/-/jobs/13366572115
> > https://gitlab.com/qemu-project/qemu/-/jobs/13339069533
> > https://gitlab.com/qemu-project/qemu/-/jobs/13336989367
> > 
> > This was a CI run together with the loongarch pullreq, but
> > that has just passed this job when run in CI on its own:
> >  https://gitlab.com/qemu-project/qemu/-/jobs/13367800326
> > so it seems like this pullreq is the one causing the s390x
> > failures.
> 
> Yep, the migration-test seems to be failing in a TLS related test
> case, which certainly points the finger at the early TLS patch
> in this series.

There was a failure to unref an object which caused the hang. I've
sent a v2 pull request with this fix.


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.