[PATCH v2 4/7] target/arm/kvm: Tweak print_register_name() for arm64 system register

Eric Auger posted 7 patches 1 month, 1 week ago
Maintainers: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Pedro Barbuda <pbarbuda@microsoft.com>, Mohamed Mediouni <mohamed@unpredictable.fr>
There is a newer version of this series
[PATCH v2 4/7] target/arm/kvm: Tweak print_register_name() for arm64 system register
Posted by Eric Auger 1 month, 1 week ago
As opposed to other register types, arm64 system register decoding
is not introduced by any 'register' mention which can lead to
unfriendly user-facing traces.  Let's add "system register"

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 target/arm/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index cfb46015d48..43dab246097 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -921,7 +921,7 @@ char *kvm_print_register_name(uint64_t regidx)
         case KVM_REG_ARM_DEMUX:
             return g_strdup_printf("demuxed reg %"PRIx64, regidx);
         case KVM_REG_ARM64_SYSREG:
-            return g_strdup_printf("op0:%d op1:%d crn:%d crm:%d op2:%d",
+            return g_strdup_printf("system register op0:%d op1:%d crn:%d crm:%d op2:%d",
                                    CP_REG_ARM64_SYSREG_OP(regidx, OP0),
                                    CP_REG_ARM64_SYSREG_OP(regidx, OP1),
                                    CP_REG_ARM64_SYSREG_OP(regidx, CRN),
-- 
2.53.0
Re: [PATCH v2 4/7] target/arm/kvm: Tweak print_register_name() for arm64 system register
Posted by Peter Maydell 1 month, 1 week ago
On Tue, 3 Mar 2026 at 14:39, Eric Auger <eric.auger@redhat.com> wrote:
>
> As opposed to other register types, arm64 system register decoding
> is not introduced by any 'register' mention which can lead to
> unfriendly user-facing traces.  Let's add "system register"
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
>  target/arm/kvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/kvm.c b/target/arm/kvm.c
> index cfb46015d48..43dab246097 100644
> --- a/target/arm/kvm.c
> +++ b/target/arm/kvm.c
> @@ -921,7 +921,7 @@ char *kvm_print_register_name(uint64_t regidx)
>          case KVM_REG_ARM_DEMUX:
>              return g_strdup_printf("demuxed reg %"PRIx64, regidx);
>          case KVM_REG_ARM64_SYSREG:
> -            return g_strdup_printf("op0:%d op1:%d crn:%d crm:%d op2:%d",
> +            return g_strdup_printf("system register op0:%d op1:%d crn:%d crm:%d op2:%d",
>                                     CP_REG_ARM64_SYSREG_OP(regidx, OP0),
>                                     CP_REG_ARM64_SYSREG_OP(regidx, OP1),
>                                     CP_REG_ARM64_SYSREG_OP(regidx, CRN),
> --
> 2.53.0

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM