[PATCH v3 2/5] tests/functional/migration: Add migrate_vms

Fabiano Rosas posted 5 patches 1 month, 1 week ago
Maintainers: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Nicholas Piggin <npiggin@gmail.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>
There is a newer version of this series
[PATCH v3 2/5] tests/functional/migration: Add migrate_vms
Posted by Fabiano Rosas 1 month, 1 week ago
Add a migration helper to MigrationTest that uses the migrate-incoming
QMP commmand and takes the already instantiated VMs. The -incoming
'defer' command line option is preferred way instead of the -incoming
URI syntax that's currently used.

Suggested-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 tests/functional/migration.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/functional/migration.py b/tests/functional/migration.py
index 0aa873edba..3362e5c743 100644
--- a/tests/functional/migration.py
+++ b/tests/functional/migration.py
@@ -40,6 +40,11 @@ def assert_migration(self, src_vm, dst_vm):
         self.assertEqual(dst_vm.cmd('query-status')['status'], 'running')
         self.assertEqual(src_vm.cmd('query-status')['status'],'postmigrate')
 
+    def migrate_vms(self, dst_uri, src_uri, dst_vm, src_vm):
+        dst_vm.qmp('migrate-incoming', uri=dst_uri)
+        src_vm.qmp('migrate', uri=src_uri)
+        self.assert_migration(src_vm, dst_vm)
+
     def do_migrate(self, dest_uri, src_uri=None):
         dest_vm = self.get_vm('-incoming', dest_uri, name="dest-qemu")
         dest_vm.add_args('-nodefaults')
-- 
2.51.0
Re: [PATCH v3 2/5] tests/functional/migration: Add migrate_vms
Posted by Thomas Huth 1 month, 1 week ago
On 03/03/2026 14.43, Fabiano Rosas wrote:
> Add a migration helper to MigrationTest that uses the migrate-incoming
> QMP commmand and takes the already instantiated VMs. The -incoming
> 'defer' command line option is preferred way instead of the -incoming
> URI syntax that's currently used.
> 
> Suggested-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   tests/functional/migration.py | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tests/functional/migration.py b/tests/functional/migration.py
> index 0aa873edba..3362e5c743 100644
> --- a/tests/functional/migration.py
> +++ b/tests/functional/migration.py
> @@ -40,6 +40,11 @@ def assert_migration(self, src_vm, dst_vm):
>           self.assertEqual(dst_vm.cmd('query-status')['status'], 'running')
>           self.assertEqual(src_vm.cmd('query-status')['status'],'postmigrate')
>   
> +    def migrate_vms(self, dst_uri, src_uri, dst_vm, src_vm):
> +        dst_vm.qmp('migrate-incoming', uri=dst_uri)
> +        src_vm.qmp('migrate', uri=src_uri)
> +        self.assert_migration(src_vm, dst_vm)

Reviewed-by: Thomas Huth <thuth@redhat.com>