[v1] TYPE_SERIAL cleanup

[PATCH 00/12] TYPE_SERIAL cleanup

Bernhard Beschow posted 12 patches 1 month, 1 week ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260302220254.1166849-1-shentey@gmail.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Cédric Le Goater" <clg@kaod.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, Richard Henderson <richard.henderson@linaro.org>, Helge Deller <deller@gmx.de>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

There is a newer version of this series

include/hw/char/serial.h    |  4 +--
include/qemu/fifo8.h        | 10 +++---
hw/arm/aspeed_ast27x0-ssp.c |  7 +++--
hw/arm/aspeed_ast27x0-tsp.c |  7 +++--
hw/char/diva-gsp.c          | 22 ++++++-------
hw/char/serial-isa.c        | 19 +++++++-----
hw/char/serial-mm.c         | 10 +++---
hw/char/serial-pci-multi.c  | 22 ++++++-------
hw/char/serial-pci.c        | 13 ++++----
hw/char/serial.c            | 61 +++++++++++++++++++------------------
util/fifo8.c                | 10 +++---
hw/arm/Kconfig              |  2 +-
hw/char/trace-events        |  4 +--
13 files changed, 100 insertions(+), 91 deletions(-)

Expand all Fold all

[PATCH 00/12] TYPE_SERIAL cleanup

Posted by Bernhard Beschow 1 month, 1 week ago

This series consists of cosmetic changes around TYPE_SERIAL. The biggest change
is having it derive from TYPE_SYS_BUS_DEVICE which 1) eliminates usage of
qemu_{un,}register_reset() and 2) stops all its users from accessing private
data. The latter allows TYPE_SERIAL to be ported to Rust in the (near) future.

Testing done:
* Make check
* Boot mpc8544ds machine
* Boot q35 machine with Arch Linux and interact with it on the serial console

Bernhard Beschow (12):
  hw/arm/Kconfig: Fix serial selection for NPCM8XX
  hw/char/serial: Remove explicit cast from void pointer
  hw/char/serial: Prefer fifo8 methods over open-coding
  hw/char/serial: Reuse fifo8_num_used()
  hw/char/serial: Remove unhelpful comment
  hw/char/serial: Add constants for Line Control Register
  hw/char/serial: Remove redundant reset
  hw/char/serial: Avoid implicit conversion when tracing
  util/fifo8: Make all read-only methods const-correct
  hw/arm/aspeed_ast27x0-{ssp,tsp}: Do not access SerialMM internals
    directly
  hw/char: Have SerialState inherit from SysBusDevice
  hw/char/serial: Plug into reset framework

 include/hw/char/serial.h    |  4 +--
 include/qemu/fifo8.h        | 10 +++---
 hw/arm/aspeed_ast27x0-ssp.c |  7 +++--
 hw/arm/aspeed_ast27x0-tsp.c |  7 +++--
 hw/char/diva-gsp.c          | 22 ++++++-------
 hw/char/serial-isa.c        | 19 +++++++-----
 hw/char/serial-mm.c         | 10 +++---
 hw/char/serial-pci-multi.c  | 22 ++++++-------
 hw/char/serial-pci.c        | 13 ++++----
 hw/char/serial.c            | 61 +++++++++++++++++++------------------
 util/fifo8.c                | 10 +++---
 hw/arm/Kconfig              |  2 +-
 hw/char/trace-events        |  4 +--
 13 files changed, 100 insertions(+), 91 deletions(-)

-- 
2.53.0