Hexagon system emulation - Part 1/3

[PATCH v3 04/37] target/hexagon: Add missing A_CALL attr, hintjumpr to multi_cof

Posted by Brian Cain 2 days, 12 hours ago

From: Brian Cain <bcain@quicinc.com>

Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
---
 target/hexagon/hex_common.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
index c0e9f26aebe..63f83a8de2a 100755
--- a/target/hexagon/hex_common.py
+++ b/target/hexagon/hex_common.py
@@ -247,7 +247,11 @@ def need_next_PC(tag):
 
 
 def need_pkt_has_multi_cof(tag):
-    return "A_COF" in attribdict[tag]
+    if "A_JUMP" in attribdict[tag] or "A_CALL" in attribdict[tag]:
+        if tag == "J4_hintjumpr":
+            return False
+        return True
+    return False
 
 
 def need_pkt_need_commit(tag):
-- 
2.34.1

Re: [PATCH v3 04/37] target/hexagon: Add missing A_CALL attr, hintjumpr to multi_cof

Posted by Philippe Mathieu-Daudé 2 days, 11 hours ago

On 27/2/26 21:35, Brian Cain wrote:
> From: Brian Cain <bcain@quicinc.com>
> 
> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
> ---
>   target/hexagon/hex_common.py | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
> index c0e9f26aebe..63f83a8de2a 100755
> --- a/target/hexagon/hex_common.py
> +++ b/target/hexagon/hex_common.py
> @@ -247,7 +247,11 @@ def need_next_PC(tag):
>   
>   
>   def need_pkt_has_multi_cof(tag):
> -    return "A_COF" in attribdict[tag]
> +    if "A_JUMP" in attribdict[tag] or "A_CALL" in attribdict[tag]:
> +        if tag == "J4_hintjumpr":
> +            return False
> +        return True

Alternatively:

        if attribdict[tag] in ['A_JUMP', 'A_CALL']:
            return tag != "J4_hintjumpr"

> +    return False
>   
>   
>   def need_pkt_need_commit(tag):