The environment we do our coverity build in (amd64-fedora-container)
has just upgraded to Fedora 43.  This ships with libnfs version
16.2.0.  We can't currently build against that: in commit
e2d98f257138 we added a requirement to meson.build that libnfs be <
6.0.0, because of an upstream API change that we haven't yet updated
block/nfs.c to handle.

The result is that the coverity CI job currently fails in
configure:

Dependency libnfs found: NO. Found 16.2.0 but need: '<6.0.0' ;
matched: '>=1.9.3'
Run-time dependency libnfs found: NO
../meson.build:1150:11: ERROR: Dependency lookup for libnfs with
method 'pkgconfig' failed: Invalid version, need 'libnfs' ['<6.0.0']
found '16.2.0'.

Fix the coverity builds by dropping --enable-libnfs. This means we
will no longer have coverage of block/nfs.c until/unless we do
that update to handle the new libnfs API.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 scripts/coverity-scan/run-coverity-scan | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coverity-scan/run-coverity-scan b/scripts/coverity-scan/run-coverity-scan
index 43cf770f5e..9b89a3303f 100755
--- a/scripts/coverity-scan/run-coverity-scan
+++ b/scripts/coverity-scan/run-coverity-scan
@@ -424,7 +424,7 @@ echo "Configuring..."
     --enable-linux-aio --enable-attr \
     --enable-cap-ng --enable-trace-backends=log --enable-spice --enable-rbd \
     --enable-libusb --enable-usb-redir \
-    --enable-libiscsi --enable-libnfs --enable-seccomp \
+    --enable-libiscsi --enable-seccomp \
     --enable-tpm --enable-libssh --enable-lzo --enable-snappy --enable-bzip2 \
     --enable-numa --enable-rdma --enable-smartcard --enable-virglrenderer \
     --enable-mpath --enable-glusterfs \
-- 
2.43.0

On 26/02/2026 12.10, Peter Maydell wrote:
> The environment we do our coverity build in (amd64-fedora-container)
> has just upgraded to Fedora 43.  This ships with libnfs version
> 16.2.0.  We can't currently build against that: in commit
> e2d98f257138 we added a requirement to meson.build that libnfs be <
> 6.0.0, because of an upstream API change that we haven't yet updated
> block/nfs.c to handle.
> 
> The result is that the coverity CI job currently fails in
> configure:
> 
> Dependency libnfs found: NO. Found 16.2.0 but need: '<6.0.0' ;
> matched: '>=1.9.3'
> Run-time dependency libnfs found: NO
> ../meson.build:1150:11: ERROR: Dependency lookup for libnfs with
> method 'pkgconfig' failed: Invalid version, need 'libnfs' ['<6.0.0']
> found '16.2.0'.
> 
> Fix the coverity builds by dropping --enable-libnfs. This means we
> will no longer have coverage of block/nfs.c until/unless we do
> that update to handle the new libnfs API.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   scripts/coverity-scan/run-coverity-scan | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coverity-scan/run-coverity-scan b/scripts/coverity-scan/run-coverity-scan
> index 43cf770f5e..9b89a3303f 100755
> --- a/scripts/coverity-scan/run-coverity-scan
> +++ b/scripts/coverity-scan/run-coverity-scan
> @@ -424,7 +424,7 @@ echo "Configuring..."
>       --enable-linux-aio --enable-attr \
>       --enable-cap-ng --enable-trace-backends=log --enable-spice --enable-rbd \
>       --enable-libusb --enable-usb-redir \
> -    --enable-libiscsi --enable-libnfs --enable-seccomp \
> +    --enable-libiscsi --enable-seccomp \
>       --enable-tpm --enable-libssh --enable-lzo --enable-snappy --enable-bzip2 \
>       --enable-numa --enable-rdma --enable-smartcard --enable-virglrenderer \
>       --enable-mpath --enable-glusterfs \

Reviewed-by: Thomas Huth <thuth@redhat.com>

On Thu, 26 Feb 2026 at 11:14, Thomas Huth <thuth@redhat.com> wrote:
>
> On 26/02/2026 12.10, Peter Maydell wrote:
> > The environment we do our coverity build in (amd64-fedora-container)
> > has just upgraded to Fedora 43.  This ships with libnfs version
> > 16.2.0.  We can't currently build against that: in commit
> > e2d98f257138 we added a requirement to meson.build that libnfs be <
> > 6.0.0, because of an upstream API change that we haven't yet updated
> > block/nfs.c to handle.
> >
> > The result is that the coverity CI job currently fails in
> > configure:
> >
> > Dependency libnfs found: NO. Found 16.2.0 but need: '<6.0.0' ;
> > matched: '>=1.9.3'
> > Run-time dependency libnfs found: NO
> > ../meson.build:1150:11: ERROR: Dependency lookup for libnfs with
> > method 'pkgconfig' failed: Invalid version, need 'libnfs' ['<6.0.0']
> > found '16.2.0'.
> >
> > Fix the coverity builds by dropping --enable-libnfs. This means we
> > will no longer have coverage of block/nfs.c until/unless we do
> > that update to handle the new libnfs API.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   scripts/coverity-scan/run-coverity-scan | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coverity-scan/run-coverity-scan b/scripts/coverity-scan/run-coverity-scan
> > index 43cf770f5e..9b89a3303f 100755
> > --- a/scripts/coverity-scan/run-coverity-scan
> > +++ b/scripts/coverity-scan/run-coverity-scan
> > @@ -424,7 +424,7 @@ echo "Configuring..."
> >       --enable-linux-aio --enable-attr \
> >       --enable-cap-ng --enable-trace-backends=log --enable-spice --enable-rbd \
> >       --enable-libusb --enable-usb-redir \
> > -    --enable-libiscsi --enable-libnfs --enable-seccomp \
> > +    --enable-libiscsi --enable-seccomp \
> >       --enable-tpm --enable-libssh --enable-lzo --enable-snappy --enable-bzip2 \
> >       --enable-numa --enable-rdma --enable-smartcard --enable-virglrenderer \
> >       --enable-mpath --enable-glusterfs \
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks; I've applied this to master to fix the coverity job.

-- PMM