hw/i386: drop unused PC_CPU_MODEL_IDS macro

[PATCH] hw/i386: drop unused PC_CPU_MODEL_IDS macro

Daniel P. Berrangé posted 1 patch 1 month, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260225165400.605941-1-berrange@redhat.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>

hw/i386/pc.c | 9 ---------
1 file changed, 9 deletions(-)

Expand all Fold all

[PATCH] hw/i386: drop unused PC_CPU_MODEL_IDS macro

Posted by Daniel P. Berrangé 1 month, 2 weeks ago

This is redundant since the 2.4 machine types were dropped.

Fixes: 4c82e7b34b1bf35d97e026196f5bf10ea916512c
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 hw/i386/pc.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 0dd3fd01d9..2066181b65 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -73,15 +73,6 @@
 #include "hw/xen/xen-bus.h"
 #endif
 
-/*
- * Helper for setting model-id for CPU models that changed model-id
- * depending on QEMU versions up to QEMU 2.4.
- */
-#define PC_CPU_MODEL_IDS(v) \
-    { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\
-    { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\
-    { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },
-
 GlobalProperty pc_compat_10_2[] = {};
 const size_t pc_compat_10_2_len = G_N_ELEMENTS(pc_compat_10_2);
 
-- 
2.53.0

Re: [PATCH] hw/i386: drop unused PC_CPU_MODEL_IDS macro

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

On 25/2/26 17:54, Daniel P. Berrangé wrote:
> This is redundant since the 2.4 machine types were dropped.
> 
> Fixes: 4c82e7b34b1bf35d97e026196f5bf10ea916512c
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   hw/i386/pc.c | 9 ---------
>   1 file changed, 9 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>