migration: return EEXIST when trying to add the same migration blocker

[PATCH v7] migration: return EEXIST when trying to add the same migration blocker

Ani Sinha posted 1 patch 1 month, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260225100147.389784-1-anisinha@redhat.com

Maintainers: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>

migration/migration.c | 6 ++++++
1 file changed, 6 insertions(+)

Expand all Fold all

[PATCH v7] migration: return EEXIST when trying to add the same migration blocker

Posted by Ani Sinha 1 month, 2 weeks ago

Currently the code that adds a migration blocker does not check if the same
blocker already exists. Return an EEXIST error code if there is an attempt to
add the same migration blocker again. This way the same migration blocker will
not get added twice.

Suggested-by: Prasad Pandit <pjp@fedoraproject.org>
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
 migration/migration.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/migration/migration.c b/migration/migration.c
index a5b0465ed3..eb82e964b2 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1702,6 +1702,12 @@ static int add_blockers(Error **reasonp, unsigned modes, Error **errp)
 {
     for (MigMode mode = 0; mode < MIG_MODE__MAX; mode++) {
         if (modes & BIT(mode)) {
+            if (g_slist_index(migration_blockers[mode],
+                                 *reasonp) >= 0) {
+                error_propagate_prepend(errp, *reasonp,
+                                        "migration blocker already added for: ");
+                return -EEXIST;
+            }
             migration_blockers[mode] = g_slist_prepend(migration_blockers[mode],
                                                        *reasonp);
         }
-- 
2.42.0