hw: copy paste bug

[PATCH] hw: copy paste bug

Posted by Weixie Cui 1 month, 2 weeks ago

Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
---
 hw/ssi/xilinx_spips.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index a4718fb72d..f6e717bc01 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -369,7 +369,7 @@ static void xilinx_spips_reset(DeviceState *d)
     memset(s->regs, 0, sizeof(s->regs));
 
     fifo8_reset(&s->rx_fifo);
-    fifo8_reset(&s->rx_fifo);
+    fifo8_reset(&s->tx_fifo);
     /* non zero resets */
     s->regs[R_CONFIG] |= MODEFAIL_GEN_EN;
     s->regs[R_SLAVE_IDLE_COUNT] = 0xFF;
@@ -397,7 +397,7 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d)
     memset(s->regs, 0, sizeof(s->regs));
 
     fifo8_reset(&s->rx_fifo_g);
-    fifo8_reset(&s->rx_fifo_g);
+    fifo8_reset(&s->tx_fifo_g);
     fifo32_reset(&s->fifo_g);
     s->regs[R_INTR_STATUS] = R_INTR_STATUS_RESET;
     s->regs[R_GPIO] = 1;
-- 
2.39.5 (Apple Git-154)

Re: [PATCH] hw: copy paste bug

Posted by Peter Maydell 1 month, 2 weeks ago

On Mon, 23 Feb 2026 at 13:38, Weixie Cui <cuiweixie@gmail.com> wrote:
>
> Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
> ---
>  hw/ssi/xilinx_spips.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)



Applied to target-arm.next with an updated commit message,
thanks.

-- PMM

Re: [PATCH] hw: copy paste bug

Posted by Markus Armbruster 1 month, 2 weeks ago

Better:

    hw/ssi/xilinx_spips: Fix copy paste bug in device reset

Still missing then: what's the bug's impact?

Re: [PATCH] hw: copy paste bug

Posted by Alistair Francis 1 month, 2 weeks ago

On Mon, Feb 23, 2026 at 11:39 PM Weixie Cui <cuiweixie@gmail.com> wrote:
>
> Signed-off-by: Weixie Cui <cuiweixie@gmail.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  hw/ssi/xilinx_spips.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index a4718fb72d..f6e717bc01 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -369,7 +369,7 @@ static void xilinx_spips_reset(DeviceState *d)
>      memset(s->regs, 0, sizeof(s->regs));
>
>      fifo8_reset(&s->rx_fifo);
> -    fifo8_reset(&s->rx_fifo);
> +    fifo8_reset(&s->tx_fifo);
>      /* non zero resets */
>      s->regs[R_CONFIG] |= MODEFAIL_GEN_EN;
>      s->regs[R_SLAVE_IDLE_COUNT] = 0xFF;
> @@ -397,7 +397,7 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d)
>      memset(s->regs, 0, sizeof(s->regs));
>
>      fifo8_reset(&s->rx_fifo_g);
> -    fifo8_reset(&s->rx_fifo_g);
> +    fifo8_reset(&s->tx_fifo_g);
>      fifo32_reset(&s->fifo_g);
>      s->regs[R_INTR_STATUS] = R_INTR_STATUS_RESET;
>      s->regs[R_GPIO] = 1;
> --
> 2.39.5 (Apple Git-154)
>
>

Re: [PATCH] hw: copy paste bug

Posted by Thomas Huth 1 month, 2 weeks ago

On 23/02/2026 10.59, Weixie Cui wrote:
> Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
> ---
>   hw/ssi/xilinx_spips.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index a4718fb72d..f6e717bc01 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -369,7 +369,7 @@ static void xilinx_spips_reset(DeviceState *d)
>       memset(s->regs, 0, sizeof(s->regs));
>   
>       fifo8_reset(&s->rx_fifo);
> -    fifo8_reset(&s->rx_fifo);
> +    fifo8_reset(&s->tx_fifo);
>       /* non zero resets */
>       s->regs[R_CONFIG] |= MODEFAIL_GEN_EN;
>       s->regs[R_SLAVE_IDLE_COUNT] = 0xFF;
> @@ -397,7 +397,7 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d)
>       memset(s->regs, 0, sizeof(s->regs));
>   
>       fifo8_reset(&s->rx_fifo_g);
> -    fifo8_reset(&s->rx_fifo_g);
> +    fifo8_reset(&s->tx_fifo_g);
>       fifo32_reset(&s->fifo_g);
>       s->regs[R_INTR_STATUS] = R_INTR_STATUS_RESET;
>       s->regs[R_GPIO] = 1;

Reviewed-by: Thomas Huth <thuth@redhat.com>