gdbstub: Build once on various targets (single-binary)

[PATCH v2 07/50] target/ppc: Fix CPUClass::gdb_num_core_regs value

Philippe Mathieu-Daudé posted 50 patches 1 month ago

Download mbox

Maintainers: Laurent Vivier <laurent@vivier.eu>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, Michael Rolnik <mrolnik@gmail.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, "Dr. David Alan Gilbert" <dave@treblig.org>, Richard Henderson <richard.henderson@linaro.org>, Brian Cain <brian.cain@oss.qualcomm.com>, Paolo Bonzini <pbonzini@redhat.com>, Song Gao <gaosong@loongson.cn>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <arikalo@gmail.com>, Stafford Horne <shorne@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Yoshinori Sato <yoshinori.sato@nifty.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Thomas Huth <thuth@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Bastian Koppelmann <kbastian@rumtueddeln.de>

Expand all Fold all

[PATCH v2 07/50] target/ppc: Fix CPUClass::gdb_num_core_regs value

Posted by Philippe Mathieu-Daudé 1 month ago

Only 70 registers are exposed from GDB XML file (for either
32 / 64-bit variants).

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 gdbstub/gdbstub.c     | 2 ++
 target/ppc/cpu_init.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index b45eb7c7b2b..474f6712f8d 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -593,6 +593,8 @@ void gdb_init_cpu(CPUState *cpu)
         gdb_register_feature(cpu, 0,
                              cc->gdb_read_register, cc->gdb_write_register,
                              feature);
+        assert(!cc->gdb_num_core_regs
+               || cc->gdb_num_core_regs == feature->num_regs);
         cpu->gdb_num_regs = cpu->gdb_num_g_regs = feature->num_regs;
     }
 
diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
index c809c1f4d89..27de8d80204 100644
--- a/target/ppc/cpu_init.c
+++ b/target/ppc/cpu_init.c
@@ -7553,7 +7553,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, const void *data)
                       PAGE_WRITE == 2 && PAGE_EXEC == 4);
 #endif
 
-    cc->gdb_num_core_regs = 71;
+    cc->gdb_num_core_regs = 70;
 #ifdef USE_APPLE_GDB
     cc->gdb_read_register = ppc_cpu_gdb_read_register_apple;
     cc->gdb_write_register = ppc_cpu_gdb_write_register_apple;
-- 
2.52.0

Re: [PATCH v2 07/50] target/ppc: Fix CPUClass::gdb_num_core_regs value

Posted by Pierrick Bouvier 1 month ago

On 2/19/26 11:19 AM, Philippe Mathieu-Daudé wrote:
> Only 70 registers are exposed from GDB XML file (for either
> 32 / 64-bit variants).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   gdbstub/gdbstub.c     | 2 ++
>   target/ppc/cpu_init.c | 2 +-
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 

Did you check the assert is not triggered for all other architectures?

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Re: [PATCH v2 07/50] target/ppc: Fix CPUClass::gdb_num_core_regs value

Posted by Philippe Mathieu-Daudé 1 month ago

On 19/2/26 22:06, Pierrick Bouvier wrote:
> On 2/19/26 11:19 AM, Philippe Mathieu-Daudé wrote:
>> Only 70 registers are exposed from GDB XML file (for either
>> 32 / 64-bit variants).
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   gdbstub/gdbstub.c     | 2 ++
>>   target/ppc/cpu_init.c | 2 +-
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
> 
> Did you check the assert is not triggered for all other architectures?

Yes.

> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Thanks!