gdbstub: Build once on various targets (single-binary)

[PATCH v2 50/50] DONOTREVIEW Revert "target/loongarch: Build 'gdbstub.c' once"

Philippe Mathieu-Daudé posted 50 patches 1 month ago

Download mbox

Maintainers: Laurent Vivier <laurent@vivier.eu>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, Michael Rolnik <mrolnik@gmail.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, "Dr. David Alan Gilbert" <dave@treblig.org>, Richard Henderson <richard.henderson@linaro.org>, Brian Cain <brian.cain@oss.qualcomm.com>, Paolo Bonzini <pbonzini@redhat.com>, Song Gao <gaosong@loongson.cn>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <arikalo@gmail.com>, Stafford Horne <shorne@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Yoshinori Sato <yoshinori.sato@nifty.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Thomas Huth <thuth@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Bastian Koppelmann <kbastian@rumtueddeln.de>

Expand all Fold all

[PATCH v2 50/50] DONOTREVIEW Revert "target/loongarch: Build 'gdbstub.c' once"

Posted by Philippe Mathieu-Daudé 1 month ago

While the previous patch "target/loongarch: Build 'gdbstub.c' once
for system single binary" can be reviewed, it depends on Anton's
"Drop TARGET_PHYS_ADDR_SPACE_BITS" series. Revert it to allow this
whole series to be tested by CI bots.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/loongarch/meson.build | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/target/loongarch/meson.build b/target/loongarch/meson.build
index 2ae96d68695..20bd3e2f0a3 100644
--- a/target/loongarch/meson.build
+++ b/target/loongarch/meson.build
@@ -3,14 +3,9 @@ gen = decodetree.process('insns.decode')
 loongarch_ss = ss.source_set()
 loongarch_ss.add(files(
   'cpu.c',
+  'gdbstub.c',
 ))
 
-loongarch_user_ss = ss.source_set()
-loongarch_user_ss.add(files('gdbstub.c'))
-
-loongarch_common_system_ss = ss.source_set()
-loongarch_common_system_ss.add(files('gdbstub.c'))
-
 loongarch_system_ss = ss.source_set()
 loongarch_system_ss.add(files(
   'arch_dump.c',
@@ -25,7 +20,5 @@ common_ss.add(when: 'CONFIG_LOONGARCH_DIS', if_true: [files('disas.c'), gen])
 subdir('tcg')
 
 target_arch += {'loongarch': loongarch_ss}
-target_user_arch += {'loongarch': loongarch_user_ss}
 target_system_arch += {'loongarch': loongarch_system_ss}
-target_common_system_arch += {'loongarch': loongarch_common_system_ss}
 subdir('kvm')
-- 
2.52.0

Re: [PATCH v2 50/50] DONOTREVIEW Revert "target/loongarch: Build 'gdbstub.c' once"

Posted by Chao Liu 4 weeks, 1 day ago

On Thu, Feb 19, 2026 at 08:19:52PM +0100, Philippe Mathieu-Daudé wrote:
> While the previous patch "target/loongarch: Build 'gdbstub.c' once
> for system single binary" can be reviewed, it depends on Anton's
> "Drop TARGET_PHYS_ADDR_SPACE_BITS" series. Revert it to allow this
> whole series to be tested by CI bots.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/loongarch/meson.build | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/target/loongarch/meson.build b/target/loongarch/meson.build
> index 2ae96d68695..20bd3e2f0a3 100644
> --- a/target/loongarch/meson.build
> +++ b/target/loongarch/meson.build
> @@ -3,14 +3,9 @@ gen = decodetree.process('insns.decode')
>  loongarch_ss = ss.source_set()
>  loongarch_ss.add(files(
>    'cpu.c',
> +  'gdbstub.c',
>  ))
>  
> -loongarch_user_ss = ss.source_set()
> -loongarch_user_ss.add(files('gdbstub.c'))
> -
> -loongarch_common_system_ss = ss.source_set()
> -loongarch_common_system_ss.add(files('gdbstub.c'))
> -
>  loongarch_system_ss = ss.source_set()
>  loongarch_system_ss.add(files(
>    'arch_dump.c',
> @@ -25,7 +20,5 @@ common_ss.add(when: 'CONFIG_LOONGARCH_DIS', if_true: [files('disas.c'), gen])
>  subdir('tcg')
>  
>  target_arch += {'loongarch': loongarch_ss}
> -target_user_arch += {'loongarch': loongarch_user_ss}
>  target_system_arch += {'loongarch': loongarch_system_ss}
> -target_common_system_arch += {'loongarch': loongarch_common_system_ss}
>  subdir('kvm')
> -- 
> 2.52.0
> 
> 

Reviewed-by: Chao Liu <chao.liu.zevorn@gmail.com>

Thanks,
Chao