gdbstub: Build once on various targets (single-binary)

[PATCH v2 23/50] target/riscv: Remove empty target_monitor_defs() symbol

Posted by Philippe Mathieu-Daudé 1 month ago

Prefer the stub target_monitor_defs() symbol introduced in commit
bf957284006 ("monitor: remove target-specific code from monitor.c").

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/riscv/monitor.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c
index ccb7eb44d02..a9d31114442 100644
--- a/target/riscv/monitor.c
+++ b/target/riscv/monitor.c
@@ -244,19 +244,6 @@ void hmp_info_mem(Monitor *mon, const QDict *qdict)
     mem_info_svxx(mon, env);
 }
 
-/*
- * We have way too many potential CSRs and regs being added
- * regularly to register them in a static array.
- *
- * Declare an empty array instead, making get_monitor_def() use
- * the target_get_monitor_def() API directly.
- */
-const MonitorDef monitor_defs[] = { { } };
-const MonitorDef *target_monitor_defs(void)
-{
-    return monitor_defs;
-}
-
 static bool reg_is_ulong_integer(CPURISCVState *env, const char *name,
                                  target_ulong *val, bool is_gprh)
 {
-- 
2.52.0

Re: [PATCH v2 23/50] target/riscv: Remove empty target_monitor_defs() symbol

Posted by Chao Liu 4 weeks, 1 day ago

On Thu, Feb 19, 2026 at 08:19:25PM +0100, Philippe Mathieu-Daudé wrote:
> Prefer the stub target_monitor_defs() symbol introduced in commit
> bf957284006 ("monitor: remove target-specific code from monitor.c").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/riscv/monitor.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c
> index ccb7eb44d02..a9d31114442 100644
> --- a/target/riscv/monitor.c
> +++ b/target/riscv/monitor.c
> @@ -244,19 +244,6 @@ void hmp_info_mem(Monitor *mon, const QDict *qdict)
>      mem_info_svxx(mon, env);
>  }
>  
> -/*
> - * We have way too many potential CSRs and regs being added
> - * regularly to register them in a static array.
> - *
> - * Declare an empty array instead, making get_monitor_def() use
> - * the target_get_monitor_def() API directly.
> - */
> -const MonitorDef monitor_defs[] = { { } };
> -const MonitorDef *target_monitor_defs(void)
> -{
> -    return monitor_defs;
> -}
> -
>  static bool reg_is_ulong_integer(CPURISCVState *env, const char *name,
>                                   target_ulong *val, bool is_gprh)
>  {
> -- 
> 2.52.0
> 
> 

Reviewed-by: Chao Liu <chao.liu.zevorn@gmail.com>

Thanks,
Chao

Re: [PATCH v2 23/50] target/riscv: Remove empty target_monitor_defs() symbol

Posted by Daniel Henrique Barboza 1 month ago


On 2/19/2026 4:19 PM, Philippe Mathieu-Daudé wrote:
> Prefer the stub target_monitor_defs() symbol introduced in commit
> bf957284006 ("monitor: remove target-specific code from monitor.c").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---


Reviewed-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>

>   target/riscv/monitor.c | 13 -------------
>   1 file changed, 13 deletions(-)
> 
> diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c
> index ccb7eb44d02..a9d31114442 100644
> --- a/target/riscv/monitor.c
> +++ b/target/riscv/monitor.c
> @@ -244,19 +244,6 @@ void hmp_info_mem(Monitor *mon, const QDict *qdict)
>       mem_info_svxx(mon, env);
>   }
>   
> -/*
> - * We have way too many potential CSRs and regs being added
> - * regularly to register them in a static array.
> - *
> - * Declare an empty array instead, making get_monitor_def() use
> - * the target_get_monitor_def() API directly.
> - */
> -const MonitorDef monitor_defs[] = { { } };
> -const MonitorDef *target_monitor_defs(void)
> -{
> -    return monitor_defs;
> -}
> -
>   static bool reg_is_ulong_integer(CPURISCVState *env, const char *name,
>                                    target_ulong *val, bool is_gprh)
>   {

Re: [PATCH v2 23/50] target/riscv: Remove empty target_monitor_defs() symbol

Posted by Pierrick Bouvier 1 month ago

On 2/19/26 11:19 AM, Philippe Mathieu-Daudé wrote:
> Prefer the stub target_monitor_defs() symbol introduced in commit
> bf957284006 ("monitor: remove target-specific code from monitor.c").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/riscv/monitor.c | 13 -------------
>   1 file changed, 13 deletions(-)
> 

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>