cpu_reset clean-ups for arm, alpha, mips, m68k and tricore

[RFC PATCH v2 08/14] hw/mips: drop cpu_reset in mips_cpu_realizefn

Alex Bennée posted 14 patches 1 month, 3 weeks ago

Download mbox

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Thomas Huth <huth@tuxfamily.org>, Laurent Vivier <laurent@vivier.eu>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, Peter Maydell <peter.maydell@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <arikalo@gmail.com>, Bastian Koppelmann <kbastian@rumtueddeln.de>

Expand all Fold all

[RFC PATCH v2 08/14] hw/mips: drop cpu_reset in mips_cpu_realizefn

Posted by Alex Bennée 1 month, 3 weeks ago

We will always do a cpu_reset during mips_cpu_reset_hold().

Message-ID: <20260108143423.1378674-10-alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 target/mips/cpu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/mips/cpu.c b/target/mips/cpu.c
index e424d115018..f20613f1223 100644
--- a/target/mips/cpu.c
+++ b/target/mips/cpu.c
@@ -488,7 +488,6 @@ static void mips_cpu_realizefn(DeviceState *dev, Error **errp)
     fpu_init(env, env->cpu_model);
     mvp_init(env);
 
-    cpu_reset(cs);
     qemu_init_vcpu(cs);
 
     mcc->parent_realize(dev, errp);
-- 
2.47.3

Re: [RFC PATCH v2 08/14] hw/mips: drop cpu_reset in mips_cpu_realizefn

Posted by Pierrick Bouvier 1 month, 3 weeks ago

On 2/19/26 9:18 AM, Alex Bennée wrote:
> We will always do a cpu_reset during mips_cpu_reset_hold().
> 
> Message-ID: <20260108143423.1378674-10-alex.bennee@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   target/mips/cpu.c | 1 -
>   1 file changed, 1 deletion(-)
> 

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>