hw/i386/pc: Add a proper owner for the ioport memory regions

[PATCH] hw/i386/pc: Add a proper owner for the ioport memory regions

Posted by Thomas Huth 1 month, 3 weeks ago

From: Thomas Huth <thuth@redhat.com>

Without a proper owner, the memory regions show up in /machine/unattached
in the QOM tree, which is something that should be avoided.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/i386/pc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 0dd3fd01d98..ee72dd47590 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1127,10 +1127,12 @@ void pc_basic_device_init(struct PCMachineState *pcms,
     MemoryRegion *ioportF0_io = g_new(MemoryRegion, 1);
     X86MachineState *x86ms = X86_MACHINE(pcms);
 
-    memory_region_init_io(ioport80_io, NULL, &ioport80_io_ops, NULL, "ioport80", 1);
+    memory_region_init_io(ioport80_io, OBJECT(pcms), &ioport80_io_ops, NULL,
+                          "ioport80", 1);
     memory_region_add_subregion(isa_bus->address_space_io, 0x80, ioport80_io);
 
-    memory_region_init_io(ioportF0_io, NULL, &ioportF0_io_ops, NULL, "ioportF0", 1);
+    memory_region_init_io(ioportF0_io, OBJECT(pcms), &ioportF0_io_ops, NULL,
+                          "ioportF0", 1);
     memory_region_add_subregion(isa_bus->address_space_io, 0xf0, ioportF0_io);
 
     /*
-- 
2.53.0

Re: [PATCH] hw/i386/pc: Add a proper owner for the ioport memory regions

Posted by Michael Tokarev 1 month ago

On 17.02.2026 17:18, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Without a proper owner, the memory regions show up in /machine/unattached
> in the QOM tree, which is something that should be avoided.

Does this break migration from/to older releases?

Thanks,

/mjt

> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   hw/i386/pc.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 0dd3fd01d98..ee72dd47590 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1127,10 +1127,12 @@ void pc_basic_device_init(struct PCMachineState *pcms,
>       MemoryRegion *ioportF0_io = g_new(MemoryRegion, 1);
>       X86MachineState *x86ms = X86_MACHINE(pcms);
>   
> -    memory_region_init_io(ioport80_io, NULL, &ioport80_io_ops, NULL, "ioport80", 1);
> +    memory_region_init_io(ioport80_io, OBJECT(pcms), &ioport80_io_ops, NULL,
> +                          "ioport80", 1);
>       memory_region_add_subregion(isa_bus->address_space_io, 0x80, ioport80_io);
>   
> -    memory_region_init_io(ioportF0_io, NULL, &ioportF0_io_ops, NULL, "ioportF0", 1);
> +    memory_region_init_io(ioportF0_io, OBJECT(pcms), &ioportF0_io_ops, NULL,
> +                          "ioportF0", 1);
>       memory_region_add_subregion(isa_bus->address_space_io, 0xf0, ioportF0_io);
>   
>       /*

Re: [PATCH] hw/i386/pc: Add a proper owner for the ioport memory regions

Posted by Thomas Huth 1 month ago

On 11/03/2026 12.53, Michael Tokarev wrote:
> On 17.02.2026 17:18, Thomas Huth wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> Without a proper owner, the memory regions show up in /machine/unattached
>> in the QOM tree, which is something that should be avoided.
> 
> Does this break migration from/to older releases?

AFAIK the QOM tree ordering is orthogonal to the migration logic ... or did 
we ever have any problems with this in the past?

  Thomas