[PATCH 3/8] tests/qtest: remove -audio none when configured with --disable-audio

Sergei Heifetz posted 8 patches 1 month, 3 weeks ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>
There is a newer version of this series
[PATCH 3/8] tests/qtest: remove -audio none when configured with --disable-audio
Posted by Sergei Heifetz 1 month, 3 weeks ago
It does not matter much whether `-audio none` is passed. In the future,
support for `-audio none` with `--disable-audio` will be dropped, so we
should remove it beforehand.

Signed-off-by: Sergei Heifetz <heifetz@yandex-team.com>
---
 tests/qtest/libqtest.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 794d870085..adb968f40e 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -464,7 +464,9 @@ gchar *qtest_qemu_args(const char *extra_args)
                       "-chardev socket,path=%s,id=char0 "
                       "-mon chardev=char0,mode=control "
                       "-display none "
+#ifdef CONFIG_AUDIO
                       "-audio none "
+#endif
                       "%s"
                       "%s"
                       " -accel qtest",
-- 
2.34.1
Re: [PATCH 3/8] tests/qtest: remove -audio none when configured with --disable-audio
Posted by Thomas Huth 1 month, 3 weeks ago
On 17/02/2026 06.27, Sergei Heifetz wrote:
> It does not matter much whether `-audio none` is passed. In the future,
> support for `-audio none` with `--disable-audio` will be dropped, so we
> should remove it beforehand.
> 
> Signed-off-by: Sergei Heifetz <heifetz@yandex-team.com>
> ---
>   tests/qtest/libqtest.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
> index 794d870085..adb968f40e 100644
> --- a/tests/qtest/libqtest.c
> +++ b/tests/qtest/libqtest.c
> @@ -464,7 +464,9 @@ gchar *qtest_qemu_args(const char *extra_args)
>                         "-chardev socket,path=%s,id=char0 "
>                         "-mon chardev=char0,mode=control "
>                         "-display none "
> +#ifdef CONFIG_AUDIO
>                         "-audio none "
> +#endif
>                         "%s"
>                         "%s"
>                         " -accel qtest",

Reviewed-by: Thomas Huth <thuth@redhat.com>