[PATCH 3/5] page-vary: Use target_page_bits_vary in set_preferred_target_page_bits

Philippe Mathieu-Daudé posted 5 patches 1 month, 3 weeks ago
Maintainers: Pierrick Bouvier <pierrick.bouvier@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>
[PATCH 3/5] page-vary: Use target_page_bits_vary in set_preferred_target_page_bits
Posted by Philippe Mathieu-Daudé 1 month, 3 weeks ago
Rather checking whether the target uses variable page sizes
at runtime calling target_page_bits_vary().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 page-vary-target.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/page-vary-target.c b/page-vary-target.c
index ab92da4539d..5fb79eb5752 100644
--- a/page-vary-target.c
+++ b/page-vary-target.c
@@ -20,6 +20,7 @@
 #define IN_PAGE_VARY 1
 
 #include "qemu/osdep.h"
+#include "qemu/target-info.h"
 #include "exec/page-vary.h"
 #include "exec/target_page.h"
 
@@ -46,11 +47,10 @@ int migration_legacy_page_bits(void)
 bool set_preferred_target_page_bits(int bits)
 {
     assert(bits >= TARGET_PAGE_BITS_MIN);
-#ifdef TARGET_PAGE_BITS_VARY
-    return set_preferred_target_page_bits_common(bits);
-#else
+    if (target_page_bits_vary()) {
+        return set_preferred_target_page_bits_common(bits);
+    }
     return true;
-#endif
 }
 
 void finalize_target_page_bits(void)
-- 
2.52.0


Re: [PATCH 3/5] page-vary: Use target_page_bits_vary in set_preferred_target_page_bits
Posted by Pierrick Bouvier 1 month, 3 weeks ago
On 2/13/26 10:27 AM, Philippe Mathieu-Daudé wrote:
> Rather checking whether the target uses variable page sizes
> at runtime calling target_page_bits_vary().
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   page-vary-target.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>