tests/functional: Make sure test case .py files are executable

[PATCH] tests/functional: Make sure test case .py files are executable

Posted by Peter Maydell 1 month, 4 weeks ago

The top-level test python scripts in tests/functional are supposed to
be marked executable; "make check-functional" doesn't care about
this, but it allows them to be run as standalone executables to
exercise a single test, as docs/devel/testing/functional.rst
describes.

A couple of files have got into the tree without the executable
bit set: fix them.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 tests/functional/arm/test_aspeed_ast1060.py | 0
 tests/functional/ppc/test_ppe42.py          | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tests/functional/arm/test_aspeed_ast1060.py
 mode change 100644 => 100755 tests/functional/ppc/test_ppe42.py

diff --git a/tests/functional/arm/test_aspeed_ast1060.py b/tests/functional/arm/test_aspeed_ast1060.py
old mode 100644
new mode 100755
diff --git a/tests/functional/ppc/test_ppe42.py b/tests/functional/ppc/test_ppe42.py
old mode 100644
new mode 100755
-- 
2.43.0

Re: [PATCH] tests/functional: Make sure test case .py files are executable

Posted by Thomas Huth 1 month, 4 weeks ago

On 12/02/2026 16.12, Peter Maydell wrote:
> The top-level test python scripts in tests/functional are supposed to
> be marked executable; "make check-functional" doesn't care about
> this, but it allows them to be run as standalone executables to
> exercise a single test, as docs/devel/testing/functional.rst
> describes.
> 
> A couple of files have got into the tree without the executable
> bit set: fix them.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   tests/functional/arm/test_aspeed_ast1060.py | 0
>   tests/functional/ppc/test_ppe42.py          | 0
>   2 files changed, 0 insertions(+), 0 deletions(-)
>   mode change 100644 => 100755 tests/functional/arm/test_aspeed_ast1060.py
>   mode change 100644 => 100755 tests/functional/ppc/test_ppe42.py
> 
> diff --git a/tests/functional/arm/test_aspeed_ast1060.py b/tests/functional/arm/test_aspeed_ast1060.py
> old mode 100644
> new mode 100755
> diff --git a/tests/functional/ppc/test_ppe42.py b/tests/functional/ppc/test_ppe42.py
> old mode 100644
> new mode 100755

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] tests/functional: Make sure test case .py files are executable

Posted by Peter Maydell 1 month, 2 weeks ago

On Thu, 12 Feb 2026 at 15:24, Thomas Huth <thuth@redhat.com> wrote:
>
> On 12/02/2026 16.12, Peter Maydell wrote:
> > The top-level test python scripts in tests/functional are supposed to
> > be marked executable; "make check-functional" doesn't care about
> > this, but it allows them to be run as standalone executables to
> > exercise a single test, as docs/devel/testing/functional.rst
> > describes.
> >
> > A couple of files have got into the tree without the executable
> > bit set: fix them.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   tests/functional/arm/test_aspeed_ast1060.py | 0
> >   tests/functional/ppc/test_ppe42.py          | 0
> >   2 files changed, 0 insertions(+), 0 deletions(-)
> >   mode change 100644 => 100755 tests/functional/arm/test_aspeed_ast1060.py
> >   mode change 100644 => 100755 tests/functional/ppc/test_ppe42.py
> >
> > diff --git a/tests/functional/arm/test_aspeed_ast1060.py b/tests/functional/arm/test_aspeed_ast1060.py
> > old mode 100644
> > new mode 100755
> > diff --git a/tests/functional/ppc/test_ppe42.py b/tests/functional/ppc/test_ppe42.py
> > old mode 100644
> > new mode 100755
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks; I've picked this up into target-arm.next since I'm assembling
a pullreq, unless you would prefer to take it some other route.

-- PMM