[v2] hw/i386/pc.c: add description for fd-bootchk option

[PATCH v2] hw/i386/pc.c: add description for fd-bootchk option

Choon Keong posted 1 patch 1 month, 4 weeks ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260211162909.6550-1-ckeong.teo17@gmail.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>

hw/i386/pc.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH v2] hw/i386/pc.c: add description for fd-bootchk option

Posted by Choon Keong 1 month, 4 weeks ago

The 'fd-bootchk' option for pc and q35 machines currently lacks of
description in the help output. This makes it difficult for users
to understand the purpose of the command.

This commit solve this issue by adding description using
object_class_property_set_description() in hw/i386/pc.c,
adding the the description message for the option 'fd-bootchk'.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Suggested-by: Thomas Huth <thuth@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3193
Signed-off-by: Choon Keong <ckeong.teo17@gmail.com>
---
 hw/i386/pc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 5cb074c0a0..4687719766 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1822,6 +1822,8 @@ static void pc_machine_class_init(ObjectClass *oc, const void *data)
     object_class_property_add_bool(oc, "fd-bootchk",
         pc_machine_get_fd_bootchk,
         pc_machine_set_fd_bootchk);
+    object_class_property_set_description(oc, "fd-bootchk",
+        "Enable/disable boot signature checking for floppy disks in BIOS");
 
 #if defined(CONFIG_IGVM)
     object_class_property_add_link(oc, "igvm-cfg",
-- 
2.43.0

Re: [PATCH v2] hw/i386/pc.c: add description for fd-bootchk option

Posted by Thomas Huth 1 month, 4 weeks ago

On 11/02/2026 17.29, Choon Keong wrote:
> The 'fd-bootchk' option for pc and q35 machines currently lacks of
> description in the help output. This makes it difficult for users
> to understand the purpose of the command.
> 
> This commit solve this issue by adding description using
> object_class_property_set_description() in hw/i386/pc.c,
> adding the the description message for the option 'fd-bootchk'.
> 
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3193
> Signed-off-by: Choon Keong <ckeong.teo17@gmail.com>
> ---
>   hw/i386/pc.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 5cb074c0a0..4687719766 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1822,6 +1822,8 @@ static void pc_machine_class_init(ObjectClass *oc, const void *data)
>       object_class_property_add_bool(oc, "fd-bootchk",
>           pc_machine_get_fd_bootchk,
>           pc_machine_set_fd_bootchk);
> +    object_class_property_set_description(oc, "fd-bootchk",
> +        "Enable/disable boot signature checking for floppy disks in BIOS");
>   
>   #if defined(CONFIG_IGVM)
>       object_class_property_add_link(oc, "igvm-cfg",

Reviewed-by: Thomas Huth <thuth@redhat.com>