build-sys: use the "run" variable

[PATCH] build-sys: use the "run" variable

Posted by marcandre.lureau@redhat.com 1 month, 4 weeks ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Avoid unused variables and hand-written path, this should also help meson
to figure out the relation between the commands.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 38ad6820f3e..e2aa90a43de 100644
--- a/meson.build
+++ b/meson.build
@@ -3473,7 +3473,7 @@ run_config = configuration_data({'build_dir': meson.current_build_dir()})
 run = configure_file(input: 'run.in',
                      output: 'run',
                      configuration: run_config)
-run_command('chmod', 'a+x', meson.current_build_dir() / 'run', check: true)
+run_command('chmod', 'a+x', run, check: true)
 
 hxtool = find_program('scripts/hxtool')
 shaderinclude = find_program('scripts/shaderinclude.py')
-- 
2.52.0

Re: [PATCH] build-sys: use the "run" variable

Posted by Paolo Bonzini 3 weeks, 4 days ago

Queued, thanks.

Paolo

Re: [PATCH] build-sys: use the "run" variable

Posted by Daniel P. Berrangé 3 weeks, 4 days ago

On Wed, Feb 11, 2026 at 02:33:05PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Avoid unused variables and hand-written path, this should also help meson
> to figure out the relation between the commands.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Re: [PATCH] build-sys: use the "run" variable

Posted by Marc-André Lureau 3 weeks, 4 days ago

On Wed, Feb 11, 2026 at 2:33 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Avoid unused variables and hand-written path, this should also help meson
> to figure out the relation between the commands.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

ping

> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 38ad6820f3e..e2aa90a43de 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -3473,7 +3473,7 @@ run_config = configuration_data({'build_dir': meson.current_build_dir()})
>  run = configure_file(input: 'run.in',
>                       output: 'run',
>                       configuration: run_config)
> -run_command('chmod', 'a+x', meson.current_build_dir() / 'run', check: true)
> +run_command('chmod', 'a+x', run, check: true)
>
>  hxtool = find_program('scripts/hxtool')
>  shaderinclude = find_program('scripts/shaderinclude.py')
> --
> 2.52.0
>