[v5] Support per-head resolutions with virtio-gpu

[PATCH v5 0/1] Support per-head resolutions with virtio-gpu

Andrew Keesler posted 1 patch 4 hours ago

Diff against v1 v2 v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260210123038.2332364-1-ankeesler@google.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>, Dmitry Osipenko <dmitry.osipenko@collabora.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

hw/display/virtio-gpu-base.c | 16 ++++++++++++++++
qapi/virtio.json             | 13 +++++++++++--
2 files changed, 27 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH v5 0/1] Support per-head resolutions with virtio-gpu

Posted by Andrew Keesler 4 hours ago

In 454f4b0f, we started down the path of supporting separate
configurations per display head (e.g., you have 2 heads - one with
EDID name "AAA" and the other with EDID name "BBB").

In this change, we add resolution to this configuration surface (e.g.,
you have 2 heads - one with resolution 111x222 and the other with
resolution 333x444).

  -display vnc=localhost:0,id=aaa,display=vga,head=0 \
  -display vnc=localhost:1,id=bbb,display=vga,head=1 \
  -device '{"driver":"virtio-vga",
            "max_outputs":2,
            "id":"vga",
            "outputs":[
              {
                 "name":"AAA",
                 "xres":111,
                 "yres":222
              },
              {
                 "name":"BBB",
                 "xres":333,
                 "yres":444
              }
            ]}'

Here is the behavior matrix of the current resolution configuration
surface (xres/yres) with the new resolution configuration surface
(outputs[i].xres/yres).

Note - we use "xres" and "yres" (instead of, say, "width" and "height")
to match analogous virtio_gpu_base_conf.xres/yres.

Case: !(xres || yres) && !(outputs[i].has_xres && outputs[i].has_yres)
Behavior: current behavior - outputs[0] enabled with default xres/yres

Case: (xres || yres) && !(outputs[i].has_xres && outputs[i].has_yres)
Behavior: current behavior - outputs[0] enabled with xres/yres

Case: outputs[i].has_xres && outputs[i].has_yres
Behavior: new behavior - outputs[i] enabled with outputs[i].xres/yres

Case: outputs[i].has_xres != outputs[i].has_yres
Behavior: error

Changelist:
* v5: changes after v4 review
  * since 10.2 -> since 11.0
  * setting only one of xres and yres is an error
* v4: changes after dropped from pull request
  * rebase against master (3b5fe75e2c)
  * use @NAME (@xres/@yres) in qapi/virtio.json docs
  * documented behavior when only one or none of @xres/@yres is set
* v3: changes after v2 review
  * fix new resolution configuration logic (&& instead of ||)
  * correct use of api machinery (has_*)
  * move documentation to QMP API
* v2: changes after v1 review + 10.2 rebase
  * updated code, commit message, and cover letter to match new res config logic
  * marked new VirtIOGPUOutput fields as optional and since 10.2
* v1: initial patch

Andrew Keesler (1):
  Support per-head resolutions with virtio-gpu

 hw/display/virtio-gpu-base.c | 16 ++++++++++++++++
 qapi/virtio.json             | 13 +++++++++++--
 2 files changed, 27 insertions(+), 2 deletions(-)

-- 
2.53.0.rc2.204.g2597b5adb4-goog