Support ASPEED AST2700 A2

[PATCH v1 04/10] hw/misc/aspeed_scu: Add AST2700 A2 silicon revisions

Posted by Jamin Lin 2 days, 21 hours ago

Add silicon revision definitions for AST2700 A2, and include
them in the list of supported Aspeed silicon revisions.

This allows newer AST27x0 A2 silicon to be correctly identified via
the SCU silicon revision register.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 include/hw/misc/aspeed_scu.h | 1 +
 hw/misc/aspeed_scu.c         | 1 +
 2 files changed, 2 insertions(+)

diff --git a/include/hw/misc/aspeed_scu.h b/include/hw/misc/aspeed_scu.h
index 313a79f2f7..d003955428 100644
--- a/include/hw/misc/aspeed_scu.h
+++ b/include/hw/misc/aspeed_scu.h
@@ -47,6 +47,7 @@ struct AspeedSCUState {
 #define AST1030_A1_SILICON_REV   0x80010000U
 #define AST1060_A2_SILICON_REV   0xA0030000U
 #define AST2700_A1_SILICON_REV   0x06010103U
+#define AST2700_A2_SILICON_REV   0x06020103U
 
 #define ASPEED_IS_AST2500(si_rev)     ((((si_rev) >> 24) & 0xff) == 0x04)
 
diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
index 0edf9c1b16..e4160356e4 100644
--- a/hw/misc/aspeed_scu.c
+++ b/hw/misc/aspeed_scu.c
@@ -561,6 +561,7 @@ static uint32_t aspeed_silicon_revs[] = {
     AST1030_A1_SILICON_REV,
     AST1060_A2_SILICON_REV,
     AST2700_A1_SILICON_REV,
+    AST2700_A2_SILICON_REV,
 };
 
 bool is_supported_silicon_rev(uint32_t silicon_rev)
-- 
2.43.0

Re: [PATCH v1 04/10] hw/misc/aspeed_scu: Add AST2700 A2 silicon revisions

Posted by Cédric Le Goater 2 days, 17 hours ago

On 2/6/26 06:33, Jamin Lin wrote:
> Add silicon revision definitions for AST2700 A2, and include
> them in the list of supported Aspeed silicon revisions.
> 
> This allows newer AST27x0 A2 silicon to be correctly identified via
> the SCU silicon revision register.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   include/hw/misc/aspeed_scu.h | 1 +
>   hw/misc/aspeed_scu.c         | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/include/hw/misc/aspeed_scu.h b/include/hw/misc/aspeed_scu.h
> index 313a79f2f7..d003955428 100644
> --- a/include/hw/misc/aspeed_scu.h
> +++ b/include/hw/misc/aspeed_scu.h
> @@ -47,6 +47,7 @@ struct AspeedSCUState {
>   #define AST1030_A1_SILICON_REV   0x80010000U
>   #define AST1060_A2_SILICON_REV   0xA0030000U
>   #define AST2700_A1_SILICON_REV   0x06010103U
> +#define AST2700_A2_SILICON_REV   0x06020103U
>   
>   #define ASPEED_IS_AST2500(si_rev)     ((((si_rev) >> 24) & 0xff) == 0x04)
>   
> diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
> index 0edf9c1b16..e4160356e4 100644
> --- a/hw/misc/aspeed_scu.c
> +++ b/hw/misc/aspeed_scu.c
> @@ -561,6 +561,7 @@ static uint32_t aspeed_silicon_revs[] = {
>       AST1030_A1_SILICON_REV,
>       AST1060_A2_SILICON_REV,
>       AST2700_A1_SILICON_REV,
> +    AST2700_A2_SILICON_REV,
>   };
>   
>   bool is_supported_silicon_rev(uint32_t silicon_rev)

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.