On 2/6/26 06:33, Jamin Lin wrote:
> Several legacy Aspeed SoC silicon revision definitions are no longer
> used by any machine models or runtime logic.
>
> Remove unused silicon revision macros and corresponding entries from
> the silicon revision table to reduce dead code and improve
> maintainability.
>
> No functional change intended.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> include/hw/misc/aspeed_scu.h | 10 ----------
> hw/misc/aspeed_scu.c | 10 ----------
> 2 files changed, 20 deletions(-)
>
> diff --git a/include/hw/misc/aspeed_scu.h b/include/hw/misc/aspeed_scu.h
> index 9e28bd4d2e..313a79f2f7 100644
> --- a/include/hw/misc/aspeed_scu.h
> +++ b/include/hw/misc/aspeed_scu.h
> @@ -41,22 +41,12 @@ struct AspeedSCUState {
> uint32_t hw_prot_key;
> };
>
> -#define AST2400_A0_SILICON_REV 0x02000303U
> #define AST2400_A1_SILICON_REV 0x02010303U
> -#define AST2500_A0_SILICON_REV 0x04000303U
> #define AST2500_A1_SILICON_REV 0x04010303U
> -#define AST2600_A0_SILICON_REV 0x05000303U
> -#define AST2600_A1_SILICON_REV 0x05010303U
> -#define AST2600_A2_SILICON_REV 0x05020303U
> #define AST2600_A3_SILICON_REV 0x05030303U
> -#define AST1030_A0_SILICON_REV 0x80000000U
> #define AST1030_A1_SILICON_REV 0x80010000U
> #define AST1060_A2_SILICON_REV 0xA0030000U
> -#define AST2700_A0_SILICON_REV 0x06000103U
> -#define AST2720_A0_SILICON_REV 0x06000203U
> -#define AST2750_A0_SILICON_REV 0x06000003U
> #define AST2700_A1_SILICON_REV 0x06010103U
> -#define AST2750_A1_SILICON_REV 0x06010003U
>
> #define ASPEED_IS_AST2500(si_rev) ((((si_rev) >> 24) & 0xff) == 0x04)
>
> diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
> index 6829efa2dc..0edf9c1b16 100644
> --- a/hw/misc/aspeed_scu.c
> +++ b/hw/misc/aspeed_scu.c
> @@ -555,22 +555,12 @@ static void aspeed_scu_reset(DeviceState *dev)
> }
>
> static uint32_t aspeed_silicon_revs[] = {
> - AST2400_A0_SILICON_REV,
> AST2400_A1_SILICON_REV,
> - AST2500_A0_SILICON_REV,
> AST2500_A1_SILICON_REV,
> - AST2600_A0_SILICON_REV,
> - AST2600_A1_SILICON_REV,
> - AST2600_A2_SILICON_REV,
> AST2600_A3_SILICON_REV,
> - AST1030_A0_SILICON_REV,
> AST1030_A1_SILICON_REV,
> AST1060_A2_SILICON_REV,
> - AST2700_A0_SILICON_REV,
> - AST2720_A0_SILICON_REV,
> - AST2750_A0_SILICON_REV,
> AST2700_A1_SILICON_REV,
> - AST2750_A1_SILICON_REV,
> };
>
> bool is_supported_silicon_rev(uint32_t silicon_rev)
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.