RFC: make RamDiscardManager work with multiple sources

[PATCH 01/10] system/rba: use DIV_ROUND_UP

Posted by marcandre.lureau@redhat.com 5 days, 12 hours ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Mostly for readability.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 system/ram-block-attributes.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/system/ram-block-attributes.c b/system/ram-block-attributes.c
index fb7c5c27467..9f72a6b3545 100644
--- a/system/ram-block-attributes.c
+++ b/system/ram-block-attributes.c
@@ -401,8 +401,7 @@ RamBlockAttributes *ram_block_attributes_create(RAMBlock *ram_block)
         object_unref(OBJECT(attr));
         return NULL;
     }
-    attr->bitmap_size =
-        ROUND_UP(int128_get64(mr->size), block_size) / block_size;
+    attr->bitmap_size = DIV_ROUND_UP(int128_get64(mr->size), block_size);
     attr->bitmap = bitmap_new(attr->bitmap_size);
 
     return attr;
-- 
2.52.0

Re: [PATCH 01/10] system/rba: use DIV_ROUND_UP

Posted by Cédric Le Goater 5 days, 11 hours ago

On 2/4/26 11:06, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Mostly for readability.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   system/ram-block-attributes.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/system/ram-block-attributes.c b/system/ram-block-attributes.c
> index fb7c5c27467..9f72a6b3545 100644
> --- a/system/ram-block-attributes.c
> +++ b/system/ram-block-attributes.c
> @@ -401,8 +401,7 @@ RamBlockAttributes *ram_block_attributes_create(RAMBlock *ram_block)
>           object_unref(OBJECT(attr));
>           return NULL;
>       }
> -    attr->bitmap_size =
> -        ROUND_UP(int128_get64(mr->size), block_size) / block_size;
> +    attr->bitmap_size = DIV_ROUND_UP(int128_get64(mr->size), block_size);
>       attr->bitmap = bitmap_new(attr->bitmap_size);
>   
>       return attr;

Reviewed-by: Cédric Le Goater <clg@redhat.com

Thanks,

C.