tests/Makefile.include | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-)
User can execute TCG tests for a specific TARGET using the command:
$ make run-tcg-tests-TARGET-softmmu
However, this command is not showing in 'make check-help'
documentation, making it hard for new contributors to
discover.
This commit help to resolve this by adding the description
for the command, to the "Individual test suites" section
in tests/Makefile.include.
Additionally, reformat the alignment to accommodate
the length of the new command, ensuring the
consistency of the output.
Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/228
Signed-off-by: ck <ckeong.teo17@gmail.com>
---
tests/Makefile.include | 33 +++++++++++++++++----------------
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 7728098981..5a99f0a920 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -3,29 +3,30 @@
.PHONY: check-help
check-help:
@echo "Regression testing targets:"
- @echo " $(MAKE) check Run block, qapi-schema, unit, softfloat, qtest and decodetree tests"
- @echo " $(MAKE) bench Run speed tests"
+ @echo " $(MAKE) check Run block, qapi-schema, unit, softfloat, qtest and decodetree tests"
+ @echo " $(MAKE) bench Run speed tests"
@echo
@echo "Individual test suites:"
- @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target"
- @echo " $(MAKE) check-qtest Run qtest tests"
- @echo " $(MAKE) check-functional Run python-based functional tests"
- @echo " $(MAKE) check-functional-TARGET Run functional tests for a given target"
- @echo " $(MAKE) check-unit Run qobject tests"
- @echo " $(MAKE) check-qapi-schema Run QAPI schema tests"
- @echo " $(MAKE) check-tracetool Run tracetool generator tests"
- @echo " $(MAKE) check-block Run block tests"
+ @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target"
+ @echo " $(MAKE) check-qtest Run qtest tests"
+ @echo " $(MAKE) check-functional Run python-based functional tests"
+ @echo " $(MAKE) check-functional-TARGET Run functional tests for a given target"
+ @echo " $(MAKE) check-unit Run qobject tests"
+ @echo " $(MAKE) check-qapi-schema Run QAPI schema tests"
+ @echo " $(MAKE) check-tracetool Run tracetool generator tests"
+ @echo " $(MAKE) check-block Run block tests"
+ @echo " $(MAKE) run-tcg-tests-TARGET-softmmu Run TCG tests for a given target"
ifneq ($(filter $(all-check-targets), check-softfloat),)
- @echo " $(MAKE) check-tcg Run TCG tests"
- @echo " $(MAKE) check-softfloat Run FPU emulation tests"
+ @echo " $(MAKE) check-tcg Run TCG tests"
+ @echo " $(MAKE) check-softfloat Run FPU emulation tests"
endif
@echo
- @echo " $(MAKE) check-report.junit.xml Generates an aggregated XML test report"
- @echo " $(MAKE) check-venv Creates a Python venv for tests"
- @echo " $(MAKE) check-clean Clean the tests and related data"
+ @echo " $(MAKE) check-report.junit.xml Generates an aggregated XML test report"
+ @echo " $(MAKE) check-venv Creates a Python venv for tests"
+ @echo " $(MAKE) check-clean Clean the tests and related data"
@echo
@echo "The following are useful for CI builds"
- @echo " $(MAKE) check-build Build most test binaries"
+ @echo " $(MAKE) check-build Build most test binaries"
@echo
@echo
@echo "The variable SPEED can be set to control the gtester speed setting."
--
2.43.0
Hi! Thanks for your patch! A comment below... On 04/02/2026 02.46, ck wrote: ... > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 7728098981..5a99f0a920 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -3,29 +3,30 @@ > .PHONY: check-help > check-help: > @echo "Regression testing targets:" > - @echo " $(MAKE) check Run block, qapi-schema, unit, softfloat, qtest and decodetree tests" > - @echo " $(MAKE) bench Run speed tests" > + @echo " $(MAKE) check Run block, qapi-schema, unit, softfloat, qtest and decodetree tests" > + @echo " $(MAKE) bench Run speed tests" > @echo > @echo "Individual test suites:" > - @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target" > - @echo " $(MAKE) check-qtest Run qtest tests" > - @echo " $(MAKE) check-functional Run python-based functional tests" > - @echo " $(MAKE) check-functional-TARGET Run functional tests for a given target" > - @echo " $(MAKE) check-unit Run qobject tests" > - @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" > - @echo " $(MAKE) check-tracetool Run tracetool generator tests" > - @echo " $(MAKE) check-block Run block tests" > + @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target" > + @echo " $(MAKE) check-qtest Run qtest tests" > + @echo " $(MAKE) check-functional Run python-based functional tests" > + @echo " $(MAKE) check-functional-TARGET Run functional tests for a given target" > + @echo " $(MAKE) check-unit Run qobject tests" > + @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" > + @echo " $(MAKE) check-tracetool Run tracetool generator tests" > + @echo " $(MAKE) check-block Run block tests" > + @echo " $(MAKE) run-tcg-tests-TARGET-softmmu Run TCG tests for a given target" > ifneq ($(filter $(all-check-targets), check-softfloat),) > - @echo " $(MAKE) check-tcg Run TCG tests" > - @echo " $(MAKE) check-softfloat Run FPU emulation tests" > + @echo " $(MAKE) check-tcg Run TCG tests" Could you please move the new "run-tcg-tests..." line next to the check-tcg line, i.e. within the "ifneq" section? It's a subset of "check-tcg", i.e. TCG-based tests, so it does not make sense that we show this new line when QEMU has been configured with "--disable-tcg", but not the "check-tcg" line. Thanks, Thomas > + @echo " $(MAKE) check-softfloat Run FPU emulation tests" > endif > @echo > - @echo " $(MAKE) check-report.junit.xml Generates an aggregated XML test report" > - @echo " $(MAKE) check-venv Creates a Python venv for tests" > - @echo " $(MAKE) check-clean Clean the tests and related data" > + @echo " $(MAKE) check-report.junit.xml Generates an aggregated XML test report" > + @echo " $(MAKE) check-venv Creates a Python venv for tests" > + @echo " $(MAKE) check-clean Clean the tests and related data" > @echo > @echo "The following are useful for CI builds" > - @echo " $(MAKE) check-build Build most test binaries" > + @echo " $(MAKE) check-build Build most test binaries" > @echo > @echo > @echo "The variable SPEED can be set to control the gtester speed setting."
Thanks, Thomas! That makes sense, it should be a subset of check-tcg. I will amend it and resend the patch for review shortly. Best regards, Choon Keong. On Fri, Feb 6, 2026 at 10:53 PM Thomas Huth <thuth@redhat.com> wrote: > > > Hi! > > Thanks for your patch! A comment below... > > On 04/02/2026 02.46, ck wrote: > ... > > diff --git a/tests/Makefile.include b/tests/Makefile.include > > index 7728098981..5a99f0a920 100644 > > --- a/tests/Makefile.include > > +++ b/tests/Makefile.include > > @@ -3,29 +3,30 @@ > > .PHONY: check-help > > check-help: > > @echo "Regression testing targets:" > > - @echo " $(MAKE) check Run block, qapi-schema, unit, softfloat, qtest and decodetree tests" > > - @echo " $(MAKE) bench Run speed tests" > > + @echo " $(MAKE) check Run block, qapi-schema, unit, softfloat, qtest and decodetree tests" > > + @echo " $(MAKE) bench Run speed tests" > > @echo > > @echo "Individual test suites:" > > - @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target" > > - @echo " $(MAKE) check-qtest Run qtest tests" > > - @echo " $(MAKE) check-functional Run python-based functional tests" > > - @echo " $(MAKE) check-functional-TARGET Run functional tests for a given target" > > - @echo " $(MAKE) check-unit Run qobject tests" > > - @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" > > - @echo " $(MAKE) check-tracetool Run tracetool generator tests" > > - @echo " $(MAKE) check-block Run block tests" > > + @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target" > > + @echo " $(MAKE) check-qtest Run qtest tests" > > + @echo " $(MAKE) check-functional Run python-based functional tests" > > + @echo " $(MAKE) check-functional-TARGET Run functional tests for a given target" > > + @echo " $(MAKE) check-unit Run qobject tests" > > + @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" > > + @echo " $(MAKE) check-tracetool Run tracetool generator tests" > > + @echo " $(MAKE) check-block Run block tests" > > + @echo " $(MAKE) run-tcg-tests-TARGET-softmmu Run TCG tests for a given target" > > ifneq ($(filter $(all-check-targets), check-softfloat),) > > - @echo " $(MAKE) check-tcg Run TCG tests" > > - @echo " $(MAKE) check-softfloat Run FPU emulation tests" > > + @echo " $(MAKE) check-tcg Run TCG tests" > > Could you please move the new "run-tcg-tests..." line next to the check-tcg > line, i.e. within the "ifneq" section? It's a subset of "check-tcg", i.e. > TCG-based tests, so it does not make sense that we show this new line when > QEMU has been configured with "--disable-tcg", but not the "check-tcg" line. > > Thanks, > Thomas > > > > + @echo " $(MAKE) check-softfloat Run FPU emulation tests" > > endif > > @echo > > - @echo " $(MAKE) check-report.junit.xml Generates an aggregated XML test report" > > - @echo " $(MAKE) check-venv Creates a Python venv for tests" > > - @echo " $(MAKE) check-clean Clean the tests and related data" > > + @echo " $(MAKE) check-report.junit.xml Generates an aggregated XML test report" > > + @echo " $(MAKE) check-venv Creates a Python venv for tests" > > + @echo " $(MAKE) check-clean Clean the tests and related data" > > @echo > > @echo "The following are useful for CI builds" > > - @echo " $(MAKE) check-build Build most test binaries" > > + @echo " $(MAKE) check-build Build most test binaries" > > @echo > > @echo > > @echo "The variable SPEED can be set to control the gtester speed setting." >
© 2016 - 2026 Red Hat, Inc.