tests/.../reverse_debugging: Remove unsatisfiable condition

[PATCH] tests/.../reverse_debugging: Remove unsatisfiable condition

Yodel Eldar posted 1 patch 3 days, 10 hours ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260203182153.75276-1-yodel.eldar@yodel.dev

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>

tests/functional/reverse_debugging.py | 3 ---
1 file changed, 3 deletions(-)

Expand all Fold all

[PATCH] tests/.../reverse_debugging: Remove unsatisfiable condition

Posted by Yodel Eldar 3 days, 10 hours ago

get_qemu_img() already skips the test if qemu-img is not found and does
not return None. Eliminate the check for None on its result, and the
unreachable skipTest() gated by it.

Signed-off-by: Yodel Eldar <yodel.eldar@yodel.dev>
---
 tests/functional/reverse_debugging.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py
index 8e6f0b0e92..eaf178da49 100644
--- a/tests/functional/reverse_debugging.py
+++ b/tests/functional/reverse_debugging.py
@@ -73,9 +73,6 @@ def reverse_debugging(self, gdb_arch, shift=7, args=None, big_endian=False):
         self.log.info('creating qcow2 image for VM snapshots')
         image_path = os.path.join(self.workdir, 'disk.qcow2')
         qemu_img = get_qemu_img(self)
-        if qemu_img is None:
-            self.skipTest('Could not find "qemu-img", which is required to '
-                          'create the temporary qcow2 image')
         out = check_output([qemu_img, 'create', '-f', 'qcow2', image_path, '128M'],
                            encoding='utf8')
         self.log.info("qemu-img: %s" % out)
-- 
2.53.0

Re: [PATCH] tests/.../reverse_debugging: Remove unsatisfiable condition

Posted by Thomas Huth 3 days, 10 hours ago

On 03/02/2026 19.21, Yodel Eldar wrote:
> get_qemu_img() already skips the test if qemu-img is not found and does
> not return None. Eliminate the check for None on its result, and the
> unreachable skipTest() gated by it.
> 
> Signed-off-by: Yodel Eldar <yodel.eldar@yodel.dev>
> ---
>   tests/functional/reverse_debugging.py | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py
> index 8e6f0b0e92..eaf178da49 100644
> --- a/tests/functional/reverse_debugging.py
> +++ b/tests/functional/reverse_debugging.py
> @@ -73,9 +73,6 @@ def reverse_debugging(self, gdb_arch, shift=7, args=None, big_endian=False):
>           self.log.info('creating qcow2 image for VM snapshots')
>           image_path = os.path.join(self.workdir, 'disk.qcow2')
>           qemu_img = get_qemu_img(self)
> -        if qemu_img is None:
> -            self.skipTest('Could not find "qemu-img", which is required to '
> -                          'create the temporary qcow2 image')
>           out = check_output([qemu_img, 'create', '-f', 'qcow2', image_path, '128M'],
>                              encoding='utf8')
>           self.log.info("qemu-img: %s" % out)

Reviewed-by: Thomas Huth <thuth@redhat.com>