On 2/3/26 21:51, Alex Bennée wrote:
> Keep things tidy by moving the declarations to the block where they
> are used.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> gdbstub/user.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
>
> diff --git a/gdbstub/user.c b/gdbstub/user.c
> index cc71cda3e33..c7a3ef947ed 100644
> --- a/gdbstub/user.c
> +++ b/gdbstub/user.c
> @@ -198,9 +198,6 @@ void gdb_qemu_exit(int code)
> int gdb_handlesig(CPUState *cpu, int sig, const char *reason, void *siginfo,
> int siginfo_len)
> {
> - char buf[256];
> - int n;
> -
> if (!gdbserver_state.init || gdbserver_user_state.fd < 0) {
> return sig;
> }
> @@ -246,11 +243,10 @@ int gdb_handlesig(CPUState *cpu, int sig, const char *reason, void *siginfo,
> gdbserver_state.state = RS_IDLE;
> gdbserver_user_state.running_state = 0;
> while (gdbserver_user_state.running_state == 0) {
> - n = read(gdbserver_user_state.fd, buf, 256);
> + char buf[256];
> + int n = read(gdbserver_user_state.fd, buf, 256);
> if (n > 0) {
> - int i;
> -
> - for (i = 0; i < n; i++) {
> + for (int i = 0; i < n; i++) {
> gdb_read_byte(buf[i]);
> }
> } else {