[PATCH 10/11] include/gdbstub: fix typo

Alex Bennée posted 11 patches 6 days, 16 hours ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Laurent Vivier <laurent@vivier.eu>
[PATCH 10/11] include/gdbstub: fix typo
Posted by Alex Bennée 6 days, 16 hours ago
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 include/gdbstub/commands.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h
index bff3674872e..989a95c33f9 100644
--- a/include/gdbstub/commands.h
+++ b/include/gdbstub/commands.h
@@ -50,7 +50,7 @@ typedef union GdbCmdVariant {
  * '.' -> Skip 1 char unless reached "\0"
  * Any other value is treated as the delimiter value itself
  *
- * @allow_stop_reply: True iff the gdbstub can respond to this command with a
+ * @allow_stop_reply: True if the gdbstub can respond to this command with a
  * "stop reply" packet. The list of commands that accept such response is
  * defined at the GDB Remote Serial Protocol documentation. See:
  * https://sourceware.org/gdb/onlinedocs/gdb/Stop-Reply-Packets.html#Stop-Reply-Packets.
-- 
2.47.3


Re: [PATCH 10/11] include/gdbstub: fix typo
Posted by Peter Maydell 6 days, 15 hours ago
On Tue, 3 Feb 2026 at 11:52, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  include/gdbstub/commands.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h
> index bff3674872e..989a95c33f9 100644
> --- a/include/gdbstub/commands.h
> +++ b/include/gdbstub/commands.h
> @@ -50,7 +50,7 @@ typedef union GdbCmdVariant {
>   * '.' -> Skip 1 char unless reached "\0"
>   * Any other value is treated as the delimiter value itself
>   *
> - * @allow_stop_reply: True iff the gdbstub can respond to this command with a
> + * @allow_stop_reply: True if the gdbstub can respond to this command with a
>   * "stop reply" packet. The list of commands that accept such response is
>   * defined at the GDB Remote Serial Protocol documentation. See:
>   * https://sourceware.org/gdb/onlinedocs/gdb/Stop-Reply-Packets.html#Stop-Reply-Packets.

"iff" is not generally a typo: it is an abbreviation for "if and only if".
We tend to prefer not to use that abbreviation, though, because
unless you happen to have a background in mathematics you probably
won't recognise it.

In this case I don't think spelling out "if and only if" brings
us any more clarity than using a plain "if", so I'm OK with the
change itself and we can just tweak the commit message.

thanks
-- PMM