[PATCH v2 1/9] migration/options.c: Don't export migrate_tls_opts_free

Fabiano Rosas posted 9 patches 6 days, 12 hours ago
Maintainers: Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>
[PATCH v2 1/9] migration/options.c: Don't export migrate_tls_opts_free
Posted by Fabiano Rosas 6 days, 12 hours ago
The migrate_tls_opts_free function was never used outside
options.c. Make it static.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 migration/options.c | 2 +-
 migration/options.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/migration/options.c b/migration/options.c
index 1ffe85a2d8..dcd5e07504 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -1001,7 +1001,7 @@ AnnounceParameters *migrate_announce_params(void)
     return &ap;
 }
 
-void migrate_tls_opts_free(MigrationParameters *params)
+static void migrate_tls_opts_free(MigrationParameters *params)
 {
     qapi_free_StrOrNull(params->tls_creds);
     qapi_free_StrOrNull(params->tls_hostname);
diff --git a/migration/options.h b/migration/options.h
index b502871097..0c3043f1ff 100644
--- a/migration/options.h
+++ b/migration/options.h
@@ -92,5 +92,4 @@ ZeroPageDetection migrate_zero_page_detection(void);
 
 bool migrate_params_check(MigrationParameters *params, Error **errp);
 void migrate_params_init(MigrationParameters *params);
-void migrate_tls_opts_free(MigrationParameters *params);
 #endif
-- 
2.51.0
Re: [PATCH v2 1/9] migration/options.c: Don't export migrate_tls_opts_free
Posted by Peter Xu 3 days, 14 hours ago
On Mon, Feb 02, 2026 at 07:40:53PM -0300, Fabiano Rosas wrote:
> The migrate_tls_opts_free function was never used outside
> options.c. Make it static.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu