disas: Have disas_set_info() take a const CPUState

[PATCH 0/7] disas: Have disas_set_info() take a const CPUState

Philippe Mathieu-Daudé posted 7 patches 5 days, 18 hours ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260202222412.24923-1-philmd@linaro.org

Maintainers: Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <Alistair.Francis@wdc.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, Richard Henderson <richard.henderson@linaro.org>, Peter Maydell <peter.maydell@linaro.org>, Michael Rolnik <mrolnik@gmail.com>, Brian Cain <brian.cain@oss.qualcomm.com>, Helge Deller <deller@gmx.de>, Paolo Bonzini <pbonzini@redhat.com>, Song Gao <gaosong@loongson.cn>, Laurent Vivier <laurent@vivier.eu>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <arikalo@gmail.com>, Stafford Horne <shorne@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Yoshinori Sato <yoshinori.sato@nifty.com>, Thomas Huth <thuth@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>

disas/riscv.h             | 2 +-
include/disas/dis-asm.h   | 2 +-
include/hw/core/cpu.h     | 2 +-
target/arm/cpu-features.h | 2 +-
target/arm/cpu.h          | 6 +++---
disas/riscv.c             | 5 +++--
target/alpha/cpu.c        | 3 ++-
target/arm/cpu.c          | 6 +++---
target/avr/cpu.c          | 2 +-
target/hexagon/cpu.c      | 3 ++-
target/hppa/cpu.c         | 2 +-
target/i386/cpu.c         | 6 +++---
target/loongarch/cpu.c    | 3 ++-
target/m68k/cpu.c         | 2 +-
target/microblaze/cpu.c   | 2 +-
target/mips/cpu.c         | 7 +++++--
target/openrisc/cpu.c     | 2 +-
target/ppc/cpu_init.c     | 5 +++--
target/riscv/cpu.c        | 7 ++++---
target/rx/cpu.c           | 2 +-
target/s390x/cpu.c        | 2 +-
target/sh4/cpu.c          | 3 ++-
target/sparc/cpu.c        | 3 ++-
target/xtensa/cpu.c       | 3 ++-
24 files changed, 47 insertions(+), 35 deletions(-)

Expand all Fold all

[PATCH 0/7] disas: Have disas_set_info() take a const CPUState

Posted by Philippe Mathieu-Daudé 5 days, 18 hours ago

Have the CPUClass::disas_set_info() handler take a const
CPUState to be sure it is not modified. In order to do that,
first constify few callees (ARM & RISCV).

Philippe Mathieu-Daudé (7):
  target/arm: Have arm_feature() take a const @env argument
  target/arm: Have cpu_isar_feature() use a const ARMCPU object
  target/arm: Have is_64() take a const @env argument
  target/arm: Have arm_sctlr_b() take a const @env argument
  disas/riscv: Make rv_decode::cfg const
  disas: Make disassemble_info::target_info field const
  disas: Have disas_set_info() take a const CPUState

 disas/riscv.h             | 2 +-
 include/disas/dis-asm.h   | 2 +-
 include/hw/core/cpu.h     | 2 +-
 target/arm/cpu-features.h | 2 +-
 target/arm/cpu.h          | 6 +++---
 disas/riscv.c             | 5 +++--
 target/alpha/cpu.c        | 3 ++-
 target/arm/cpu.c          | 6 +++---
 target/avr/cpu.c          | 2 +-
 target/hexagon/cpu.c      | 3 ++-
 target/hppa/cpu.c         | 2 +-
 target/i386/cpu.c         | 6 +++---
 target/loongarch/cpu.c    | 3 ++-
 target/m68k/cpu.c         | 2 +-
 target/microblaze/cpu.c   | 2 +-
 target/mips/cpu.c         | 7 +++++--
 target/openrisc/cpu.c     | 2 +-
 target/ppc/cpu_init.c     | 5 +++--
 target/riscv/cpu.c        | 7 ++++---
 target/rx/cpu.c           | 2 +-
 target/s390x/cpu.c        | 2 +-
 target/sh4/cpu.c          | 3 ++-
 target/sparc/cpu.c        | 3 ++-
 target/xtensa/cpu.c       | 3 ++-
 24 files changed, 47 insertions(+), 35 deletions(-)

-- 
2.52.0

Re: [PATCH 0/7] disas: Have disas_set_info() take a const CPUState

Posted by Philippe Mathieu-Daudé 5 days, 1 hour ago

On 2/2/26 23:24, Philippe Mathieu-Daudé wrote:
> Have the CPUClass::disas_set_info() handler take a const
> CPUState to be sure it is not modified. In order to do that,
> first constify few callees (ARM & RISCV).
> 
> Philippe Mathieu-Daudé (7):
>    target/arm: Have arm_feature() take a const @env argument
>    target/arm: Have cpu_isar_feature() use a const ARMCPU object
>    target/arm: Have is_64() take a const @env argument
>    target/arm: Have arm_sctlr_b() take a const @env argument
>    disas/riscv: Make rv_decode::cfg const
>    disas: Make disassemble_info::target_info field const
>    disas: Have disas_set_info() take a const CPUState

Series queued, thanks.

Re: [PATCH 0/7] disas: Have disas_set_info() take a const CPUState

Posted by Richard Henderson 5 days, 13 hours ago

On 2/3/26 08:24, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (7):
>    target/arm: Have arm_feature() take a const @env argument
>    target/arm: Have cpu_isar_feature() use a const ARMCPU object
>    target/arm: Have is_64() take a const @env argument
>    target/arm: Have arm_sctlr_b() take a const @env argument
>    disas/riscv: Make rv_decode::cfg const
>    disas: Make disassemble_info::target_info field const
>    disas: Have disas_set_info() take a const CPUState

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~