Makefile: add python script dependency for meson-buildoptions.sh

[RFC PATCH] Makefile: add python script dependency for meson-buildoptions.sh

Alex Bennée posted 1 patch 4 days, 9 hours ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260202174849.1949691-1-alex.bennee@linaro.org

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>

Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[RFC PATCH] Makefile: add python script dependency for meson-buildoptions.sh

Posted by Alex Bennée 4 days, 9 hours ago

If we update the script we should also make sure we regenerate the
help text.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 9fb55dcf330..54547a37b1a 100644
--- a/Makefile
+++ b/Makefile
@@ -130,7 +130,7 @@ Makefile.mtest: build.ninja scripts/mtest2make.py
 
 .PHONY: update-buildoptions
 all update-buildoptions: $(SRC_PATH)/scripts/meson-buildoptions.sh
-$(SRC_PATH)/scripts/meson-buildoptions.sh: $(SRC_PATH)/meson_options.txt
+$(SRC_PATH)/scripts/meson-buildoptions.sh: $(SRC_PATH)/meson_options.txt $(SRC_PATH)/scripts/meson-buildoptions.py
 	$(MESON) introspect --buildoptions $(SRC_PATH)/meson.build | $(PYTHON) \
 	  scripts/meson-buildoptions.py > $@.tmp && mv $@.tmp $@
 endif
-- 
2.47.3

Re: [RFC PATCH] Makefile: add python script dependency for meson-buildoptions.sh

Posted by Paolo Bonzini 4 days, 9 hours ago

On 2/2/26 18:48, Alex Bennée wrote:
> If we update the script we should also make sure we regenerate the
> help text.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Yes, this is correct.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 9fb55dcf330..54547a37b1a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -130,7 +130,7 @@ Makefile.mtest: build.ninja scripts/mtest2make.py
>   
>   .PHONY: update-buildoptions
>   all update-buildoptions: $(SRC_PATH)/scripts/meson-buildoptions.sh
> -$(SRC_PATH)/scripts/meson-buildoptions.sh: $(SRC_PATH)/meson_options.txt
> +$(SRC_PATH)/scripts/meson-buildoptions.sh: $(SRC_PATH)/meson_options.txt $(SRC_PATH)/scripts/meson-buildoptions.py
>   	$(MESON) introspect --buildoptions $(SRC_PATH)/meson.build | $(PYTHON) \
>   	  scripts/meson-buildoptions.py > $@.tmp && mv $@.tmp $@
>   endif