qmp: Fix a typo for GSO over UDP features

[PATCH] qmp: Fix a typo for GSO over UDP features

Posted by Laurent Vivier 1 week, 4 days ago

The description of VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM feature
was missing the _CSUM.

Fixes: a76f5b795cab ("qmp: update virtio features map to support extended features")
Cc: pabeni@redhat.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 hw/virtio/virtio-qmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
index 968299fda0c9..45ca40ca50f8 100644
--- a/hw/virtio/virtio-qmp.c
+++ b/hw/virtio/virtio-qmp.c
@@ -329,7 +329,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
             "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO: Driver can receive GSO over "
             "UDP tunnel packets"),
     FEATURE_ENTRY(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM, \
-            "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO: Driver can receive GSO over "
+            "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM: Driver can receive GSO over "
             "UDP tunnel packets requiring checksum offload for the outer "
             "header"),
     FEATURE_ENTRY(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO, \
-- 
2.52.0

Re: [PATCH] qmp: Fix a typo for GSO over UDP features

Posted by Paolo Abeni 1 week, 4 days ago


On 1/28/26 5:24 PM, Laurent Vivier wrote:
> The description of VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM feature
> was missing the _CSUM.
> 
> Fixes: a76f5b795cab ("qmp: update virtio features map to support extended features")
> Cc: pabeni@redhat.com
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  hw/virtio/virtio-qmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> index 968299fda0c9..45ca40ca50f8 100644
> --- a/hw/virtio/virtio-qmp.c
> +++ b/hw/virtio/virtio-qmp.c
> @@ -329,7 +329,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
>              "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO: Driver can receive GSO over "
>              "UDP tunnel packets"),
>      FEATURE_ENTRY(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM, \
> -            "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO: Driver can receive GSO over "
> +            "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM: Driver can receive GSO over "
>              "UDP tunnel packets requiring checksum offload for the outer "
>              "header"),
>      FEATURE_ENTRY(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO, \

LGTM, thanks!

Acked-by: Paolo Abeni <pabeni@redhat.com>

Side note, I lost track of this patch:

https://patchew.org/QEMU/745e4b9ff93b27b4464d039d2ca24a9020f2c32f.1760103753.git.pabeni@redhat.com/

which would address the above and prevent similar errors in the future.
AFAICS is sitting in patchew since 3m. Should I consider that one dropped?

/P

Re: [PATCH] qmp: Fix a typo for GSO over UDP features

Posted by Laurent Vivier 1 week, 4 days ago

On 1/28/26 17:39, Paolo Abeni wrote:
> 
> 
> On 1/28/26 5:24 PM, Laurent Vivier wrote:
>> The description of VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM feature
>> was missing the _CSUM.
>>
>> Fixes: a76f5b795cab ("qmp: update virtio features map to support extended features")
>> Cc: pabeni@redhat.com
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>>   hw/virtio/virtio-qmp.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
>> index 968299fda0c9..45ca40ca50f8 100644
>> --- a/hw/virtio/virtio-qmp.c
>> +++ b/hw/virtio/virtio-qmp.c
>> @@ -329,7 +329,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
>>               "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO: Driver can receive GSO over "
>>               "UDP tunnel packets"),
>>       FEATURE_ENTRY(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM, \
>> -            "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO: Driver can receive GSO over "
>> +            "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM: Driver can receive GSO over "
>>               "UDP tunnel packets requiring checksum offload for the outer "
>>               "header"),
>>       FEATURE_ENTRY(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO, \
> 
> LGTM, thanks!
> 
> Acked-by: Paolo Abeni <pabeni@redhat.com>
> 
> Side note, I lost track of this patch:
> 
> https://patchew.org/QEMU/745e4b9ff93b27b4464d039d2ca24a9020f2c32f.1760103753.git.pabeni@redhat.com/
> 
> which would address the above and prevent similar errors in the future.
> AFAICS is sitting in patchew since 3m. Should I consider that one dropped?
> 

I agree, I was thinking at doing the same change.

Thanks,
Laurent