hw/ide, scsi-disk: Fix typo on the rotation_rate documentation

[PATCH] hw/ide, scsi-disk: Fix typo on the rotation_rate documentation

Alberto Garcia posted 1 patch 1 week, 2 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260128102548.224237-1-berto@igalia.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>, John Snow <jsnow@redhat.com>

hw/scsi/scsi-disk.c      | 2 +-
include/hw/ide/ide-dev.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] hw/ide, scsi-disk: Fix typo on the rotation_rate documentation

Posted by Alberto Garcia 1 week, 2 days ago

Correct values according to the Medium Rotation Rate field from the
Block Device Characteristics VPD page (B1h) of the SCSI specification.

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 hw/scsi/scsi-disk.c      | 2 +-
 include/hw/ide/ide-dev.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 0f896c27f4..db7d04119e 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -117,7 +117,7 @@ struct SCSIDiskState {
      * 0x0000        - rotation rate not reported
      * 0x0001        - non-rotating medium (SSD)
      * 0x0002-0x0400 - reserved
-     * 0x0401-0xffe  - rotations per minute
+     * 0x0401-0xfffe - rotations per minute
      * 0xffff        - reserved
      */
     uint16_t rotation_rate;
diff --git a/include/hw/ide/ide-dev.h b/include/hw/ide/ide-dev.h
index 617e8159c7..f5eaaf68e6 100644
--- a/include/hw/ide/ide-dev.h
+++ b/include/hw/ide/ide-dev.h
@@ -160,7 +160,7 @@ struct IDEDevice {
      * 0x0000        - rotation rate not reported
      * 0x0001        - non-rotating medium (SSD)
      * 0x0002-0x0400 - reserved
-     * 0x0401-0xffe  - rotations per minute
+     * 0x0401-0xfffe - rotations per minute
      * 0xffff        - reserved
      */
     uint16_t rotation_rate;
-- 
2.47.3

Re: [PATCH] hw/ide, scsi-disk: Fix typo on the rotation_rate documentation

Posted by Philippe Mathieu-Daudé 5 days, 17 hours ago

On 28/1/26 11:25, Alberto Garcia wrote:
> Correct values according to the Medium Rotation Rate field from the
> Block Device Characteristics VPD page (B1h) of the SCSI specification.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>   hw/scsi/scsi-disk.c      | 2 +-
>   include/hw/ide/ide-dev.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>