migration: small cleanup series

[PATCH v2 11/24] migration: Drop qemu_file_set_error() when save non-iterable fails

Posted by Peter Xu 1 week, 5 days ago

All users of qemu_savevm_state_complete_precopy_non_iterable() process
return values.  There's no need to set error on qemufile (which we likely
should remove gradually across the tree).  Remove it for possible code
dedup to happen later.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/savevm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/migration/savevm.c b/migration/savevm.c
index da9a60c73f..9d2109718a 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1688,7 +1688,6 @@ int qemu_savevm_state_complete_precopy_non_iterable(QEMUFile *f,
         if (ret) {
             migrate_error_propagate(ms, error_copy(local_err));
             error_report_err(local_err);
-            qemu_file_set_error(f, ret);
             return ret;
         }
 
-- 
2.50.1

Re: [PATCH v2 11/24] migration: Drop qemu_file_set_error() when save non-iterable fails

Posted by Fabiano Rosas 1 week, 4 days ago

Peter Xu <peterx@redhat.com> writes:

> All users of qemu_savevm_state_complete_precopy_non_iterable() process
> return values.  There's no need to set error on qemufile (which we likely
> should remove gradually across the tree).  Remove it for possible code
> dedup to happen later.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  migration/savevm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index da9a60c73f..9d2109718a 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1688,7 +1688,6 @@ int qemu_savevm_state_complete_precopy_non_iterable(QEMUFile *f,
>          if (ret) {
>              migrate_error_propagate(ms, error_copy(local_err));
>              error_report_err(local_err);
> -            qemu_file_set_error(f, ret);
>              return ret;
>          }

Reviewed-by: Fabiano Rosas <farosas@suse.de>