After the previous commit introducing GICv3 + GICv2m configurations,
update the AArch64 ACPI tables for the GICv2 case.
Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
---
tests/data/acpi/aarch64/virt/IORT | Bin 128 -> 84 bytes
tests/data/acpi/aarch64/virt/IORT.smmuv3-dev | Bin 364 -> 260 bytes
tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy | Bin 276 -> 192 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
4 files changed, 3 deletions(-)
diff --git a/tests/data/acpi/aarch64/virt/IORT b/tests/data/acpi/aarch64/virt/IORT
index 7efd0ce8a6b3928efa7e1373f688ab4c5f50543b..9cce77cacdda976f64eabcc7213646af25cb93eb 100644
GIT binary patch
delta 42
ocmZo*4B_(h4+;rkU|?Xjo5&?4$_Qi`05J$KsW32u850Ag0fA@))Bpeg
literal 128
zcmebD4+?2uU|?Y0?Bwt45v<@85#X!<1dKp25F11@0kHuPgMkDCNC*yK93~3}W)K^M
VRiHGGVg_O`aDdYP|3ers^8jQz3IPBB
diff --git a/tests/data/acpi/aarch64/virt/IORT.smmuv3-dev b/tests/data/acpi/aarch64/virt/IORT.smmuv3-dev
index 67be268f62afbf2d9459540984da5e9340afdaaa..604121e2b25532351b5bd454b832a9f3f923ddb9 100644
GIT binary patch
delta 107
zcmaFE)WXE&=^qrr!pOkD>^+f7N|Kp@fx!TXL4d`Dfd#?>k`qJCc|ig|l@Ks-tvM%?
f4+Aq3kjpfgkx^X+rjJ2@f#E+$5s)r{C}scvit`FW
literal 364
zcmebD4+_a)WME)E<>c?|5v<@85#X!<1VAAM5F13Z0I>lOgMkDCNC*yK9F_<M77!bR
zT_CbNAPOcA5rU8tfYd}Fo(#m3AVP5R|9=P*W*^90CZG_)Tqd06P64W$3dGZacp4BR
z19WqlN*I`#feJu=QvqVAJ3&HV-~grnLnS<*d<Fpq2Cx%>^a7X|(1HJXfgB(Wb2oz^
MQ0yI03`oPo01?F*0RR91
diff --git a/tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy b/tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy
index 41981a449fc306b80cccd87ddec3c593a8d72c07..a0df7fcc4e084a97a6ce7ffd305bd38b4fee984b 100644
GIT binary patch
delta 74
zcmbQjbbyh|(?2NW00RR9v)n{3DM=<E%K(T$fW?J@1;PT76GP28nS2<S8G&r3i7V9^
M4JKX`=71>$0E<}(h5!Hn
literal 276
zcmX|*K@NgI3`M`puy8?wi3^u3IDkhWzycE!jI!Vis5{Ti6^7s1@{>QmeVugXHa@5G
z0SNbY?1op>&X2C5h#<9Ops%#*0ztdHi8G?q;$EluQNrhn>{ys@`b&R|d8G8O{Jrdl
mkP$_?rfr{mN!3^;8w}Q?1auX1XIzvDUSRruoXA!(rn3!nx)K2Z
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 7acaf464dd..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,4 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/aarch64/virt/IORT",
-"tests/data/acpi/aarch64/virt/IORT.smmuv3-dev",
-"tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy",
--
2.50.1 (Apple Git-155)On Tue, 27 Jan 2026 at 18:28, Mohamed Mediouni <mohamed@unpredictable.fr> wrote: > > After the previous commit introducing GICv3 + GICv2m configurations, > update the AArch64 ACPI tables for the GICv2 case. > > Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr> > --- > tests/data/acpi/aarch64/virt/IORT | Bin 128 -> 84 bytes > tests/data/acpi/aarch64/virt/IORT.smmuv3-dev | Bin 364 -> 260 bytes > tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy | Bin 276 -> 192 bytes > tests/qtest/bios-tables-test-allowed-diff.h | 3 --- > 4 files changed, 3 deletions(-) The process documented in tests/qtest/bios-tables-test.c says that this commit is supposed to have the diff of the disassembled table data in the commit message, so that human reviewers can confirm that the changes are as expected. (If you git log tests/data/acpi you can see how this looks.) Can you provide the ASL diff, please? (If this is going to be the only fix needed to this version of the series, which I hope it will be, then I can update the commit message as I apply the series, so you don't need to respin, just reply with the updated commit message with the diff in it.) thanks -- PMM
> On 29. Jan 2026, at 14:36, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Tue, 27 Jan 2026 at 18:28, Mohamed Mediouni <mohamed@unpredictable.fr> wrote: >> >> After the previous commit introducing GICv3 + GICv2m configurations, >> update the AArch64 ACPI tables for the GICv2 case. >> >> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr> >> --- >> tests/data/acpi/aarch64/virt/IORT | Bin 128 -> 84 bytes >> tests/data/acpi/aarch64/virt/IORT.smmuv3-dev | Bin 364 -> 260 bytes >> tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy | Bin 276 -> 192 bytes >> tests/qtest/bios-tables-test-allowed-diff.h | 3 --- >> 4 files changed, 3 deletions(-) > > The process documented in tests/qtest/bios-tables-test.c says > that this commit is supposed to have the diff of the disassembled > table data in the commit message, so that human reviewers can > confirm that the changes are as expected. (If you git log > tests/data/acpi you can see how this looks.) > > Can you provide the ASL diff, please? (If this is going to be the > only fix needed to this version of the series, which I hope it > will be, then I can update the commit message as I apply the > series, so you don't need to respin, just reply with the updated > commit message with the diff in it.) > > thanks > — PMM Hi, Here’s the expected asl diff: diff otp/tests/data/acpi/aarch64/virt/IORT.dsl otp2/tests/data/acpi/aarch64/virt/IORT.dsl 14c14 < [004h 0004 004h] Table Length : 00000080 --- > [004h 0004 004h] Table Length : 00000054 16c16 < [009h 0009 001h] Checksum : B3 --- > [009h 0009 001h] Checksum : 3E 23c23 < [024h 0036 004h] Node Count : 00000002 --- > [024h 0036 004h] Node Count : 00000001 27,29c27,29 < [030h 0048 001h] Type : 00 < [031h 0049 002h] Length : 0018 < [033h 0051 001h] Revision : 01 --- > [030h 0048 001h] Type : 02 > [031h 0049 002h] Length : 0024 > [033h 0051 001h] Revision : 03 32c32 < [03Ch 0060 004h] Mapping Offset : 00000000 --- > [03Ch 0060 004h] Mapping Offset : 00000024 34,46c34,36 < [040h 0064 004h] ItsCount : 00000001 < [044h 0068 004h] Identifiers : 00000000 < < [048h 0072 001h] Type : 02 < [049h 0073 002h] Length : 0038 < [04Bh 0075 001h] Revision : 03 < [04Ch 0076 004h] Identifier : 00000001 < [050h 0080 004h] Mapping Count : 00000001 < [054h 0084 004h] Mapping Offset : 00000024 < < [058h 0088 008h] Memory Properties : [IORT Memory Access Properties] < [058h 0088 004h] Cache Coherency : 00000001 < [05Ch 0092 001h] Hints (decoded below) : 00 --- > [040h 0064 008h] Memory Properties : [IORT Memory Access Properties] > [040h 0064 004h] Cache Coherency : 00000001 > [044h 0068 001h] Hints (decoded below) : 00 51,52c41,42 < [05Dh 0093 002h] Reserved : 0000 < [05Fh 0095 001h] Memory Flags (decoded below) : 03 --- > [045h 0069 002h] Reserved : 0000 > [047h 0071 001h] Memory Flags (decoded below) : 03 56,60c46,50 < [060h 0096 004h] ATS Attribute : 00000000 < [064h 0100 004h] PCI Segment Number : 00000000 < [068h 0104 001h] Memory Size Limit : 40 < [069h 0105 002h] PASID Capabilities : 0000 < [06Bh 0107 001h] Reserved : 00 --- > [048h 0072 004h] ATS Attribute : 00000000 > [04Ch 0076 004h] PCI Segment Number : 00000000 > [050h 0080 001h] Memory Size Limit : 40 > [051h 0081 002h] PASID Capabilities : 0000 > [053h 0083 001h] Reserved : 00 62,67c52 < [06Ch 0108 004h] Input base : 00000000 < [070h 0112 004h] ID Count : 0000FFFF < [074h 0116 004h] Output Base : 00000000 < [078h 0120 004h] Output Reference : 00000030 < [07Ch 0124 004h] Flags (decoded below) : 00000000 < Single Mapping : 0 --- > Raw Table Data: Length 84 (0x54) 69,71c54 < Raw Table Data: Length 128 (0x80) < < 0000: 49 4F 52 54 80 00 00 00 03 B3 42 4F 43 48 53 20 // IORT......BOCHS --- > 0000: 49 4F 52 54 54 00 00 00 03 3E 42 4F 43 48 53 20 // IORTT....>BOCHS 73,78c56,59 < 0020: 01 00 00 00 02 00 00 00 30 00 00 00 00 00 00 00 // ........0....... < 0030: 00 18 00 01 00 00 00 00 00 00 00 00 00 00 00 00 // ................ < 0040: 01 00 00 00 00 00 00 00 02 38 00 03 01 00 00 00 // .........8...... < 0050: 01 00 00 00 24 00 00 00 01 00 00 00 00 00 00 03 // ....$........... < 0060: 00 00 00 00 00 00 00 00 40 00 00 00 00 00 00 00 // ........@....... < 0070: FF FF 00 00 00 00 00 00 30 00 00 00 00 00 00 00 // ........0....... --- > 0020: 01 00 00 00 01 00 00 00 30 00 00 00 00 00 00 00 // ........0....... > 0030: 02 24 00 03 00 00 00 00 00 00 00 00 24 00 00 00 // .$..........$... > 0040: 01 00 00 00 00 00 00 03 00 00 00 00 00 00 00 00 // ................ > 0050: 40 00 00 00 // @... diff otp/tests/data/acpi/aarch64/virt/IORT.smmuv3-dev.dsl otp2/tests/data/acpi/aarch64/virt/IORT.smmuv3-dev.dsl 14c14 < [004h 0004 004h] Table Length : 0000016C --- > [004h 0004 004h] Table Length : 00000104 16c16 < [009h 0009 001h] Checksum : CA --- > [009h 0009 001h] Checksum : 4B 23c23 < [024h 0036 004h] Node Count : 00000004 --- > [024h 0036 004h] Node Count : 00000003 27,29c27,29 < [030h 0048 001h] Type : 00 < [031h 0049 002h] Length : 0018 < [033h 0051 001h] Revision : 01 --- > [030h 0048 001h] Type : 04 > [031h 0049 002h] Length : 0044 > [033h 0051 001h] Revision : 04 34,45c34,35 < [040h 0064 004h] ItsCount : 00000001 < [044h 0068 004h] Identifiers : 00000000 < < [048h 0072 001h] Type : 04 < [049h 0073 002h] Length : 0058 < [04Bh 0075 001h] Revision : 04 < [04Ch 0076 004h] Identifier : 00000001 < [050h 0080 004h] Mapping Count : 00000001 < [054h 0084 004h] Mapping Offset : 00000044 < < [058h 0088 008h] Base Address : 000000000C000000 < [060h 0096 004h] Flags (decoded below) : 00000001 --- > [040h 0064 008h] Base Address : 000000000C000000 > [048h 0072 004h] Flags (decoded below) : 00000001 50,58c40,48 < [064h 0100 004h] Reserved : 00000000 < [068h 0104 008h] VATOS Address : 0000000000000000 < [070h 0112 004h] Model : 00000000 < [074h 0116 004h] Event GSIV : 00000090 < [078h 0120 004h] PRI GSIV : 00000091 < [07Ch 0124 004h] GERR GSIV : 00000093 < [080h 0128 004h] Sync GSIV : 00000092 < [084h 0132 004h] Proximity Domain : 00000000 < [088h 0136 004h] Device ID Mapping Index : 00000000 --- > [04Ch 0076 004h] Reserved : 00000000 > [050h 0080 008h] VATOS Address : 0000000000000000 > [058h 0088 004h] Model : 00000000 > [05Ch 0092 004h] Event GSIV : 00000090 > [060h 0096 004h] PRI GSIV : 00000091 > [064h 0100 004h] GERR GSIV : 00000093 > [068h 0104 004h] Sync GSIV : 00000092 > [06Ch 0108 004h] Proximity Domain : 00000000 > [070h 0112 004h] Device ID Mapping Index : 00000000 60,65c50,55 < [08Ch 0140 004h] Input base : 00000000 < [090h 0144 004h] ID Count : 0000FFFF < [094h 0148 004h] Output Base : 00000000 < [098h 0152 004h] Output Reference : 00000030 < [09Ch 0156 004h] Flags (decoded below) : 00000000 < Single Mapping : 0 --- > [074h 0116 001h] Type : 04 > [075h 0117 002h] Length : 0044 > [077h 0119 001h] Revision : 04 > [078h 0120 004h] Identifier : 00000001 > [07Ch 0124 004h] Mapping Count : 00000000 > [080h 0128 004h] Mapping Offset : 00000000 67,75c57,58 < [0A0h 0160 001h] Type : 04 < [0A1h 0161 002h] Length : 0058 < [0A3h 0163 001h] Revision : 04 < [0A4h 0164 004h] Identifier : 00000002 < [0A8h 0168 004h] Mapping Count : 00000001 < [0ACh 0172 004h] Mapping Offset : 00000044 < < [0B0h 0176 008h] Base Address : 000000000C020000 < [0B8h 0184 004h] Flags (decoded below) : 00000001 --- > [084h 0132 008h] Base Address : 000000000C020000 > [08Ch 0140 004h] Flags (decoded below) : 00000001 80,88c63,71 < [0BCh 0188 004h] Reserved : 00000000 < [0C0h 0192 008h] VATOS Address : 0000000000000000 < [0C8h 0200 004h] Model : 00000000 < [0CCh 0204 004h] Event GSIV : 00000094 < [0D0h 0208 004h] PRI GSIV : 00000095 < [0D4h 0212 004h] GERR GSIV : 00000097 < [0D8h 0216 004h] Sync GSIV : 00000096 < [0DCh 0220 004h] Proximity Domain : 00000000 < [0E0h 0224 004h] Device ID Mapping Index : 00000000 --- > [090h 0144 004h] Reserved : 00000000 > [094h 0148 008h] VATOS Address : 0000000000000000 > [09Ch 0156 004h] Model : 00000000 > [0A0h 0160 004h] Event GSIV : 00000094 > [0A4h 0164 004h] PRI GSIV : 00000095 > [0A8h 0168 004h] GERR GSIV : 00000097 > [0ACh 0172 004h] Sync GSIV : 00000096 > [0B0h 0176 004h] Proximity Domain : 00000000 > [0B4h 0180 004h] Device ID Mapping Index : 00000000 90,95c73,78 < [0E4h 0228 004h] Input base : 00000000 < [0E8h 0232 004h] ID Count : 0000FFFF < [0ECh 0236 004h] Output Base : 00000000 < [0F0h 0240 004h] Output Reference : 00000030 < [0F4h 0244 004h] Flags (decoded below) : 00000000 < Single Mapping : 0 --- > [0B8h 0184 001h] Type : 02 > [0B9h 0185 002h] Length : 004C > [0BBh 0187 001h] Revision : 03 > [0BCh 0188 004h] Identifier : 00000002 > [0C0h 0192 004h] Mapping Count : 00000002 > [0C4h 0196 004h] Mapping Offset : 00000024 97,106c80,82 < [0F8h 0248 001h] Type : 02 < [0F9h 0249 002h] Length : 0074 < [0FBh 0251 001h] Revision : 03 < [0FCh 0252 004h] Identifier : 00000003 < [100h 0256 004h] Mapping Count : 00000004 < [104h 0260 004h] Mapping Offset : 00000024 < < [108h 0264 008h] Memory Properties : [IORT Memory Access Properties] < [108h 0264 004h] Cache Coherency : 00000001 < [10Ch 0268 001h] Hints (decoded below) : 00 --- > [0C8h 0200 008h] Memory Properties : [IORT Memory Access Properties] > [0C8h 0200 004h] Cache Coherency : 00000001 > [0CCh 0204 001h] Hints (decoded below) : 00 111,112c87,88 < [10Dh 0269 002h] Reserved : 0000 < [10Fh 0271 001h] Memory Flags (decoded below) : 03 --- > [0CDh 0205 002h] Reserved : 0000 > [0CFh 0207 001h] Memory Flags (decoded below) : 03 116,120c92,96 < [110h 0272 004h] ATS Attribute : 00000000 < [114h 0276 004h] PCI Segment Number : 00000000 < [118h 0280 001h] Memory Size Limit : 40 < [119h 0281 002h] PASID Capabilities : 0000 < [11Bh 0283 001h] Reserved : 00 --- > [0D0h 0208 004h] ATS Attribute : 00000000 > [0D4h 0212 004h] PCI Segment Number : 00000000 > [0D8h 0216 001h] Memory Size Limit : 40 > [0D9h 0217 002h] PASID Capabilities : 0000 > [0DBh 0219 001h] Reserved : 00 122,126c98,102 < [11Ch 0284 004h] Input base : 00000000 < [120h 0288 004h] ID Count : 000001FF < [124h 0292 004h] Output Base : 00000000 < [128h 0296 004h] Output Reference : 00000048 < [12Ch 0300 004h] Flags (decoded below) : 00000000 --- > [0DCh 0220 004h] Input base : 00000000 > [0E0h 0224 004h] ID Count : 000001FF > [0E4h 0228 004h] Output Base : 00000000 > [0E8h 0232 004h] Output Reference : 00000030 > [0ECh 0236 004h] Flags (decoded below) : 00000000 129,133c105,109 < [130h 0304 004h] Input base : 00001000 < [134h 0308 004h] ID Count : 000000FF < [138h 0312 004h] Output Base : 00001000 < [13Ch 0316 004h] Output Reference : 000000A0 < [140h 0320 004h] Flags (decoded below) : 00000000 --- > [0F0h 0240 004h] Input base : 00001000 > [0F4h 0244 004h] ID Count : 000000FF > [0F8h 0248 004h] Output Base : 00001000 > [0FCh 0252 004h] Output Reference : 00000074 > [100h 0256 004h] Flags (decoded below) : 00000000 136,141c112 < [144h 0324 004h] Input base : 00000200 < [148h 0328 004h] ID Count : 00000DFF < [14Ch 0332 004h] Output Base : 00000200 < [150h 0336 004h] Output Reference : 00000030 < [154h 0340 004h] Flags (decoded below) : 00000000 < Single Mapping : 0 --- > Raw Table Data: Length 260 (0x104) 143,152c114 < [158h 0344 004h] Input base : 00001100 < [15Ch 0348 004h] ID Count : 0000EEFF < [160h 0352 004h] Output Base : 00001100 < [164h 0356 004h] Output Reference : 00000030 < [168h 0360 004h] Flags (decoded below) : 00000000 < Single Mapping : 0 < < Raw Table Data: Length 364 (0x16C) < < 0000: 49 4F 52 54 6C 01 00 00 03 CA 42 4F 43 48 53 20 // IORTl.....BOCHS --- > 0000: 49 4F 52 54 04 01 00 00 03 4B 42 4F 43 48 53 20 // IORT.....KBOCHS 154,174c116,130 < 0020: 01 00 00 00 04 00 00 00 30 00 00 00 00 00 00 00 // ........0....... < 0030: 00 18 00 01 00 00 00 00 00 00 00 00 00 00 00 00 // ................ < 0040: 01 00 00 00 00 00 00 00 04 58 00 04 01 00 00 00 // .........X...... < 0050: 01 00 00 00 44 00 00 00 00 00 00 0C 00 00 00 00 // ....D........... < 0060: 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ................ < 0070: 00 00 00 00 90 00 00 00 91 00 00 00 93 00 00 00 // ................ < 0080: 92 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ................ < 0090: FF FF 00 00 00 00 00 00 30 00 00 00 00 00 00 00 // ........0....... < 00A0: 04 58 00 04 02 00 00 00 01 00 00 00 44 00 00 00 // .X..........D... < 00B0: 00 00 02 0C 00 00 00 00 01 00 00 00 00 00 00 00 // ................ < 00C0: 00 00 00 00 00 00 00 00 00 00 00 00 94 00 00 00 // ................ < 00D0: 95 00 00 00 97 00 00 00 96 00 00 00 00 00 00 00 // ................ < 00E0: 00 00 00 00 00 00 00 00 FF FF 00 00 00 00 00 00 // ................ < 00F0: 30 00 00 00 00 00 00 00 02 74 00 03 03 00 00 00 // 0........t...... < 0100: 04 00 00 00 24 00 00 00 01 00 00 00 00 00 00 03 // ....$........... < 0110: 00 00 00 00 00 00 00 00 40 00 00 00 00 00 00 00 // ........@....... < 0120: FF 01 00 00 00 00 00 00 48 00 00 00 00 00 00 00 // ........H....... < 0130: 00 10 00 00 FF 00 00 00 00 10 00 00 A0 00 00 00 // ................ < 0140: 00 00 00 00 00 02 00 00 FF 0D 00 00 00 02 00 00 // ................ < 0150: 30 00 00 00 00 00 00 00 00 11 00 00 FF EE 00 00 // 0............... < 0160: 00 11 00 00 30 00 00 00 00 00 00 00 // ....0....... --- > 0020: 01 00 00 00 03 00 00 00 30 00 00 00 00 00 00 00 // ........0....... > 0030: 04 44 00 04 00 00 00 00 00 00 00 00 00 00 00 00 // .D.............. > 0040: 00 00 00 0C 00 00 00 00 01 00 00 00 00 00 00 00 // ................ > 0050: 00 00 00 00 00 00 00 00 00 00 00 00 90 00 00 00 // ................ > 0060: 91 00 00 00 93 00 00 00 92 00 00 00 00 00 00 00 // ................ > 0070: 00 00 00 00 04 44 00 04 01 00 00 00 00 00 00 00 // .....D.......... > 0080: 00 00 00 00 00 00 02 0C 00 00 00 00 01 00 00 00 // ................ > 0090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ................ > 00A0: 94 00 00 00 95 00 00 00 97 00 00 00 96 00 00 00 // ................ > 00B0: 00 00 00 00 00 00 00 00 02 4C 00 03 02 00 00 00 // .........L...... > 00C0: 02 00 00 00 24 00 00 00 01 00 00 00 00 00 00 03 // ....$........... > 00D0: 00 00 00 00 00 00 00 00 40 00 00 00 00 00 00 00 // ........@....... > 00E0: FF 01 00 00 00 00 00 00 30 00 00 00 00 00 00 00 // ........0....... > 00F0: 00 10 00 00 FF 00 00 00 00 10 00 00 74 00 00 00 // ............t... > 0100: 00 00 00 00 // .... diff otp/tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy.dsl otp2/tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy.dsl 14c14 < [004h 0004 004h] Table Length : 00000114 --- > [004h 0004 004h] Table Length : 000000C0 16c16 < [009h 0009 001h] Checksum : 4C --- > [009h 0009 001h] Checksum : 1E 23c23 < [024h 0036 004h] Node Count : 00000003 --- > [024h 0036 004h] Node Count : 00000002 27,29c27,29 < [030h 0048 001h] Type : 00 < [031h 0049 002h] Length : 0018 < [033h 0051 001h] Revision : 01 --- > [030h 0048 001h] Type : 04 > [031h 0049 002h] Length : 0044 > [033h 0051 001h] Revision : 04 34,45c34,35 < [040h 0064 004h] ItsCount : 00000001 < [044h 0068 004h] Identifiers : 00000000 < < [048h 0072 001h] Type : 04 < [049h 0073 002h] Length : 0058 < [04Bh 0075 001h] Revision : 04 < [04Ch 0076 004h] Identifier : 00000001 < [050h 0080 004h] Mapping Count : 00000001 < [054h 0084 004h] Mapping Offset : 00000044 < < [058h 0088 008h] Base Address : 0000000009050000 < [060h 0096 004h] Flags (decoded below) : 00000001 --- > [040h 0064 008h] Base Address : 0000000009050000 > [048h 0072 004h] Flags (decoded below) : 00000001 50,58c40,48 < [064h 0100 004h] Reserved : 00000000 < [068h 0104 008h] VATOS Address : 0000000000000000 < [070h 0112 004h] Model : 00000000 < [074h 0116 004h] Event GSIV : 0000006A < [078h 0120 004h] PRI GSIV : 0000006B < [07Ch 0124 004h] GERR GSIV : 0000006D < [080h 0128 004h] Sync GSIV : 0000006C < [084h 0132 004h] Proximity Domain : 00000000 < [088h 0136 004h] Device ID Mapping Index : 00000000 --- > [04Ch 0076 004h] Reserved : 00000000 > [050h 0080 008h] VATOS Address : 0000000000000000 > [058h 0088 004h] Model : 00000000 > [05Ch 0092 004h] Event GSIV : 0000006A > [060h 0096 004h] PRI GSIV : 0000006B > [064h 0100 004h] GERR GSIV : 0000006D > [068h 0104 004h] Sync GSIV : 0000006C > [06Ch 0108 004h] Proximity Domain : 00000000 > [070h 0112 004h] Device ID Mapping Index : 00000000 60,65c50,55 < [08Ch 0140 004h] Input base : 00000000 < [090h 0144 004h] ID Count : 0000FFFF < [094h 0148 004h] Output Base : 00000000 < [098h 0152 004h] Output Reference : 00000030 < [09Ch 0156 004h] Flags (decoded below) : 00000000 < Single Mapping : 0 --- > [074h 0116 001h] Type : 02 > [075h 0117 002h] Length : 004C > [077h 0119 001h] Revision : 03 > [078h 0120 004h] Identifier : 00000001 > [07Ch 0124 004h] Mapping Count : 00000002 > [080h 0128 004h] Mapping Offset : 00000024 67,76c57,59 < [0A0h 0160 001h] Type : 02 < [0A1h 0161 002h] Length : 0074 < [0A3h 0163 001h] Revision : 03 < [0A4h 0164 004h] Identifier : 00000002 < [0A8h 0168 004h] Mapping Count : 00000004 < [0ACh 0172 004h] Mapping Offset : 00000024 < < [0B0h 0176 008h] Memory Properties : [IORT Memory Access Properties] < [0B0h 0176 004h] Cache Coherency : 00000001 < [0B4h 0180 001h] Hints (decoded below) : 00 --- > [084h 0132 008h] Memory Properties : [IORT Memory Access Properties] > [084h 0132 004h] Cache Coherency : 00000001 > [088h 0136 001h] Hints (decoded below) : 00 81,82c64,65 < [0B5h 0181 002h] Reserved : 0000 < [0B7h 0183 001h] Memory Flags (decoded below) : 03 --- > [089h 0137 002h] Reserved : 0000 > [08Bh 0139 001h] Memory Flags (decoded below) : 03 86,90c69,73 < [0B8h 0184 004h] ATS Attribute : 00000000 < [0BCh 0188 004h] PCI Segment Number : 00000000 < [0C0h 0192 001h] Memory Size Limit : 40 < [0C1h 0193 002h] PASID Capabilities : 0000 < [0C3h 0195 001h] Reserved : 00 --- > [08Ch 0140 004h] ATS Attribute : 00000000 > [090h 0144 004h] PCI Segment Number : 00000000 > [094h 0148 001h] Memory Size Limit : 40 > [095h 0149 002h] PASID Capabilities : 0000 > [097h 0151 001h] Reserved : 00 92,96c75,79 < [0C4h 0196 004h] Input base : 00000000 < [0C8h 0200 004h] ID Count : 000001FF < [0CCh 0204 004h] Output Base : 00000000 < [0D0h 0208 004h] Output Reference : 00000048 < [0D4h 0212 004h] Flags (decoded below) : 00000000 --- > [098h 0152 004h] Input base : 00000000 > [09Ch 0156 004h] ID Count : 000001FF > [0A0h 0160 004h] Output Base : 00000000 > [0A4h 0164 004h] Output Reference : 00000030 > [0A8h 0168 004h] Flags (decoded below) : 00000000 99,103c82,86 < [0D8h 0216 004h] Input base : 00001000 < [0DCh 0220 004h] ID Count : 000000FF < [0E0h 0224 004h] Output Base : 00001000 < [0E4h 0228 004h] Output Reference : 00000048 < [0E8h 0232 004h] Flags (decoded below) : 00000000 --- > [0ACh 0172 004h] Input base : 00001000 > [0B0h 0176 004h] ID Count : 000000FF > [0B4h 0180 004h] Output Base : 00001000 > [0B8h 0184 004h] Output Reference : 00000030 > [0BCh 0188 004h] Flags (decoded below) : 00000000 106,111c89 < [0ECh 0236 004h] Input base : 00000200 < [0F0h 0240 004h] ID Count : 00000DFF < [0F4h 0244 004h] Output Base : 00000200 < [0F8h 0248 004h] Output Reference : 00000030 < [0FCh 0252 004h] Flags (decoded below) : 00000000 < Single Mapping : 0 --- > Raw Table Data: Length 192 (0xC0) 113,122c91 < [100h 0256 004h] Input base : 00001100 < [104h 0260 004h] ID Count : 0000EEFF < [108h 0264 004h] Output Base : 00001100 < [10Ch 0268 004h] Output Reference : 00000030 < [110h 0272 004h] Flags (decoded below) : 00000000 < Single Mapping : 0 < < Raw Table Data: Length 276 (0x114) < < 0000: 49 4F 52 54 14 01 00 00 03 4C 42 4F 43 48 53 20 // IORT.....LBOCHS --- > 0000: 49 4F 52 54 C0 00 00 00 03 1E 42 4F 43 48 53 20 // IORT......BOCHS 124,139c93,102 < 0020: 01 00 00 00 03 00 00 00 30 00 00 00 00 00 00 00 // ........0....... < 0030: 00 18 00 01 00 00 00 00 00 00 00 00 00 00 00 00 // ................ < 0040: 01 00 00 00 00 00 00 00 04 58 00 04 01 00 00 00 // .........X...... < 0050: 01 00 00 00 44 00 00 00 00 00 05 09 00 00 00 00 // ....D........... < 0060: 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ................ < 0070: 00 00 00 00 6A 00 00 00 6B 00 00 00 6D 00 00 00 // ....j...k...m... < 0080: 6C 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // l............... < 0090: FF FF 00 00 00 00 00 00 30 00 00 00 00 00 00 00 // ........0....... < 00A0: 02 74 00 03 02 00 00 00 04 00 00 00 24 00 00 00 // .t..........$... < 00B0: 01 00 00 00 00 00 00 03 00 00 00 00 00 00 00 00 // ................ < 00C0: 40 00 00 00 00 00 00 00 FF 01 00 00 00 00 00 00 // @............... < 00D0: 48 00 00 00 00 00 00 00 00 10 00 00 FF 00 00 00 // H............... < 00E0: 00 10 00 00 48 00 00 00 00 00 00 00 00 02 00 00 // ....H........... < 00F0: FF 0D 00 00 00 02 00 00 30 00 00 00 00 00 00 00 // ........0....... < 0100: 00 11 00 00 FF EE 00 00 00 11 00 00 30 00 00 00 // ............0... < 0110: 00 00 00 00 // .... --- > 0020: 01 00 00 00 02 00 00 00 30 00 00 00 00 00 00 00 // ........0....... > 0030: 04 44 00 04 00 00 00 00 00 00 00 00 00 00 00 00 // .D.............. > 0040: 00 00 05 09 00 00 00 00 01 00 00 00 00 00 00 00 // ................ > 0050: 00 00 00 00 00 00 00 00 00 00 00 00 6A 00 00 00 // ............j... > 0060: 6B 00 00 00 6D 00 00 00 6C 00 00 00 00 00 00 00 // k...m...l....... > 0070: 00 00 00 00 02 4C 00 03 01 00 00 00 02 00 00 00 // .....L.......... > 0080: 24 00 00 00 01 00 00 00 00 00 00 03 00 00 00 00 // $............... > 0090: 00 00 00 00 40 00 00 00 00 00 00 00 FF 01 00 00 // ....@........... > 00A0: 00 00 00 00 30 00 00 00 00 00 00 00 00 10 00 00 // ....0........... > 00B0: FF 00 00 00 00 10 00 00 30 00 00 00 00 00 00 00 // ........0....... As you noted in the follow up email, the blob is probably expected to be re-generated in this case after the SMMUv3 patches (if you’re going to take it without a further revision) Thank you, -Mohamed
On Thu, 29 Jan 2026 at 14:34, Mohamed Mediouni <mohamed@unpredictable.fr> wrote: > > > > > On 29. Jan 2026, at 14:36, Peter Maydell <peter.maydell@linaro.org> wrote: > > > > On Tue, 27 Jan 2026 at 18:28, Mohamed Mediouni <mohamed@unpredictable.fr> wrote: > >> > >> After the previous commit introducing GICv3 + GICv2m configurations, > >> update the AArch64 ACPI tables for the GICv2 case. > >> > >> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr> > >> --- > >> tests/data/acpi/aarch64/virt/IORT | Bin 128 -> 84 bytes > >> tests/data/acpi/aarch64/virt/IORT.smmuv3-dev | Bin 364 -> 260 bytes > >> tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy | Bin 276 -> 192 bytes > >> tests/qtest/bios-tables-test-allowed-diff.h | 3 --- > >> 4 files changed, 3 deletions(-) > > > > The process documented in tests/qtest/bios-tables-test.c says > > that this commit is supposed to have the diff of the disassembled > > table data in the commit message, so that human reviewers can > > confirm that the changes are as expected. (If you git log > > tests/data/acpi you can see how this looks.) > > > > Can you provide the ASL diff, please? (If this is going to be the > > only fix needed to this version of the series, which I hope it > > will be, then I can update the commit message as I apply the > > series, so you don't need to respin, just reply with the updated > > commit message with the diff in it.) > > > > thanks > > — PMM > Hi, > > Here’s the expected asl diff: > > diff otp/tests/data/acpi/aarch64/virt/IORT.dsl otp2/tests/data/acpi/aarch64/virt/IORT.dsl diff -u, please. But you're going to need to rebase this so I'll let you redo the commit message at that point. -- PMM
On Thu, Jan 29, 2026 at 01:36:49PM +0000, Peter Maydell wrote: > On Tue, 27 Jan 2026 at 18:28, Mohamed Mediouni <mohamed@unpredictable.fr> wrote: > > > > After the previous commit introducing GICv3 + GICv2m configurations, > > update the AArch64 ACPI tables for the GICv2 case. > > > > Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr> > > --- > > tests/data/acpi/aarch64/virt/IORT | Bin 128 -> 84 bytes > > tests/data/acpi/aarch64/virt/IORT.smmuv3-dev | Bin 364 -> 260 bytes > > tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy | Bin 276 -> 192 bytes > > tests/qtest/bios-tables-test-allowed-diff.h | 3 --- > > 4 files changed, 3 deletions(-) > > The process documented in tests/qtest/bios-tables-test.c says > that this commit is supposed to have the diff of the disassembled > table data in the commit message, so that human reviewers can > confirm that the changes are as expected. (If you git log > tests/data/acpi you can see how this looks.) not just that, also so the patch can be rebased. > Can you provide the ASL diff, please? (If this is going to be the > only fix needed to this version of the series, which I hope it > will be, then I can update the commit message as I apply the > series, so you don't need to respin, just reply with the updated > commit message with the diff in it.) > > thanks > -- PMM
On Thu, 29 Jan 2026 at 13:36, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Tue, 27 Jan 2026 at 18:28, Mohamed Mediouni <mohamed@unpredictable.fr> wrote: > > > > After the previous commit introducing GICv3 + GICv2m configurations, > > update the AArch64 ACPI tables for the GICv2 case. > > > > Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr> > > --- > > tests/data/acpi/aarch64/virt/IORT | Bin 128 -> 84 bytes > > tests/data/acpi/aarch64/virt/IORT.smmuv3-dev | Bin 364 -> 260 bytes > > tests/data/acpi/aarch64/virt/IORT.smmuv3-legacy | Bin 276 -> 192 bytes > > tests/qtest/bios-tables-test-allowed-diff.h | 3 --- > > 4 files changed, 3 deletions(-) > > The process documented in tests/qtest/bios-tables-test.c says > that this commit is supposed to have the diff of the disassembled > table data in the commit message, so that human reviewers can > confirm that the changes are as expected. (If you git log > tests/data/acpi you can see how this looks.) > > Can you provide the ASL diff, please? (If this is going to be the > only fix needed to this version of the series, which I hope it > will be, then I can update the commit message as I apply the > series, so you don't need to respin, just reply with the updated > commit message with the diff in it.) ...ah, it looks like unfortunately this is going to conflict with the smmuv3 acceleration series I already have queued, because that series also updates these ACPI blobs. So I think the best thing is if I get that out in a target-arm pullreq and then you can rebase on top of that. thanks -- PMM
© 2016 - 2026 Red Hat, Inc.