target/hexagon: Remove unused EXT_IDX enum

[PATCH] target/hexagon: Remove unused EXT_IDX enum

Marco Liebel posted 1 patch 1 week, 4 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260126223439.46974-1-marco.liebel@oss.qualcomm.com

Maintainers: Brian Cain <brian.cain@oss.qualcomm.com>

target/hexagon/decode.c | 8 --------
1 file changed, 8 deletions(-)

Expand all Fold all

[PATCH] target/hexagon: Remove unused EXT_IDX enum

Posted by Marco Liebel 1 week, 4 days ago

The EXT_IDX_noext, EXT_IDX_mmvec, and XX_LAST_EXT_IDX enum
constants are defined but never referenced anywhere in the
codebase.

Signed-off-by: Marco Liebel <marco.liebel@oss.qualcomm.com>
---
 target/hexagon/decode.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c
index c2516d927d..30100e5105 100644
--- a/target/hexagon/decode.c
+++ b/target/hexagon/decode.c
@@ -26,14 +26,6 @@
 
 #define fZXTN(N, M, VAL) ((VAL) & ((1LL << (N)) - 1))
 
-enum {
-    EXT_IDX_noext = 0,
-    EXT_IDX_noext_AFTER = 4,
-    EXT_IDX_mmvec = 4,
-    EXT_IDX_mmvec_AFTER = 8,
-    XX_LAST_EXT_IDX
-};
-
 /*
  *  Certain operand types represent a non-contiguous set of values.
  *  For example, the compound compare-and-jump instruction can only access
-- 
2.43.0

Re: [PATCH] target/hexagon: Remove unused EXT_IDX enum

Posted by Taylor Simpson 1 week, 3 days ago

On Mon, Jan 26, 2026 at 3:34 PM Marco Liebel <marco.liebel@oss.qualcomm.com>
wrote:

> The EXT_IDX_noext, EXT_IDX_mmvec, and XX_LAST_EXT_IDX enum
> constants are defined but never referenced anywhere in the
> codebase.
>
> Signed-off-by: Marco Liebel <marco.liebel@oss.qualcomm.com>
> ---
>  target/hexagon/decode.c | 8 --------
>  1 file changed, 8 deletions(-)
>

Reviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>

Re: [PATCH] target/hexagon: Remove unused EXT_IDX enum

Posted by Brian Cain 1 week, 3 days ago

On Tue, Jan 27, 2026 at 1:08 PM Taylor Simpson <ltaylorsimpson@gmail.com> wrote:
>
>
>
> On Mon, Jan 26, 2026 at 3:34 PM Marco Liebel <marco.liebel@oss.qualcomm.com> wrote:
>>
>> The EXT_IDX_noext, EXT_IDX_mmvec, and XX_LAST_EXT_IDX enum
>> constants are defined but never referenced anywhere in the
>> codebase.
>>
>> Signed-off-by: Marco Liebel <marco.liebel@oss.qualcomm.com>
>> ---
>>  target/hexagon/decode.c | 8 --------
>>  1 file changed, 8 deletions(-)
>
>
> Reviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>

Reviewed-by: Brian Cain <brian.cain@oss.qualcomm.com>