audio: cleanups & add a manual test

[PATCH 14/37] scripts/modinfo: make --devices optional

marcandre.lureau@redhat.com posted 37 patches 2 days, 2 hours ago

Download mbox

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Christian Schoenebeck <qemu_oss@crudebyte.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>, Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>, Laurent Vivier <laurent@vivier.eu>, Manos Pitsidianakis <manos.pitsidianakis@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Alistair Francis <alistair@alistair23.me>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>

Expand all Fold all

[PATCH 14/37] scripts/modinfo: make --devices optional

Posted by marcandre.lureau@redhat.com 2 days, 2 hours ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

This will allow to use modinfo-generate in cases where devices aren't
relevant (tests etc)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 scripts/modinfo-generate.py | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/scripts/modinfo-generate.py b/scripts/modinfo-generate.py
index 777d419aa33..e7d35242414 100644
--- a/scripts/modinfo-generate.py
+++ b/scripts/modinfo-generate.py
@@ -84,7 +84,7 @@ def main() -> None:
     parser = argparse.ArgumentParser(
         description='Generate C code for QEMU module info'
     )
-    parser.add_argument('--devices', required=True,
+    parser.add_argument('--devices',
                         help='path to config-device.mak')
     parser.add_argument('modinfo', nargs='+',
                         help='modinfo files to process')
@@ -92,11 +92,12 @@ def main() -> None:
 
     # get all devices enabled in kconfig, from *-config-device.mak
     enabled = set()
-    with open(args.devices) as file:
-        for line in file.readlines():
-            config = line.split('=')
-            if config[1].rstrip() == 'y':
-                enabled.add(config[0][7:])  # remove CONFIG_
+    if args.devices:
+        with open(args.devices) as file:
+            for line in file.readlines():
+                config = line.split('=')
+                if config[1].rstrip() == 'y':
+                    enabled.add(config[0][7:])  # remove CONFIG_
 
     deps = set()
     modules = set()
-- 
2.52.0