audio: cleanups & add a manual test

[PATCH 14/37] scripts/modinfo: make --devices optional

Posted by marcandre.lureau@redhat.com 2 weeks, 3 days ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

This will allow to use modinfo-generate in cases where devices aren't
relevant (tests etc)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 scripts/modinfo-generate.py | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/scripts/modinfo-generate.py b/scripts/modinfo-generate.py
index 777d419aa33..e7d35242414 100644
--- a/scripts/modinfo-generate.py
+++ b/scripts/modinfo-generate.py
@@ -84,7 +84,7 @@ def main() -> None:
     parser = argparse.ArgumentParser(
         description='Generate C code for QEMU module info'
     )
-    parser.add_argument('--devices', required=True,
+    parser.add_argument('--devices',
                         help='path to config-device.mak')
     parser.add_argument('modinfo', nargs='+',
                         help='modinfo files to process')
@@ -92,11 +92,12 @@ def main() -> None:
 
     # get all devices enabled in kconfig, from *-config-device.mak
     enabled = set()
-    with open(args.devices) as file:
-        for line in file.readlines():
-            config = line.split('=')
-            if config[1].rstrip() == 'y':
-                enabled.add(config[0][7:])  # remove CONFIG_
+    if args.devices:
+        with open(args.devices) as file:
+            for line in file.readlines():
+                config = line.split('=')
+                if config[1].rstrip() == 'y':
+                    enabled.add(config[0][7:])  # remove CONFIG_
 
     deps = set()
     modules = set()
-- 
2.52.0

Re: [PATCH 14/37] scripts/modinfo: make --devices optional

Posted by Mark Cave-Ayland 6 days, 14 hours ago

On 23/01/2026 07:49, marcandre.lureau@redhat.com wrote:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> This will allow to use modinfo-generate in cases where devices aren't
> relevant (tests etc)
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   scripts/modinfo-generate.py | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/modinfo-generate.py b/scripts/modinfo-generate.py
> index 777d419aa33..e7d35242414 100644
> --- a/scripts/modinfo-generate.py
> +++ b/scripts/modinfo-generate.py
> @@ -84,7 +84,7 @@ def main() -> None:
>       parser = argparse.ArgumentParser(
>           description='Generate C code for QEMU module info'
>       )
> -    parser.add_argument('--devices', required=True,
> +    parser.add_argument('--devices',
>                           help='path to config-device.mak')
>       parser.add_argument('modinfo', nargs='+',
>                           help='modinfo files to process')
> @@ -92,11 +92,12 @@ def main() -> None:
>   
>       # get all devices enabled in kconfig, from *-config-device.mak
>       enabled = set()
> -    with open(args.devices) as file:
> -        for line in file.readlines():
> -            config = line.split('=')
> -            if config[1].rstrip() == 'y':
> -                enabled.add(config[0][7:])  # remove CONFIG_
> +    if args.devices:
> +        with open(args.devices) as file:
> +            for line in file.readlines():
> +                config = line.split('=')
> +                if config[1].rstrip() == 'y':
> +                    enabled.add(config[0][7:])  # remove CONFIG_
>   
>       deps = set()
>       modules = set()

Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>


ATB,

Mark.