migration/colo: small cleanup series

[PATCH 06/10] migration/colo: Remove call to send switchover start event

Posted by Peter Xu 3 days, 11 hours ago

COLO (in case of periodically checkpointing) already have switchover
happened before hand.  This switchover_start feature never applies to COLO.
Remove it.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/colo.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/migration/colo.c b/migration/colo.c
index e05736ecf0..c344943173 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -453,8 +453,6 @@ static int colo_do_checkpoint_transaction(MigrationState *s,
         goto out;
     }
 
-    qemu_savevm_maybe_send_switchover_start(s->to_dst_file);
-
     /* Note: device state is saved into buffer */
     ret = qemu_save_device_state(fb);
 
-- 
2.50.1

Re: [PATCH 06/10] migration/colo: Remove call to send switchover start event

Posted by Fabiano Rosas 1 day, 20 hours ago

Peter Xu <peterx@redhat.com> writes:

> COLO (in case of periodically checkpointing) already have switchover
> happened before hand.  This switchover_start feature never applies to COLO.
> Remove it.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  migration/colo.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/migration/colo.c b/migration/colo.c
> index e05736ecf0..c344943173 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -453,8 +453,6 @@ static int colo_do_checkpoint_transaction(MigrationState *s,
>          goto out;
>      }
>  
> -    qemu_savevm_maybe_send_switchover_start(s->to_dst_file);
> -
>      /* Note: device state is saved into buffer */
>      ret = qemu_save_device_state(fb);

Reviewed-by: Fabiano Rosas <farosas@suse.de>