vfio-user: trivial VFIOProxy flags fix

[PATCH 1/2] vfio-user: fix VFIO_PROXY_USE_MULTI constant value

Posted by Mark Cave-Ayland 2 weeks, 5 days ago

The constant value should represent the next bit in the VFIOProxy flags which
is 0x10 and not 0x16.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio-user/proxy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio-user/proxy.h b/hw/vfio-user/proxy.h
index 61e64a0020..b09fd886f1 100644
--- a/hw/vfio-user/proxy.h
+++ b/hw/vfio-user/proxy.h
@@ -94,7 +94,7 @@ typedef struct VFIOUserProxy {
 #define VFIO_PROXY_CLIENT        0x1
 #define VFIO_PROXY_FORCE_QUEUED  0x4
 #define VFIO_PROXY_NO_POST       0x8
-#define VFIO_PROXY_USE_MULTI     0x16
+#define VFIO_PROXY_USE_MULTI     0x10
 
 /* coalescing high and low water marks for VFIOProxy num_outgoing */
 #define VFIO_USER_OUT_HIGH       1024
-- 
2.43.0

Re: [PATCH 1/2] vfio-user: fix VFIO_PROXY_USE_MULTI constant value

Posted by Cédric Le Goater 2 weeks, 5 days ago

On 1/21/26 11:59, Mark Cave-Ayland wrote:
> The constant value should represent the next bit in the VFIOProxy flags which
> is 0x10 and not 0x16.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>

Should there be a Fixes tag ?

Thanks,

C.


> ---
>   hw/vfio-user/proxy.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio-user/proxy.h b/hw/vfio-user/proxy.h
> index 61e64a0020..b09fd886f1 100644
> --- a/hw/vfio-user/proxy.h
> +++ b/hw/vfio-user/proxy.h
> @@ -94,7 +94,7 @@ typedef struct VFIOUserProxy {
>   #define VFIO_PROXY_CLIENT        0x1
>   #define VFIO_PROXY_FORCE_QUEUED  0x4
>   #define VFIO_PROXY_NO_POST       0x8
> -#define VFIO_PROXY_USE_MULTI     0x16
> +#define VFIO_PROXY_USE_MULTI     0x10
>   
>   /* coalescing high and low water marks for VFIOProxy num_outgoing */
>   #define VFIO_USER_OUT_HIGH       1024

Re: [PATCH 1/2] vfio-user: fix VFIO_PROXY_USE_MULTI constant value

Posted by Mark Cave-Ayland 2 weeks, 5 days ago

On 21/01/2026 11:15, Cédric Le Goater wrote:

> On 1/21/26 11:59, Mark Cave-Ayland wrote:
>> The constant value should represent the next bit in the VFIOProxy 
>> flags which
>> is 0x10 and not 0x16.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> 
> Should there be a Fixes tag ?

Yes indeed, it should be:

Fixes: 1a0c32a9da ("vfio-user: add coalesced posted writes")

Would you like me to resend a v2?


ATB,

Mark.

> Thanks,
> 
> C.
> 
> 
>> ---
>>   hw/vfio-user/proxy.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/vfio-user/proxy.h b/hw/vfio-user/proxy.h
>> index 61e64a0020..b09fd886f1 100644
>> --- a/hw/vfio-user/proxy.h
>> +++ b/hw/vfio-user/proxy.h
>> @@ -94,7 +94,7 @@ typedef struct VFIOUserProxy {
>>   #define VFIO_PROXY_CLIENT        0x1
>>   #define VFIO_PROXY_FORCE_QUEUED  0x4
>>   #define VFIO_PROXY_NO_POST       0x8
>> -#define VFIO_PROXY_USE_MULTI     0x16
>> +#define VFIO_PROXY_USE_MULTI     0x10
>>   /* coalescing high and low water marks for VFIOProxy num_outgoing */
>>   #define VFIO_USER_OUT_HIGH       1024

Re: [PATCH 1/2] vfio-user: fix VFIO_PROXY_USE_MULTI constant value

Posted by John Levon 2 weeks, 5 days ago

On Wed, Jan 21, 2026 at 10:59:45AM +0000, Mark Cave-Ayland wrote:

> The constant value should represent the next bit in the VFIOProxy flags which
> is 0x10 and not 0x16.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>  hw/vfio-user/proxy.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio-user/proxy.h b/hw/vfio-user/proxy.h
> index 61e64a0020..b09fd886f1 100644
> --- a/hw/vfio-user/proxy.h
> +++ b/hw/vfio-user/proxy.h
> @@ -94,7 +94,7 @@ typedef struct VFIOUserProxy {
>  #define VFIO_PROXY_CLIENT        0x1
>  #define VFIO_PROXY_FORCE_QUEUED  0x4
>  #define VFIO_PROXY_NO_POST       0x8
> -#define VFIO_PROXY_USE_MULTI     0x16
> +#define VFIO_PROXY_USE_MULTI     0x10
>  
>  /* coalescing high and low water marks for VFIOProxy num_outgoing */
>  #define VFIO_USER_OUT_HIGH       1024

Reviewed-by: John Levon <john.levon@nutanix.com>

thanks
john

Re: [PATCH 1/2] vfio-user: fix VFIO_PROXY_USE_MULTI constant value

Posted by John Levon 2 weeks, 5 days ago

On Wed, Jan 21, 2026 at 10:59:45AM +0000, Mark Cave-Ayland wrote:

> The constant value should represent the next bit in the VFIOProxy flags which
> is 0x10 and not 0x16.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>  hw/vfio-user/proxy.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio-user/proxy.h b/hw/vfio-user/proxy.h
> index 61e64a0020..b09fd886f1 100644
> --- a/hw/vfio-user/proxy.h
> +++ b/hw/vfio-user/proxy.h
> @@ -94,7 +94,7 @@ typedef struct VFIOUserProxy {
>  #define VFIO_PROXY_CLIENT        0x1
>  #define VFIO_PROXY_FORCE_QUEUED  0x4
>  #define VFIO_PROXY_NO_POST       0x8
> -#define VFIO_PROXY_USE_MULTI     0x16
> +#define VFIO_PROXY_USE_MULTI     0x10
>  
>  /* coalescing high and low water marks for VFIOProxy num_outgoing */
>  #define VFIO_USER_OUT_HIGH       1024

In case anyone is wondering, this never bit us because the MULTI support is not
yet merged into libvfio-user

regards
john