hw/gpio/pca9552: add pca9535 support

[PATCH 2/2] hw/arm/aspeed: catalina: use pca9535

Posted by Patrick Williams 2 weeks, 5 days ago

A few entries in the catalina model were using the PCA9552 chip
because it was "close enough" in function.  Since there is a PCA9535
model now, switch to use it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
---
 hw/arm/aspeed_ast2600_catalina.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/arm/aspeed_ast2600_catalina.c b/hw/arm/aspeed_ast2600_catalina.c
index 4edb30bb16..65495a524e 100644
--- a/hw/arm/aspeed_ast2600_catalina.c
+++ b/hw/arm/aspeed_ast2600_catalina.c
@@ -480,7 +480,7 @@ static void catalina_bmc_i2c_init(AspeedMachineState *bmc)
     /* i2c0mux1ch1 */
     /* io_expander7 - pca9535@20 */
     i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 1),
-                            TYPE_PCA9552, 0x20);
+                            TYPE_PCA9535, 0x20);
     /* eeprom@50 */
     at24c_eeprom_init_rom(pca954x_i2c_get_bus(i2c_mux, 1), 0x50, 8 * KiB,
                           gb200io_eeprom, gb200io_eeprom_len);
@@ -497,7 +497,7 @@ static void catalina_bmc_i2c_init(AspeedMachineState *bmc)
     /* i2c0mux4ch1 */
     /* io_expander8 - pca9535@21 */
     i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 1),
-                            TYPE_PCA9552, 0x21);
+                            TYPE_PCA9535, 0x21);
     /* eeprom@50 */
     at24c_eeprom_init_rom(pca954x_i2c_get_bus(i2c_mux, 1), 0x50, 8 * KiB,
                           gb200io_eeprom, gb200io_eeprom_len);

-- 
2.51.2

Re: [PATCH 2/2] hw/arm/aspeed: catalina: use pca9535

Posted by Cédric Le Goater 2 weeks, 4 days ago

On 1/21/26 19:17, Patrick Williams wrote:
> A few entries in the catalina model were using the PCA9552 chip
> because it was "close enough" in function.  Since there is a PCA9535
> model now, switch to use it.
> 
> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> ---
>   hw/arm/aspeed_ast2600_catalina.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/arm/aspeed_ast2600_catalina.c b/hw/arm/aspeed_ast2600_catalina.c
> index 4edb30bb16..65495a524e 100644
> --- a/hw/arm/aspeed_ast2600_catalina.c
> +++ b/hw/arm/aspeed_ast2600_catalina.c
> @@ -480,7 +480,7 @@ static void catalina_bmc_i2c_init(AspeedMachineState *bmc)
>       /* i2c0mux1ch1 */
>       /* io_expander7 - pca9535@20 */
>       i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 1),
> -                            TYPE_PCA9552, 0x20);
> +                            TYPE_PCA9535, 0x20);
>       /* eeprom@50 */
>       at24c_eeprom_init_rom(pca954x_i2c_get_bus(i2c_mux, 1), 0x50, 8 * KiB,
>                             gb200io_eeprom, gb200io_eeprom_len);
> @@ -497,7 +497,7 @@ static void catalina_bmc_i2c_init(AspeedMachineState *bmc)
>       /* i2c0mux4ch1 */
>       /* io_expander8 - pca9535@21 */
>       i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 1),
> -                            TYPE_PCA9552, 0x21);
> +                            TYPE_PCA9535, 0x21);
>       /* eeprom@50 */
>       at24c_eeprom_init_rom(pca954x_i2c_get_bus(i2c_mux, 1), 0x50, 8 * KiB,
>                             gb200io_eeprom, gb200io_eeprom_len);
> 

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.

[PATCH 1/2] hw/gpio/pca9552: add pca9535 support
[PATCH 2/2] hw/arm/aspeed: catalina: use pca9535