[PATCH v4 17/17] RFC: exclude pyvenv targets from "make check-build"

John Snow posted 17 patches 2 weeks, 6 days ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Ed Maste <emaste@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, Yonggang Luo <luoyonggang@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Maksim Davydov <davydov-max@yandex-team.ru>, Markus Armbruster <armbru@redhat.com>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>
There is a newer version of this series
[PATCH v4 17/17] RFC: exclude pyvenv targets from "make check-build"
Posted by John Snow 2 weeks, 6 days ago
This patch removes python venv preparation steps from "make check-build".

Thomas pointed out that "make check-build" was installing all venv
preparation targets, which may or may not be desired. In case it isn't
desired, this patch showcases a crude hack to bypass it.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/mtest2make.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/mtest2make.py b/scripts/mtest2make.py
index 4b252defc3f..f102369287b 100644
--- a/scripts/mtest2make.py
+++ b/scripts/mtest2make.py
@@ -82,9 +82,11 @@ def emit_prolog(suites, prefix):
 
 def emit_suite(name, suite, prefix):
     deps = ' '.join(suite.deps)
+    testdeps = ' '.join([x for x in suite.deps if 'pyvenv' not in x])
     print()
     print(f'.{prefix}-{name}.deps = {deps}')
-    print(f'.ninja-goals.check-build += $(.{prefix}-{name}.deps)')
+    print(f'.{prefix}-{name}.testdeps = {testdeps}')
+    print(f'.ninja-goals.check-build += $(.{prefix}-{name}.testdeps)')
 
     names = ' '.join(suite.names(name))
     targets = f'{prefix}-{name} {prefix}-report-{name}.junit.xml'
-- 
2.52.0