[v1] Tracing patches

[PULL 0/8] Tracing patches

Stefan Hajnoczi posted 8 patches 2 weeks, 4 days ago

Diff against v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v2 v2 v2 v2 v2 v2 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260119190823.867761-1-stefanha@redhat.com

Maintainers: John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Mads Ynddal <mads@ynddal.dk>

There is a newer version of this series

python/tests/tracetool-isort.sh              |  4 +
python/tests/tracetool-mypy.sh               |  5 ++
scripts/tracetool.py                         | 12 +--
scripts/tracetool/__init__.py                | 84 ++++++++++----------
scripts/tracetool/backend/__init__.py        | 21 ++---
scripts/tracetool/backend/dtrace.py          | 19 ++---
scripts/tracetool/backend/ftrace.py          | 13 +--
scripts/tracetool/backend/log.py             | 13 +--
scripts/tracetool/backend/simple.py          | 19 ++---
scripts/tracetool/backend/syslog.py          | 13 +--
scripts/tracetool/backend/ust.py             | 11 +--
scripts/tracetool/format/__init__.py         |  9 ++-
scripts/tracetool/format/c.py                |  7 +-
scripts/tracetool/format/d.py                |  7 +-
scripts/tracetool/format/h.py                |  7 +-
scripts/tracetool/format/log_stap.py         | 12 +--
scripts/tracetool/format/rs.py               |  7 +-
scripts/tracetool/format/simpletrace_stap.py |  7 +-
scripts/tracetool/format/stap.py             | 10 ++-
scripts/tracetool/format/ust_events_c.py     |  7 +-
scripts/tracetool/format/ust_events_h.py     |  7 +-
tests/tracetool/tracetool-test.py            | 27 +++++--
22 files changed, 195 insertions(+), 126 deletions(-)
create mode 100755 python/tests/tracetool-isort.sh
create mode 100755 python/tests/tracetool-mypy.sh

Expand all Fold all

[PULL 0/8] Tracing patches

Posted by Stefan Hajnoczi 2 weeks, 4 days ago

The following changes since commit 38879a667fbb4ef54c70de71494882615f600a64:

  Merge tag 'pull-tcg-20260119' of https://gitlab.com/rth7680/qemu into staging (2026-01-19 09:04:31 +1100)

are available in the Git repository at:

  https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 0527c4fdd28ae8b13ecc34f80b91e42ce42b917f:

  tests/tracetool: Honor the Python interpreter that "configure" detected (2026-01-19 13:58:23 -0500)

----------------------------------------------------------------
Pull request

- Thomas Huth's Python interpreter fix
- Paolo Bonzini's tracetool cleanups
- Stefan Hajnoczi's tracetool test QEMU_TEST_KEEP_SCRATCH=1 support

----------------------------------------------------------------

Paolo Bonzini (6):
  tracetool: rename variable with conflicting types
  tracetool: apply isort and add check
  tracetool: "import annotations"
  tracetool: add type annotations
  tracetool: complete typing annotations
  tracetool: add typing checks to "make -C python check"

Stefan Hajnoczi (1):
  tracetool-test: add QEMU_TEST_KEEP_SCRATCH=1 support

Thomas Huth (1):
  tests/tracetool: Honor the Python interpreter that "configure"
    detected

 python/tests/tracetool-isort.sh              |  4 +
 python/tests/tracetool-mypy.sh               |  5 ++
 scripts/tracetool.py                         | 12 +--
 scripts/tracetool/__init__.py                | 84 ++++++++++----------
 scripts/tracetool/backend/__init__.py        | 21 ++---
 scripts/tracetool/backend/dtrace.py          | 19 ++---
 scripts/tracetool/backend/ftrace.py          | 13 +--
 scripts/tracetool/backend/log.py             | 13 +--
 scripts/tracetool/backend/simple.py          | 19 ++---
 scripts/tracetool/backend/syslog.py          | 13 +--
 scripts/tracetool/backend/ust.py             | 11 +--
 scripts/tracetool/format/__init__.py         |  9 ++-
 scripts/tracetool/format/c.py                |  7 +-
 scripts/tracetool/format/d.py                |  7 +-
 scripts/tracetool/format/h.py                |  7 +-
 scripts/tracetool/format/log_stap.py         | 12 +--
 scripts/tracetool/format/rs.py               |  7 +-
 scripts/tracetool/format/simpletrace_stap.py |  7 +-
 scripts/tracetool/format/stap.py             | 10 ++-
 scripts/tracetool/format/ust_events_c.py     |  7 +-
 scripts/tracetool/format/ust_events_h.py     |  7 +-
 tests/tracetool/tracetool-test.py            | 27 +++++--
 22 files changed, 195 insertions(+), 126 deletions(-)
 create mode 100755 python/tests/tracetool-isort.sh
 create mode 100755 python/tests/tracetool-mypy.sh

-- 
2.52.0

Re: [PULL 0/8] Tracing patches

Posted by Richard Henderson 2 weeks, 4 days ago

On 1/20/26 06:08, Stefan Hajnoczi wrote:
> The following changes since commit 38879a667fbb4ef54c70de71494882615f600a64:
> 
>    Merge tag 'pull-tcg-20260119' of https://gitlab.com/rth7680/qemu into staging (2026-01-19 09:04:31 +1100)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
> 
> for you to fetch changes up to 0527c4fdd28ae8b13ecc34f80b91e42ce42b917f:
> 
>    tests/tracetool: Honor the Python interpreter that "configure" detected (2026-01-19 13:58:23 -0500)
> 
> ----------------------------------------------------------------
> Pull request
> 
> - Thomas Huth's Python interpreter fix
> - Paolo Bonzini's tracetool cleanups
> - Stefan Hajnoczi's tracetool test QEMU_TEST_KEEP_SCRATCH=1 support

This has lots of failures:

https://gitlab.com/qemu-project/qemu/-/jobs/12772423978

> Summary of Failures:
> 507/512 tracetool - qemu:dtrace                                              FAIL             0.03s   exit status 1
> 508/512 tracetool - qemu:ftrace                                              FAIL             0.04s   exit status 1
> 509/512 tracetool - qemu:log                                                 FAIL             0.04s   exit status 1
> 510/512 tracetool - qemu:simple                                              FAIL             0.04s   exit status 1
> 511/512 tracetool - qemu:syslog                                              FAIL             0.04s   exit status 1
> 512/512 tracetool - qemu:ust                                                 FAIL             0.03s   exit status 1

https://gitlab.com/qemu-project/qemu/-/jobs/12772423994

> Log file "stdout" content for test "38-tests/tracetool-isort.sh" (FAIL):
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/__init__.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/backend/__init__.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/backend/dtrace.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/backend/ftrace.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/backend/log.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/backend/simple.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/backend/syslog.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/backend/ust.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/__init__.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/c.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/d.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/h.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/log_stap.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/rs.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/simpletrace_stap.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/stap.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/ust_events_c.py Imports are incorrectly sorted and/or formatted.
> ERROR: /builds/qemu-project/qemu/scripts/tracetool/format/ust_events_h.py Imports are incorrectly sorted and/or formatted.
> Log file "stderr" content for test "38-tests/tracetool-isort.sh" (FAIL):
> Log file "stdout" content for test "39-tests/tracetool-mypy.sh" (FAIL):
> tracetool/backend/dtrace.py:76: error: Function is missing a type annotation  [no-untyped-def]
> tracetool/backend/dtrace.py:91: error: Function is missing a type annotation  [no-untyped-def]
> tracetool/backend/dtrace.py:99: error: Function is missing a type annotation  [no-untyped-def]
> Found 3 errors in 1 file (checked 18 source files)


r~

Re: [PULL 0/8] Tracing patches

Posted by Paolo Bonzini 2 weeks, 4 days ago

On 1/19/26 21:53, Richard Henderson wrote:
> 
> This has lots of failures:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/12772423978
> 
>> Summary of Failures:
>> 507/512 tracetool - 
>> qemu:dtrace                                              
>> FAIL             0.03s   exit status 1
>> 508/512 tracetool - 
>> qemu:ftrace                                              
>> FAIL             0.04s   exit status 1
>> 509/512 tracetool - 
>> qemu:log                                                 
>> FAIL             0.04s   exit status 1
>> 510/512 tracetool - 
>> qemu:simple                                              
>> FAIL             0.04s   exit status 1
>> 511/512 tracetool - 
>> qemu:syslog                                              
>> FAIL             0.04s   exit status 1
>> 512/512 tracetool - 
>> qemu:ust                                                 
>> FAIL             0.03s   exit status 1
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/12772423994

Given the PR is based on an old tag ("Merge tag 'pull-tcg-20250905' of 
https://gitlab.com/rth7680/qemu into staging") it's probably conflicting 
with some changes to python/.

Stefan, drop those and I'll resubmit in some time.

Paolo