On Sat, Jan 17, 2026 at 03:09:14PM +0100, Lukas Straub wrote:
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> ---
> docs/system/qemu-colo.rst | 30 ++++++++++++------------------
> 1 file changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/docs/system/qemu-colo.rst b/docs/system/qemu-colo.rst
> index 5b00c6c4c2679153f398ed5a85a5d9cc515630e6..2052e207e57afdd3ab3ab1a447d55f5e2e5b5b87 100644
> --- a/docs/system/qemu-colo.rst
> +++ b/docs/system/qemu-colo.rst
> @@ -1,14 +1,6 @@
> Qemu COLO Fault Tolerance
> =========================
>
> -| Copyright (c) 2016 Intel Corporation
> -| Copyright (c) 2016 HUAWEI TECHNOLOGIES CO., LTD.
> -| Copyright (c) 2016 Fujitsu, Corp.
> -| Copyright (c) 2026 Lukas Straub <lukasstraub2@web.de>
Hmm, I don't see this copyright line in the current code base. I think you
added it in previous conversion patch.
When converting, we should keep that patch change nothing in the content
but only convert things.
If you want to propose new things to the doc, it needs to be separately
done and reviewed.
We'd better not hide real changes within a conversion patch.
Here, I'm not sure you should add your copyright line. IIUC, that can be
added only if you made prominent contribution to this solution in the code
base. Becoming a maintainer is definitely a bless, however not justified
for an additional copyright update. I can also be wrong, but please
justify.
> -
> -This work is licensed under the terms of the GNU GPL, version 2 or later.
> -See the COPYING file in the top-level directory.
> -
> This document gives an overview of COLO's design and how to use it.
>
> Background
> @@ -83,8 +75,8 @@ Overview::
> | Storage | |External Network| | External Network | | Storage |
> +---------------+ +----------------+ +------------------+ +--------------+
>
> -Components introduction
> -^^^^^^^^^^^^^^^^^^^^^^^
> +Components
> +^^^^^^^^^^
> You can see there are several components in COLO's diagram of architecture.
> Their functions are described below.
>
> @@ -158,14 +150,14 @@ in test procedure.
>
> Test procedure
> --------------
> -Note: Here we are running both instances on the same host for testing,
> +Here we are running both instances on the same host for testing,
> change the IP Addresses if you want to run it on two hosts. Initially
> ``127.0.0.1`` is the Primary Host and ``127.0.0.2`` is the Secondary Host.
>
> Startup qemu
> ^^^^^^^^^^^^
> **1. Primary**:
> -Note: Initially, ``$imagefolder/primary.qcow2`` needs to be copied to all hosts.
> +Initially, ``$imagefolder/primary.qcow2`` needs to be copied to all hosts.
> You don't need to change any IP's here, because ``0.0.0.0`` listens on any
> interface. The chardev's with ``127.0.0.1`` IP's loopback to the local qemu
> instance::
> @@ -193,7 +185,7 @@ instance::
>
>
> **2. Secondary**:
> -Note: Active and hidden images need to be created only once and the
> +Active and hidden images need to be created only once and the
> size should be the same as ``primary.qcow2``. Again, you don't need to change
> any IP's here, except for the ``$primary_ip`` variable::
>
> @@ -354,8 +346,10 @@ Wait until disk is synced, then::
> {"execute": "migrate-set-capabilities", "arguments":{ "capabilities": [ {"capability": "x-colo", "state": true } ] } }
> {"execute": "migrate", "arguments":{ "uri": "tcp:127.0.0.1:9998" } }
>
> -TODO
> -----
> -1. Support shared storage.
> -2. Develop the heartbeat part.
> -3. Reduce checkpoint VM’s downtime while doing checkpoint.
> +| Copyright (c) 2016 Intel Corporation
> +| Copyright (c) 2016 HUAWEI TECHNOLOGIES CO., LTD.
> +| Copyright (c) 2016 Fujitsu, Corp.
> +| Copyright (c) 2026 Lukas Straub <lukasstraub2@web.de>
> +
> +This work is licensed under the terms of the GNU GPL, version 2 or later.
> +See the COPYING file in the top-level directory.
> \ No newline at end of file
>
> --
> 2.39.5
>
--
Peter Xu