[PULL 1/3] MAINTAINERS: Update ASPEED entry

Jamin Lin via qemu development posted 3 patches 3 weeks, 2 days ago
There is a newer version of this series
[PULL 1/3] MAINTAINERS: Update ASPEED entry
Posted by Jamin Lin via qemu development 3 weeks, 2 days ago
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4ddbfba9f0..28046b457a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1248,11 +1248,13 @@ F: hw/net/ftgmac100.c
 F: include/hw/net/ftgmac100.h
 F: docs/system/arm/aspeed.rst
 F: docs/system/arm/fby35.rst
+F: docs/specs/aspeed*
 F: tests/functional/*/*aspeed*
 F: tests/*/*aspeed*
 F: tests/*/*ast2700*
 F: hw/arm/fby35.c
 F: pc-bios/ast27x0_bootrom.bin
+F: roms/vbootrom
 
 NRF51
 M: Joel Stanley <joel@jms.id.au>
-- 
2.43.0
Re: [PULL 1/3] MAINTAINERS: Update ASPEED entry
Posted by Cédric Le Goater 3 weeks, 2 days ago
On 1/16/26 08:30, Jamin Lin wrote:
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   MAINTAINERS | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4ddbfba9f0..28046b457a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1248,11 +1248,13 @@ F: hw/net/ftgmac100.c
>   F: include/hw/net/ftgmac100.h
>   F: docs/system/arm/aspeed.rst
>   F: docs/system/arm/fby35.rst
> +F: docs/specs/aspeed*
>   F: tests/functional/*/*aspeed*
>   F: tests/*/*aspeed*
>   F: tests/*/*ast2700*
>   F: hw/arm/fby35.c
>   F: pc-bios/ast27x0_bootrom.bin
> +F: roms/vbootrom

roms/vbootrom is under "Nuvoton NPCM7xx" already. I guess it is fine
to have duplicated entries. Did you check with ./scripts/get_maintainer.pl ?

Thanks,

C.
RE: [PULL 1/3] MAINTAINERS: Update ASPEED entry
Posted by Jamin Lin 3 weeks, 2 days ago
> Subject: Re: [PULL 1/3] MAINTAINERS: Update ASPEED entry
> 
> On 1/16/26 08:30, Jamin Lin wrote:
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> >   MAINTAINERS | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS index 4ddbfba9f0..28046b457a
> > 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1248,11 +1248,13 @@ F: hw/net/ftgmac100.c
> >   F: include/hw/net/ftgmac100.h
> >   F: docs/system/arm/aspeed.rst
> >   F: docs/system/arm/fby35.rst
> > +F: docs/specs/aspeed*
> >   F: tests/functional/*/*aspeed*
> >   F: tests/*/*aspeed*
> >   F: tests/*/*ast2700*
> >   F: hw/arm/fby35.c
> >   F: pc-bios/ast27x0_bootrom.bin
> > +F: roms/vbootrom
> 
> roms/vbootrom is under "Nuvoton NPCM7xx" already. I guess it is fine to have
> duplicated entries. Did you check with ./scripts/get_maintainer.pl ?
> 

It adds both ASPEED and NPCM7xx reviewers and maintainers.

jamin_lin@aspeed-fw02:~/commit/qemu$ ./scripts/get_maintainer.pl ./0002-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b22c.patch
get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.

Peter Maydell <peter.maydell@linaro.org> (commit_signer:2/3=67%)
Jamin Lin <jamin_lin@aspeedtech.com> (commit_signer:2/3=67%)
Nabih Estefan <nabihestefan@google.com> (commit_signer:1/3=33%)
"Cédric Le Goater" <clg@redhat.com> (commit_signer:1/3=33%)
Michael Tokarev <mjt@tls.msk.ru> (commit_signer:1/3=33%)
qemu-devel@nongnu.org (open list:All patches CC here)

Thanks-Jamin

> Thanks,
> 
> C.